From patchwork Mon Apr 15 19:34:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda X-Patchwork-Id: 13630597 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 07CF0C4345F for ; Mon, 15 Apr 2024 19:36:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JN5K4oGkf0ulKlnWtuRVauLUCSUTFgeIgyea/ANHZTs=; b=k+aQIYUfUAw0My nOqUvCNPpHL+XOF0ZU+e2cTxsI39zm0OF5fJpA7O2UOuiyLy0NGzClDKwwCDz3mPfoRvD0tmCoHu7 hDKgXJadvTcvvCj1yJR6AQij76vZVykO5YOhOws3I6eVB2I7BOwKIEiECwOjaI1Jxpz4WewzXfisM Gf3CKj28F4YbRNajl0SAgFCLnyHVbwTAkeVJLrf/+Toywtc7fevuYX1HKmPkqpkYU8XebsOb7bVtu Z1rzaTWEDYt18OHZBZG3EJXo6WVOwPcOAdybA/6dMD9ImG0XeU3KcN9kL0GUT17GO0hn+cR55m0+J ym56tGSDVfRNZ42foAyw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwS7x-00000009d8b-2ZRU; Mon, 15 Apr 2024 19:36:29 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwS6P-00000009c7X-0HCf for linux-arm-kernel@bombadil.infradead.org; Mon, 15 Apr 2024 19:34:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Sender:Reply-To:Content-ID:Content-Description; bh=8w49vqOwnRlIfNq1dtx4OWinIRfPHFawqCMqrawnhls=; b=NSlsQVIk33soXdkwBwoR05Gug1 h16yDvyzaPDQuZydp7MpmvlzmEXsSFwZtz+jb8LFoBwVdDUF/tXOwWVh92w2QHkL6vGVmPXsvoh8Z w9u+FUei+qTyAXfEBjqcrqWUuK5n38o/VKqGa4T8XQOWBxKdSQ7NlqRdVDE8Vd4DPfjRsbM6vYNS9 mle179HN+OQBIoHVfoy70IrF6HtnjV/SW2Kw+ejKOILum78yzXBFWwAfITY2/u7dW7mmF6lp9gFX3 3M40+4vsl2Qf0Lkph+Pq4RZY8XtP31eeGM1WOH87x4Q5w2EIsrPByiHZmWmnJUodByLR1S+xqX5aJ 19HS1uag==; Received: from mail-qk1-x731.google.com ([2607:f8b0:4864:20::731]) by desiato.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwS68-0000000AieZ-0MCr for linux-arm-kernel@lists.infradead.org; Mon, 15 Apr 2024 19:34:41 +0000 Received: by mail-qk1-x731.google.com with SMTP id af79cd13be357-78d5e80bc42so314622385a.0 for ; Mon, 15 Apr 2024 12:34:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1713209673; x=1713814473; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=8w49vqOwnRlIfNq1dtx4OWinIRfPHFawqCMqrawnhls=; b=SXSJyJOE6QQC/V7SLIkSUMATmbOkbIb5YEyfdEhY/7XGHwgQjxysZItg+rCQckT++P LZGPXFkWg6nOi7YLRZzgHFopaFap6JaLS2w+jZ+HIQgGLl7N1jin/Quz6C9EqcvC2BUe vfSjjrnoiutARqtToLBD9H77Sd0dnTjK12UX0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713209673; x=1713814473; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8w49vqOwnRlIfNq1dtx4OWinIRfPHFawqCMqrawnhls=; b=IjhoPBx1HvBYcUIkEPVDG8Gibni8++0LG4u/IJD6Zaoib8sxgprhpLFVsBBMnZoBZm Yl/lxY+9fiG+5vZeq/b615/2zmu/Ol7uc1IeOS7EOW+LPfTHc7vvMud5BuFWNR4g/bsM q+L43T+0FsMtD8zgInDsEOBeHfcghl78lTdo8cv00cYCK8sIf4IfcbHYp7FXgx73IGzL X0bCp2lxMQJc+FJPASxigULytDzofMgPv3kreDsRso1nXKA9V34LhDZtXZ+O78WVa8+Z EJ9hGf4A27cjZIt0X/vtgCx2wchfLMNqaegxV52hU1rjjkXkl+LdF6DUBTx7sZWfR86w CLLw== X-Forwarded-Encrypted: i=1; AJvYcCX4bieSPQfL30GnifDFVRYIjM/ItCtjj0X6tDYzkhAdMW9q+lIxb1WwzYvK6K5olX489DbSQ6Ze+ofWE7bfwM24Wklkvsta2zlIoAnn6jZl3fZ7eng= X-Gm-Message-State: AOJu0YwnupGVMkfIElTCpFTN8W9TSPpGBNl+3UFK/Tp2hyRLdbJeOAcS J82qjmFWeXvUUTacNPAmPJ4A1Qw6DFFydxxgtgsoAAJdfp6mFQw7eTiZDEXRPw== X-Google-Smtp-Source: AGHT+IF3Z64gOvH813ZrsURn6c5OX0cA+P7DewlH+o86rsWDf5urUOYDJaPeLXGD215pMul/2CCAvg== X-Received: by 2002:a05:620a:5e48:b0:78e:e7f8:a5e3 with SMTP id ya8-20020a05620a5e4800b0078ee7f8a5e3mr3707352qkn.52.1713209673334; Mon, 15 Apr 2024 12:34:33 -0700 (PDT) Received: from denia.c.googlers.com (114.152.245.35.bc.googleusercontent.com. [35.245.152.114]) by smtp.gmail.com with ESMTPSA id s26-20020ae9f71a000000b0078d3b54eb76sm6718055qkg.78.2024.04.15.12.34.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Apr 2024 12:34:33 -0700 (PDT) From: Ricardo Ribalda Date: Mon, 15 Apr 2024 19:34:23 +0000 Subject: [PATCH 06/35] media: stm32-dcmipp: Remove redundant printk MIME-Version: 1.0 Message-Id: <20240415-fix-cocci-v1-6-477afb23728b@chromium.org> References: <20240415-fix-cocci-v1-0-477afb23728b@chromium.org> In-Reply-To: <20240415-fix-cocci-v1-0-477afb23728b@chromium.org> To: Martin Tuma , Mauro Carvalho Chehab , Laurent Pinchart , Hans Verkuil , Hugues Fruchet , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Paul Kocialkowski , Greg Kroah-Hartman , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Sakari Ailus , Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Luca Ceresoli , Matthias Brugger , AngeloGioacchino Del Regno , Hans Verkuil , Sergey Kozlov , Abylay Ospan , Ezequiel Garcia , Dmitry Osipenko , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio , Benjamin Mugnier , Sylvain Petinot , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , =?utf-8?q?Ni?= =?utf-8?q?klas_S=C3=B6derlund?= , Pavel Machek Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240415_203436_631471_3EA6B35E X-CRM114-Status: GOOD ( 13.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org platform_get_irq() already prints an error message. Found by cocci: drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c:444:3-10: line 444 is redundant because platform_get_irq() already prints an error Signed-off-by: Ricardo Ribalda --- drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c b/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c index bce821eb71ce..c25027b0ca32 100644 --- a/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c +++ b/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c @@ -439,11 +439,8 @@ static int dcmipp_probe(struct platform_device *pdev) "Could not get reset control\n"); irq = platform_get_irq(pdev, 0); - if (irq <= 0) { - if (irq != -EPROBE_DEFER) - dev_err(&pdev->dev, "Could not get irq\n"); + if (irq <= 0) return irq ? irq : -ENXIO; - } dcmipp->regs = devm_platform_get_and_ioremap_resource(pdev, 0, NULL); if (IS_ERR(dcmipp->regs)) {