From patchwork Mon Apr 15 19:34:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda X-Patchwork-Id: 13630643 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 25CE0C00A94 for ; Mon, 15 Apr 2024 19:39:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=p2ODGpmvRD12gMo46OkkmdMfRQsI3OEZ3QWws7nhBog=; b=iSW88utVW0wFrC mpkaxrXxG7Nv8QFJsvaR808+qms7wE+QeC5k2C7v9CYAK21lJSsrOep6pS7b2fQJXDW7TnyAJsi+7 23Q2dA6COMdUhBzMyLV/CmjRIt4CaSbZQy3iyhJgjFc43bdHYam2NdqfGEcRGvJQYYd36hAMhKQkD 4o/JcXZ3RPROMXP7gTt29KI+mH2j2NKKg26KlVmBP8nOmiTGKQcPX3C4eDy88F70V3ldTeJ1WSnYk mgFAhVIhzKnMXw9r2In4rS1iYOq65MA6PNRMXQ/SzJ5o+euruVNkqI7HjDaIxD4eio4w/TZyvrp5E 7E7waqguCXSra9KJ84Yg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwSBC-00000009f4O-0uA1; Mon, 15 Apr 2024 19:39:50 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwS6O-00000009c6b-0UJw for linux-arm-kernel@bombadil.infradead.org; Mon, 15 Apr 2024 19:34:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Sender:Reply-To:Content-ID:Content-Description; bh=Zm8YRFoKsGw65QxzcHtGCuYCsdcn5gIPOa2id9cD3ac=; b=H/qNeyf5LiMnGNsZhrpS083AyU qhM+3VJDYmMryldJuZDCqYfQD0ZP0qDKma1Nh/6vqr3BiNr1RdtUCYyQAGT6oc0HTN/a2c+E7HKY/ IU8jTj7quzs/Sg2ihbfRE+YtLAxpONh2F2E8xGx8ZR1SS8yoe7ZZ/GZhV2xXYDhQJSpEB1070dP21 x1k0QU04yoZJJRgD9xqx7NP+flhRWip6y3XD6CZW+pGNrXoiv59sk4cCxvpW5J3DEwt3qFX0WVoFC /YsxKQHtSSmnvNedFY4zvT03hEqXJmrawxPqIDs2S65gQ0ryn7Y34ciERtMwxYhOkXyxMGcfH5erq hNFf7HgA==; Received: from mail-qk1-x732.google.com ([2607:f8b0:4864:20::732]) by desiato.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwS68-0000000Aiea-1hLa for linux-arm-kernel@lists.infradead.org; Mon, 15 Apr 2024 19:34:41 +0000 Received: by mail-qk1-x732.google.com with SMTP id af79cd13be357-78d61a716ddso251504185a.3 for ; Mon, 15 Apr 2024 12:34:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1713209674; x=1713814474; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Zm8YRFoKsGw65QxzcHtGCuYCsdcn5gIPOa2id9cD3ac=; b=D5oA5mCj9RIRR4eNjdBJce96+65iVx+VnAuHyTWLpFf1x9MxJDH+/wez7/DNs4ZBGu bKi5MBCQh4SkBuHhALCWmas9fTQOEM1SYqlQft3yvmbhhG0mYTc8VKFu6Af+0UZwEbjB mapjJ7nCPJpWrALJN9R4XpMtyOZmPtaTt8GoU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713209674; x=1713814474; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Zm8YRFoKsGw65QxzcHtGCuYCsdcn5gIPOa2id9cD3ac=; b=Xk4qSqD6bQ+FDRfatn+fZT3hUFlJi5VVfAgFprH/JijD3eXKt9owu0CN8tQ5zMinJj +BOQXiuq1kE0hrRZHIij+00tQEB/7zf7caLEAw2FOBFLdHOJCcffSHUknZUXiWDeURg8 EdLpyASpbpdgTbRh3uJuK+1WpCmPtUmZkjYPGgcrbxtbNY1ZU/LW0ogvAMmUwoF2TxMF Sd9guqGSBXeiWOw1kDobiYKDCcKVZOxUT49qiG3t14rrF8vsw3MrtVBF+pY2dEdaDlwU 2H+h+fzAa1EKKQ+PE58kBDRbJva/RQ853aOpB44QFjviMymt+5jU7GMKRRJjEI95QzfJ 5skA== X-Forwarded-Encrypted: i=1; AJvYcCXHBfVlY9H8K4H/iQK54st/XEPAelc4m4C2WldKq+hrwSkmC1Oq6pynYCVHoHy9Zl/PN3zbGge82IC+Z1BvZB/PO8vt0K2/0WSyJmqZO2QvRZhPCRo= X-Gm-Message-State: AOJu0YwwWyLH2Br/jsuODrexF3eCqDspdHSxD8bTynexTafbBQ+a7Ut1 3NojxscNW5XV62hymX3S7F/JDvIiOGWsA5/bwktbLhkiMHQgFDrZJRZPni7H1Q== X-Google-Smtp-Source: AGHT+IE9q0KgLtAucdxZbWyn6MqzUt/EZtQ+H412AW7kKWoV5ItTNsK0gfo742OJilnTZ7BcAn728w== X-Received: by 2002:a05:620a:2116:b0:78d:61e8:2f12 with SMTP id l22-20020a05620a211600b0078d61e82f12mr12082197qkl.57.1713209674381; Mon, 15 Apr 2024 12:34:34 -0700 (PDT) Received: from denia.c.googlers.com (114.152.245.35.bc.googleusercontent.com. [35.245.152.114]) by smtp.gmail.com with ESMTPSA id s26-20020ae9f71a000000b0078d3b54eb76sm6718055qkg.78.2024.04.15.12.34.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Apr 2024 12:34:34 -0700 (PDT) From: Ricardo Ribalda Date: Mon, 15 Apr 2024 19:34:24 +0000 Subject: [PATCH 07/35] media: staging: sun6i-isp: Remove redundant printk MIME-Version: 1.0 Message-Id: <20240415-fix-cocci-v1-7-477afb23728b@chromium.org> References: <20240415-fix-cocci-v1-0-477afb23728b@chromium.org> In-Reply-To: <20240415-fix-cocci-v1-0-477afb23728b@chromium.org> To: Martin Tuma , Mauro Carvalho Chehab , Laurent Pinchart , Hans Verkuil , Hugues Fruchet , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Paul Kocialkowski , Greg Kroah-Hartman , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Sakari Ailus , Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Luca Ceresoli , Matthias Brugger , AngeloGioacchino Del Regno , Hans Verkuil , Sergey Kozlov , Abylay Ospan , Ezequiel Garcia , Dmitry Osipenko , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio , Benjamin Mugnier , Sylvain Petinot , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , =?utf-8?q?Ni?= =?utf-8?q?klas_S=C3=B6derlund?= , Pavel Machek Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240415_203436_866095_EF3FC78C X-CRM114-Status: GOOD ( 12.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org platform_get_irq() already prints an error for us. Found by cocci: drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.c:389:2-9: line 389 is redundant because platform_get_irq() already prints an error Signed-off-by: Ricardo Ribalda Acked-by: Jernej Skrabec --- drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.c b/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.c index 5c0a45394cba..a6424fe7023b 100644 --- a/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.c +++ b/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.c @@ -386,7 +386,6 @@ static int sun6i_isp_resources_setup(struct sun6i_isp_device *isp_dev, irq = platform_get_irq(platform_dev, 0); if (irq < 0) { - dev_err(dev, "failed to get interrupt\n"); ret = -ENXIO; goto error_clock_rate_exclusive; }