From patchwork Thu Apr 18 00:05:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shivani Gupta X-Patchwork-Id: 13634022 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6C239C4345F for ; Thu, 18 Apr 2024 00:05:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=syxyMdblCYY14O3wUk0Q14mXTi7t5U8op0jVLXpB79M=; b=WMvLSnIAAQyH08 T7Em+MjtsrcRtP+t4wDe97GxEaRkRwxnS0fsFlM9ft6B/rgknzgzE/J2ZCHvI9/JfjBI3kJcEN9az HPnYdtXASY6+YJzxaIXbm5nKdhqPLm/74zUEWMwJzUMD3YKbQQyOiwzoHL3DjFYGfkIS8fH/5mwe7 H6ithvJUo2B9RYMWk9AxYFfzmCk8DZW/F5r54qkZopX68uiBfU0lNNtJtGpTuFKkysnOnV2Tq/ssb ehOkzuB9VyPE+VCEdVdasGCn4ELOcYCLQSzi/d0Q1l3Dyz7olHJbjLp1Ne5sGSG52npfEP1vKbsQ4 S7+4K7Ww/CyvrkA1tZPw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxFHM-00000000NkD-3qGu; Thu, 18 Apr 2024 00:05:28 +0000 Received: from mail-il1-x133.google.com ([2607:f8b0:4864:20::133]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxFHK-00000000Niu-01zT for linux-arm-kernel@lists.infradead.org; Thu, 18 Apr 2024 00:05:27 +0000 Received: by mail-il1-x133.google.com with SMTP id e9e14a558f8ab-36b08fc1913so1150445ab.0 for ; Wed, 17 Apr 2024 17:05:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713398723; x=1714003523; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=7lw/eo8vYS/jr51eHoroeN5VlW5AAoYkDX60WZMmgGs=; b=N3uHHnl272rPJ5xZXtGq4soyoNjC4qFDYpflCXhgaz8UlQJclf9RrauAQfqTS6VRl+ O0V1ZWmcRU76pzr7gMB5T0QQUXo99DkeV9AbUcdzehimMxiEeRPhHqsVvLcAd4fcF1yf UxkwpnuMJ8/vP0G+7VcdAZIuKiaG3OdfD3B/atcffyOKdUWIL8QZOPiV5HVhjVv7HP19 +TARsDCFjW9t0VtHC14wkOnq5jjlKNzXsGqQcrlZXYOyILu/EMv2fuLhnbpHOsN40B7A lF14+zavSrzuRVR+twW+/nS8+CIUFQuYBcN8HKGv/t27bcxzoqun5gZORw8CdfR75Tm1 fB3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713398723; x=1714003523; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7lw/eo8vYS/jr51eHoroeN5VlW5AAoYkDX60WZMmgGs=; b=PUTyVsNsR3BJuP+84556tbXru3xI8lOzZv1K3+HV7jL41/g4Ibs1iV5Zm/XJwbwDSA tGr7OMR4PWQ412lvTxKy1T//nt86FAntfSuKi0/Jj+JZ0UexCEkQ+7AH46ovCdUxlVje /w6V9+Tr+xzstqYbp8mB0LzK4fE35b8vIlcO4E07/iPhyj7cWSLVGfEiYgytA+Iw0SuZ 0P3+N9ONDSKtpIwHTf0ckXBDmAgO6egLmYo49M8+ASW81FhV78NAQBGeLY30/ozqq7r2 eEZxTCMS8HeSXB0ICkxTKGQbxnBPRk2AD1KAcVW4aVSWi6D4DsGHi1iUv1zGhHJqfMSQ B4SA== X-Forwarded-Encrypted: i=1; AJvYcCWp5vmJM+lhQtClFTh7VLIRHgpK4ieS+8smkK8qxY2ZbbNA1Y/+dgje4uFwYIf66BSS5AiL2sVKlyhvyzJygZUcKkXJRCsQYTL4rB8DIF0v8RcMkno= X-Gm-Message-State: AOJu0YxjSGLeQ18ucbjUVji0tMtixVotcq1i+3MZBALyc94k+tPozajY 84gG2kmvhFAgQlMMT9Av7U9cmT2BTAbWWeGfE5ujqq+DAY7bcz3P X-Google-Smtp-Source: AGHT+IGOWuVeNK5n1yJtOE4vhdXiU4Ah+hHLYIlOUB/p61hc5VYbJesLZUvdNIwAU0mwyRjpJLuSVg== X-Received: by 2002:a05:6e02:1d05:b0:36b:3024:a4da with SMTP id i5-20020a056e021d0500b0036b3024a4damr917731ila.3.1713398722906; Wed, 17 Apr 2024 17:05:22 -0700 (PDT) Received: from shiv-machina.. (c-73-169-52-138.hsd1.co.comcast.net. [73.169.52.138]) by smtp.gmail.com with ESMTPSA id ix10-20020a056638878a00b004830f829b86sm90127jab.133.2024.04.17.17.05.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Apr 2024 17:05:22 -0700 (PDT) From: Shivani Gupta To: andi.shyti@kernel.org, broonie@kernel.org, krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com Cc: linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, javier.carrasco.cruz@gmail.com, Shivani Gupta , Julia Lawall Subject: [PATCH] spi: spi-s3c64xx.c: Remove of_node_put for auto cleanup Date: Thu, 18 Apr 2024 00:05:05 +0000 Message-Id: <20240418000505.731724-1-shivani07g@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240417_170526_181397_0ABF3681 X-CRM114-Status: GOOD ( 12.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Use the scope based of_node_put() cleanup in s3c64xx_spi_csinfo to automatically release the device node with the __free() cleanup handler Initialize data_np at the point of declaration for clarity of scope. This change reduces the risk of memory leaks and simplifies the code by removing manual node put call. Suggested-by: Julia Lawall Signed-off-by: Shivani Gupta --- drivers/spi/spi-s3c64xx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.34.1 diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index f726d8670428..833c58c88e40 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -950,7 +950,7 @@ static struct s3c64xx_spi_csinfo *s3c64xx_get_target_ctrldata( struct spi_device *spi) { struct s3c64xx_spi_csinfo *cs; - struct device_node *target_np, *data_np = NULL; + struct device_node *target_np; u32 fb_delay = 0; target_np = spi->dev.of_node; @@ -963,7 +963,8 @@ static struct s3c64xx_spi_csinfo *s3c64xx_get_target_ctrldata( if (!cs) return ERR_PTR(-ENOMEM); - data_np = of_get_child_by_name(target_np, "controller-data"); + struct device_node *data_np __free(device_node) = + of_get_child_by_name(target_np, "controller-data"); if (!data_np) { dev_info(&spi->dev, "feedback delay set to default (0)\n"); return cs; @@ -971,7 +972,6 @@ static struct s3c64xx_spi_csinfo *s3c64xx_get_target_ctrldata( of_property_read_u32(data_np, "samsung,spi-feedback-delay", &fb_delay); cs->fb_delay = fb_delay; - of_node_put(data_np); return cs; }