| Message ID | 20240418122859.2079099-6-f.suligoi@asem.it (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: dts: remove tx-sched-sp property in snps,dwmac | expand |
On 18/04/2024 14:28, Flavio Suligoi wrote: > Strict priority for the tx scheduler is by default in Linux driver, so the > tx-sched-sp property was removed in commit aed6864035b1 ("net: stmmac: > platform: Delete a redundant condition branch"). > > So we can safely remove this property from this device-tree. > > Signed-off-by: Flavio Suligoi <f.suligoi@asem.it> > Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> NAK. Not true. Please point me to my review for this patch. Best regards, Krzysztof
Hi Krzysztof, ... > On 18/04/2024 14:28, Flavio Suligoi wrote: > > Strict priority for the tx scheduler is by default in Linux driver, so > > the tx-sched-sp property was removed in commit aed6864035b1 ("net: > stmmac: > > platform: Delete a redundant condition branch"). > > > > So we can safely remove this property from this device-tree. > > > > Signed-off-by: Flavio Suligoi <f.suligoi@asem.it> > > Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> > > NAK. Not true. Please point me to my review for this patch. I'm very sorry for the misunderstanding, I saw your reply in: https://lore.kernel.org/netdev/010d67c7-ca71-43fc-a3e3-ec3e5cd8b149@kernel.org/ and thought it might be okay for all the other patches. Do you want me to resend a v3 version of the patches without the "Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>" ? > > Best regards, > Krzysztof Thanks and best regards, Flavio
On 19/04/2024 10:45, FLAVIO SULIGOI wrote: > Hi Krzysztof, > > ... > >> On 18/04/2024 14:28, Flavio Suligoi wrote: >>> Strict priority for the tx scheduler is by default in Linux driver, so >>> the tx-sched-sp property was removed in commit aed6864035b1 ("net: >> stmmac: >>> platform: Delete a redundant condition branch"). >>> >>> So we can safely remove this property from this device-tree. >>> >>> Signed-off-by: Flavio Suligoi <f.suligoi@asem.it> >>> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> >> >> NAK. Not true. Please point me to my review for this patch. > > I'm very sorry for the misunderstanding, I saw your reply in: > > https://lore.kernel.org/netdev/010d67c7-ca71-43fc-a3e3-ec3e5cd8b149@kernel.org/ > > and thought it might be okay for all the other patches. Where was it replied? In patch 5. Why can't you use b4 for this? It solves the problems. > > Do you want me to resend a v3 version of the patches without the > "Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>" ? Yes, you must send new version because you added fake tags. Use b4 trailers to collect tags. https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts index 26ad05bd3b3f..2e1770e07f45 100644 --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts +++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts @@ -334,7 +334,6 @@ queue3 { mtl_tx_setup: tx-queues-config { snps,tx-queues-to-use = <4>; - snps,tx-sched-sp; queue0 { snps,dcb-algorithm; @@ -404,7 +403,6 @@ queue3 { mtl_tx_setup1: tx-queues-config { snps,tx-queues-to-use = <4>; - snps,tx-sched-sp; queue0 { snps,dcb-algorithm;
Strict priority for the tx scheduler is by default in Linux driver, so the tx-sched-sp property was removed in commit aed6864035b1 ("net: stmmac: platform: Delete a redundant condition branch"). So we can safely remove this property from this device-tree. Signed-off-by: Flavio Suligoi <f.suligoi@asem.it> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> --- arch/arm64/boot/dts/qcom/sa8775p-ride.dts | 2 -- 1 file changed, 2 deletions(-)