From patchwork Fri Apr 19 09:47:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda X-Patchwork-Id: 13636096 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F05BC04FF6 for ; Fri, 19 Apr 2024 09:52:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZU32m1txodhKfxE10fy4Y9OV75yiqH9KpnrgTCrG5pk=; b=vqyCTNl310ycwl iv3qiuMYepJTp2D/l286R8DHE0TRVQ4nj2qFBKmbIM0sc+GlJiARUEPukyV0IwFWIJGhfx2uqJKPc Cmy3CpYFSVptNQvufPL3e8npZNHqSatLFHgL/Nis95jh3qAxxtOYPWZWr7jCUW+DfxZTa/vDSBaa0 riDW2FIV/aeF+n6mMvZLISQuDFdp6+aZ4MwaJrh569oaQOf8B7NZfwozV+os2X4TeSv7VfPy5J6Zp xvoxwX94FVBgJ1bEAObDG3fy3f3L7IrXC/DCTlt5p8haKCzG46iR+aIeLj7QuduFoRyqhNbj5TLAZ nX1n42s0qxYsUxfuhiQw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxkud-00000005ATx-0dNw; Fri, 19 Apr 2024 09:52:07 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxksO-000000059BX-2UWU for linux-arm-kernel@bombadil.infradead.org; Fri, 19 Apr 2024 09:49:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Sender:Reply-To:Content-ID:Content-Description; bh=LtYl9w0rOEhkj26cvWhCGa7iaXgSAClc12fCrbixCRY=; b=M3Uyy3okNIYPkjIHtQV6uFIlpo WG2ZN6+Xp4hWqkOrHcX67BU1IFaGOVKF80huxG+cULzmcMDcYoXckEHIIaKSM9wvsde40d+/5zQx+ ygTawaH04+FroMHOTploEXkGg7t+/Op/vBqLQQeiYnOxCyXZJviG0aPRpG2TtFJoteH/78Y3OLFMK To++xvfTiEaoT0E2w5kyzPYNLYGK5DGOTT/IPM0UNdKTa7ppwVC0f7msrhLgUDACp7QAuh9n5eHPg P6O+7nwN+ihOc0sofc+Ed9x1D73sNUWs0+PiYpR14DYbZUV2mSGVs5UvmFCDPrHaHsHg4kqyyxysV 5b1CUF2Q==; Received: from mail-qk1-x734.google.com ([2607:f8b0:4864:20::734]) by desiato.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxksG-0000000COPC-2lXT for linux-arm-kernel@lists.infradead.org; Fri, 19 Apr 2024 09:49:46 +0000 Received: by mail-qk1-x734.google.com with SMTP id af79cd13be357-78f02298dc6so151328385a.1 for ; Fri, 19 Apr 2024 02:49:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1713520167; x=1714124967; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=LtYl9w0rOEhkj26cvWhCGa7iaXgSAClc12fCrbixCRY=; b=VieoLwg1yXcpGl0JmH35TuMTY2iX/k60AXpOkjC4F/xhPF8BNp2CQ7Vpp8wpicMjYo 5o0wmTkbuQsQs0FCjEEAYsmVyWN2GzIITqxIlqwM/PD9bfykGdptqJJ46t2b2ExO4P1V LC7mEWmtK0i/1k1/NSenlbhDCWA4Hr4GiEB58= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713520167; x=1714124967; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LtYl9w0rOEhkj26cvWhCGa7iaXgSAClc12fCrbixCRY=; b=W1c6y58QkRx/auBlx7utZQ14LXv5rdEgmzokkav3YzOF2RzbCoxwlGMnESiw/+OaNV HWTs0coWiaEaKsEe9kCIQaqjMIsVtmlTvZdx6Cp3YsGalji1m9AuiVoJr/4XAa4j1tDX WL9WweWGDHJE1oGjOQpzvmoRNtTs1a+hUWP5UAPo7QmJPT7wFAh0CyekSfJJbK8lTC5J 3SswoQbEUu5lZVd+yelDOBW+UeI48vpfJTgS+x9Cuny4O1EDEjQwXBlpyzunDWFxsNq6 RIz4M5OVpYfTQHZXTqe1lUNf0roBNnnilC/Ryrz90L0ZvrRqEsKjpruuH1cEMCDQ3M9l 6LvA== X-Forwarded-Encrypted: i=1; AJvYcCWXyopkMjGoLBPdJMbgb/JP46Sg+5TvAXVlDAhj9vYZ3PXC1bY74lhfrWvfmW01Mk/aKpHf9kgKNuXSOva+GVmWR2G1dxNX4z9QaWV0uxtdrWs97Kc= X-Gm-Message-State: AOJu0Yzl+dbxD9ujGhB3Mvficls7PSZpqUyjAU44w44Cs4TVe6B9hacu tgEmtB+/RQv3+q+yITdeW3rlQhhqLngtn1Rk9cEroMZiGdSoZEhKqfimBSxloQ== X-Google-Smtp-Source: AGHT+IHJxWxlXkvVgayg/8KmEPlEYrjGm6s2oAW8VlNrxH8CHO+X8RZjNxTD6ZWD86mZ22X+MElfTw== X-Received: by 2002:a37:de0e:0:b0:78e:eb64:d91 with SMTP id h14-20020a37de0e000000b0078eeb640d91mr2763665qkj.1.1713520167230; Fri, 19 Apr 2024 02:49:27 -0700 (PDT) Received: from denia.c.googlers.com (114.152.245.35.bc.googleusercontent.com. [35.245.152.114]) by smtp.gmail.com with ESMTPSA id dt14-20020a05620a478e00b0078d735ca917sm1434532qkb.123.2024.04.19.02.49.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Apr 2024 02:49:26 -0700 (PDT) From: Ricardo Ribalda Date: Fri, 19 Apr 2024 09:47:52 +0000 Subject: [PATCH v2 06/26] media: stm32-dcmipp: Remove redundant printk MIME-Version: 1.0 Message-Id: <20240419-fix-cocci-v2-6-2119e692309c@chromium.org> References: <20240419-fix-cocci-v2-0-2119e692309c@chromium.org> In-Reply-To: <20240419-fix-cocci-v2-0-2119e692309c@chromium.org> To: Martin Tuma , Mauro Carvalho Chehab , Laurent Pinchart , Hugues Fruchet , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Paul Kocialkowski , Greg Kroah-Hartman , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Sakari Ailus , Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Luca Ceresoli , Matthias Brugger , AngeloGioacchino Del Regno , Hans Verkuil , Sergey Kozlov , Abylay Ospan , Ezequiel Garcia , Dmitry Osipenko , Benjamin Mugnier , Sylvain Petinot , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240419_104942_249748_483DE573 X-CRM114-Status: GOOD ( 14.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org platform_get_irq() already prints an error message. Found by cocci: drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c:444:3-10: line 444 is redundant because platform_get_irq() already prints an error Signed-off-by: Ricardo Ribalda --- drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c b/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c index bce821eb71ce..4acc3b90d03a 100644 --- a/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c +++ b/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c @@ -439,11 +439,8 @@ static int dcmipp_probe(struct platform_device *pdev) "Could not get reset control\n"); irq = platform_get_irq(pdev, 0); - if (irq <= 0) { - if (irq != -EPROBE_DEFER) - dev_err(&pdev->dev, "Could not get irq\n"); - return irq ? irq : -ENXIO; - } + if (irq < 0) + return irq; dcmipp->regs = devm_platform_get_and_ioremap_resource(pdev, 0, NULL); if (IS_ERR(dcmipp->regs)) {