From patchwork Fri Apr 19 09:47:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda X-Patchwork-Id: 13636223 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B9BBEC4345F for ; Fri, 19 Apr 2024 11:01:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7Ofaw8FZbR6I9NiBS36Ui1LvKvQTx1m85Ae/gd1OsEI=; b=PKsqt3NTzr6fVd gug3znb35c/oIAP9wljHaecl34Fzahg4l79ugYwP4+dvfahjIVOeGm3RyYPjOgr1YugMpFQJQdWEL z9RgYmjYGMtGHXanuQRvWskaDg6+qEMtoUaY3uqa6CjgkUMecay4XNSNyPh55tv0hwhCuhTo7NIIU BI7Z02x3c76htkh78l7eFaY31dLud9QCoK7s0CdVWAs83KMzOIRcEMVRtyV63L6xG86W1pJvKJ+ax 98CyOfvbpbYm7efSWucHv7+AEAh3Ox80xofUy8arrzu9HH8zW6i4ebNt14QYuX6n7uZ8XisTeFX53 xvAQunMpVITljujYiIuQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxlzm-00000005NmO-20g7; Fri, 19 Apr 2024 11:01:30 +0000 Received: from mail-qk1-f173.google.com ([209.85.222.173]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxksA-000000058tS-495V for linux-arm-kernel@lists.infradead.org; Fri, 19 Apr 2024 09:49:37 +0000 Received: by mail-qk1-f173.google.com with SMTP id af79cd13be357-78edc0f9636so124268485a.2 for ; Fri, 19 Apr 2024 02:49:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1713520168; x=1714124968; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=/qUCWhD1zt8bKcdbs6yESnMSEdigGZ2fB7xO4uH5zQE=; b=Fus2+N70S2qjvVvu0/6vtfUNPOxEf5GrzY84LMmPma3quYiDEentg0gL7HhYTvKHFN Bwfv/vgsyBrSpbQPAyPFgA58bM8s3TLCTtmZrPKaP8pcHB5IeMxHE05RUTyxsp/X86gX T2fuQ2j6BAsQYiP+dRjDwnbco4MOa95p+3N90= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713520168; x=1714124968; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/qUCWhD1zt8bKcdbs6yESnMSEdigGZ2fB7xO4uH5zQE=; b=k7zAHrJrBKxLviAYWTm6NjgRQvKtW0D8lf5qVvoe8w+HxhIl9Kn/slqF6haO4u2AvW q/PuWeMgwfVUISjrV4hLjpg4MNMVqDo70VviErIH87YsoYLlQeAZxRyes8Rv7PEJsqpi RyHJBkWkaj4R0MGcreceXlRdLSPzq+E9YUsKxTz8SCVFMwmFEFpb8tFlxP7qDoIA6N0+ uHchbm47M970on472llHkmFpczC660RB8gJ65Uq4HuQ1fxFwAti3u7HoFys1dj1V6Lpn jwfKUOrPNvlUTBNKlLtHtgAxU520fX4QAfPjAGebZoZ/1YuNt00H+Yszkx3WrdeAj4Pl JL+g== X-Forwarded-Encrypted: i=1; AJvYcCU7EHm218lx3NAsDGQVhqosofMOIihEmbkTZuhLyCXhiKB2U18P4hhUX5GQtLLxnQXkHbWwQIaPCD/9hG2DJoMzNIgaZBBESvxfurEbtdjdRtAQuZU= X-Gm-Message-State: AOJu0Yze2MjfyFWYa2wTc8QKyG1HwY4s/3p05y6XcvzC1k7s4rQyrLyc dLrLfkdzz4mh5xGpjq8KXjYt6BL0rzQxSXbxWFniRLlIi4AQ7ZQYtov9lkKmyg== X-Google-Smtp-Source: AGHT+IGrWT0O4AGlUln/2gm+WlWRdrbCZXYUSj9v1TAvaCupc//lNt4+QKq4Vo16BjNxQ14XM/vY2A== X-Received: by 2002:a05:620a:4083:b0:78e:db2f:2726 with SMTP id f3-20020a05620a408300b0078edb2f2726mr1792928qko.51.1713520168153; Fri, 19 Apr 2024 02:49:28 -0700 (PDT) Received: from denia.c.googlers.com (114.152.245.35.bc.googleusercontent.com. [35.245.152.114]) by smtp.gmail.com with ESMTPSA id dt14-20020a05620a478e00b0078d735ca917sm1434532qkb.123.2024.04.19.02.49.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Apr 2024 02:49:27 -0700 (PDT) From: Ricardo Ribalda Date: Fri, 19 Apr 2024 09:47:53 +0000 Subject: [PATCH v2 07/26] media: staging: sun6i-isp: Remove redundant printk MIME-Version: 1.0 Message-Id: <20240419-fix-cocci-v2-7-2119e692309c@chromium.org> References: <20240419-fix-cocci-v2-0-2119e692309c@chromium.org> In-Reply-To: <20240419-fix-cocci-v2-0-2119e692309c@chromium.org> To: Martin Tuma , Mauro Carvalho Chehab , Laurent Pinchart , Hugues Fruchet , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Paul Kocialkowski , Greg Kroah-Hartman , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Sakari Ailus , Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Luca Ceresoli , Matthias Brugger , AngeloGioacchino Del Regno , Hans Verkuil , Sergey Kozlov , Abylay Ospan , Ezequiel Garcia , Dmitry Osipenko , Benjamin Mugnier , Sylvain Petinot , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240419_024935_093610_FF434FA7 X-CRM114-Status: GOOD ( 12.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org platform_get_irq() already prints an error for us. Found by cocci: drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.c:389:2-9: line 389 is redundant because platform_get_irq() already prints an error Acked-by: Jernej Skrabec Signed-off-by: Ricardo Ribalda --- drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.c b/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.c index 5c0a45394cba..58f8ae92320d 100644 --- a/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.c +++ b/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.c @@ -386,8 +386,7 @@ static int sun6i_isp_resources_setup(struct sun6i_isp_device *isp_dev, irq = platform_get_irq(platform_dev, 0); if (irq < 0) { - dev_err(dev, "failed to get interrupt\n"); - ret = -ENXIO; + ret = irq; goto error_clock_rate_exclusive; }