From patchwork Sat Apr 20 11:53:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 13637128 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6DBC7C4345F for ; Sat, 20 Apr 2024 11:54:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3jm8l9+bGH7c0oqOVc1YeqmdzMAEqKcDglBJX5wvnUQ=; b=YMp4EIVpVmHwLp L9/EkUVQOs8pNuTvbqUYrtx8n8/IShIKHeJCb/wMHglumXuzMCXB4qSyV8497qhyUrPRq/zhnWuzn GK3zmhItUFVUmIfZXwOFpnBeZqF5LjCrVE4WYGwgqrclaNNT6Lb59Jemu9IVJygJuWcUZbcMIBI0u OXMHuuALHt+aAfd+mPp1z3koBt8yKGm5Z35xxQnT1PVUPrcMdtLXzEcE9wLgmV5YwVxxLjCY7oDdW LJ51ffCT3TGXBc7ml6YOMWOBSJ4alcHLzC4CW66ZFLAnlJSZFTvKC6MYM3pI8DFCAsp+A4K7IMpRt n2pQdAxa8gMhWM00zR1g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ry9Id-00000008QAI-3EjS; Sat, 20 Apr 2024 11:54:31 +0000 Received: from mout.gmx.net ([212.227.15.18]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ry9IN-00000008Q6K-3JBu for linux-arm-kernel@lists.infradead.org; Sat, 20 Apr 2024 11:54:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1713614048; x=1714218848; i=wahrenst@gmx.net; bh=IdPvZZcmTz/4Jhv3avJuKOovLJWs7cPlfVl3VPx2mj4=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:Message-Id:In-Reply-To: References:MIME-Version:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=FTj1ugb1U9y4U3dVfJb4o6MJM0vjc/2mLan38rWrQPytq94fVEyru2yjY3BAh3T0 WL495muh4tXjBEF1GU/m+SxW2t9U2bLqcgESF4OdYHtb+fha7k/w6sTX5NbWwpb1I nAfndgbqcRQEqr7f0fNGQcVWxt0YNygxyWlY1oGImyXUc2rqd/sokG1J95/ZNLOUy vek/AeZvZXvF+7XGR7Q5uRIzAto82uFbHeafQbz5ykrookKp3D7UcU7CXMGvT83dW Rj/YFQmJSGJF2c/dbRHGtjB81KrEDO+Xj4zBP82F/8mi+AEZXtRNaSFe8YmYzlyIX quD+NdZr1fRleLFbTA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from stefanw-SCHENKER ([37.4.248.43]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Mlf4S-1sNpKM2fCc-00igeX; Sat, 20 Apr 2024 13:54:08 +0200 From: Stefan Wahren To: Greg Kroah-Hartman , Florian Fainelli Cc: Umang Jain , Laurent Pinchart , linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Stefan Wahren Subject: [PATCH 1/4] staging: vchiq_core: Use printk messages for devices Date: Sat, 20 Apr 2024 13:53:48 +0200 Message-Id: <20240420115351.27713-2-wahrenst@gmx.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240420115351.27713-1-wahrenst@gmx.net> References: <20240420115351.27713-1-wahrenst@gmx.net> MIME-Version: 1.0 X-Provags-ID: V03:K1:S4WO36eka4RpRX8zyZMI+Fh++NjZMYAbPn2LYBG5ZAagsBg9bZv +6dTxW4u/SJ+KIbjIV/e3GMnw9g3buzUiWYIUuf9qJ1r9WAiPPOMTcgLiaEXkeQckOmGOKf QZBAVAhYz91qqEcBlW2IpCErlth2cYHFz0mQDdYl+ihk5+7vpLY5+SjogEvGvo4zD+T6ihL PbfsSLkzTPv3QBxXldJ9Q== UI-OutboundReport: notjunk:1;M01:P0:djpi2O3a8Wo=;qsU22WJ6PCigW2NRqdwRNbuPShI IFS9yWoFI2j55iLe4wVAXme4QNlnZf30doClR1NLOXHgBZHBdzTSTz8N3a74qfLv0fF6r5LaV 7dINF0c7AGzfaHgPjK2kMFfAySCkeKjuHo31EZuSUV+mgxY128Z5FijQN3xIXv2UKO8SbNjDU 81voc4j02rM+531fq5Ia/4pVPgfM/KuzQZItxL8yBlVMav/Vgh4JYVSQeDJcooYsVAol4ZtCM Wl+YeXihZj4GBcyIEA6+pM4N5viq0XjRQnFCu1UUo0f+PD+xZKH+NQmgDuxccfQYfruG27HRL hbKoPWGXVU+nPZD1efcQ8Pvz/gK9g/4JtaKZ4nTvcgBV40ce4Q16jlLDMmBWQIWA5cZh/c/JQ iuNsvBS75rPDBkdmGNcbaA87J7rBkMkgLSbb4IBuyP6V5z+wLxeNHyLrbQpfkIEfgEwmsPngY qpbFafbWAPqToDHVbsmqDlhgSrBaNssyIZ7Kgu6X/TsL7JvOfgVCcD8LwuthvxIE1bJBlYV+u E4c4Bx1VWlzURC/VohaJdbHJ6eu8O2BDuVT94VtTGpPDfxg0r/9+V9SRewnupzxNq3QM9eSs+ OFqxXF4cNiTOx8Vdj983y5tWRfR6EQkpOubH/6wN+V60vXjjDqH/Wc/Mu7ck692Nuvkmh43kz wp8b3KNx0ca/1qkk+pK9drZ4cUa6wmSxOU1BNm7EGFcvPx0YcVJJc9udiuboyXiCdbFnWEEtP lPIOLPrUoIGUI6CzhdlSRTPpPd1i18J//55FF/PsR9wz4rxTLqlQzEDTvdjsfZZLNSjDQbnP7 /DO6ZF19u2ELafKv9SBX0uZ7F4cDVc6rBY6zdg6uqKIwQ= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240420_045416_225082_A9C9CFE4 X-CRM114-Status: GOOD ( 10.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Now that struct vchiq_state has a device reference, we can convert the remaining printk message helpers. Signed-off-by: Stefan Wahren Reviewed-by: Umang Jain --- .../vc04_services/interface/vchiq_arm/vchiq_core.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) -- 2.34.1 diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c index 3397365e551e..129d73fec2bf 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c @@ -697,7 +697,8 @@ reserve_space(struct vchiq_state *state, size_t space, int is_blocking) if (tx_pos == (state->slot_queue_available * VCHIQ_SLOT_SIZE)) { complete(&state->slot_available_event); - pr_warn("%s: invalid tx_pos: %d\n", __func__, tx_pos); + dev_warn(state->dev, "%s: invalid tx_pos: %d\n", + __func__, tx_pos); return NULL; } @@ -1732,10 +1733,9 @@ parse_message(struct vchiq_state *state, struct vchiq_header *header) break; } if (queue->process != queue->remote_insert) { - pr_err("%s: p %x != ri %x\n", - __func__, - queue->process, - queue->remote_insert); + dev_err(state->dev, "%s: p %x != ri %x\n", + __func__, queue->process, + queue->remote_insert); mutex_unlock(&service->bulk_mutex); goto bail_not_ready; }