diff mbox series

[4/4] staging: vchiq_core: Add missing blank lines

Message ID 20240420115351.27713-5-wahrenst@gmx.net (mailing list archive)
State New, archived
Headers show
Series staging: vchiq_core: Minor clean-ups | expand

Commit Message

Stefan Wahren April 20, 2024, 11:53 a.m. UTC
checkpatch.pl noticed about missing blank line after 2 declarations.
So add them for better readability.

Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
---
 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 2 ++
 1 file changed, 2 insertions(+)

--
2.34.1

Comments

Umang Jain April 21, 2024, 8:55 a.m. UTC | #1
Hi Stefan,

Thank you for the patch

On 20/04/24 5:23 pm, Stefan Wahren wrote:
> checkpatch.pl noticed about missing blank line after 2 declarations.
> So add them for better readability.
>
> Signed-off-by: Stefan Wahren <wahrenst@gmx.net>

Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>

> ---
>   drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
> index ca32902afe06..df3af821f218 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
> @@ -227,6 +227,7 @@ struct vchiq_service *handle_to_service(struct vchiq_instance *instance, unsigne
>
>   	return rcu_dereference(instance->state->services[idx]);
>   }
> +
>   struct vchiq_service *
>   find_service_by_handle(struct vchiq_instance *instance, unsigned int handle)
>   {
> @@ -2176,6 +2177,7 @@ vchiq_init_state(struct vchiq_state *state, struct vchiq_slot_zero *slot_zero, s
>
>   	for (i = 0; i < VCHIQ_MAX_SERVICES; i++) {
>   		struct vchiq_service_quota *quota = &state->service_quotas[i];
> +
>   		init_completion(&quota->quota_event);
>   	}
>
> --
> 2.34.1
>
diff mbox series

Patch

diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
index ca32902afe06..df3af821f218 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
@@ -227,6 +227,7 @@  struct vchiq_service *handle_to_service(struct vchiq_instance *instance, unsigne

 	return rcu_dereference(instance->state->services[idx]);
 }
+
 struct vchiq_service *
 find_service_by_handle(struct vchiq_instance *instance, unsigned int handle)
 {
@@ -2176,6 +2177,7 @@  vchiq_init_state(struct vchiq_state *state, struct vchiq_slot_zero *slot_zero, s

 	for (i = 0; i < VCHIQ_MAX_SERVICES; i++) {
 		struct vchiq_service_quota *quota = &state->service_quotas[i];
+
 		init_completion(&quota->quota_event);
 	}