| Message ID | 20240422002006.243687-1-marex@denx.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [01/20] dt-bindings: arm: stm32: Add compatible string for DH electronics STM32MP13xx DHCOR DHSBC board | expand |
On 22/04/2024 02:19, Marek Vasut wrote: > Add DT compatible string for DH electronics STM32MP13xx DHCOR SoM and > DHSBC carrier board. This stm32mp135f-dhcor-dhsbc board is a stack of > DHCOR SoM based on STM32MP135F SoC (900MHz / crypto capabilities) > populated on DHSBC carrier board. > > The SoM contains the following peripherals: > - STPMIC (power delivery) > - 512MB DDR3L memory > - eMMC and SDIO WiFi module > > The DHSBC carrier board contains the following peripherals: > - Two RGMII Ethernet ports > - USB-A Host port, USB-C peripheral port, USB-C power supply plug > - Expansion connector > > Signed-off-by: Marek Vasut <marex@denx.de> > --- > Cc: "Leonard Göhrs" <l.goehrs@pengutronix.de> > Cc: Ahmad Fatoum <a.fatoum@pengutronix.de> > Cc: Alexandre Torgue <alexandre.torgue@foss.st.com> > Cc: Andre Przywara <andre.przywara@arm.com> > Cc: Conor Dooley <conor+dt@kernel.org> > Cc: Dario Binacchi <dario.binacchi@amarulasolutions.com> > Cc: Krzysztof Kozlowski <krzk+dt@kernel.org> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com> > Cc: Rob Herring <robh@kernel.org> > Cc: Sean Nyekjaer <sean@geanix.com> > Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de> > Cc: devicetree@vger.kernel.org > Cc: kernel@dh-electronics.com > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-stm32@st-md-mailman.stormreply.com > --- > Documentation/devicetree/bindings/arm/stm32/stm32.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml > index bc2f43330ae42..7f61223b8ef24 100644 > --- a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml > +++ b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml > @@ -59,6 +59,12 @@ properties: > - prt,prtt1s # Protonic PRTT1S > - const: st,stm32mp151 > > + - description: DH STM32MP135 DHCOR SoM based Boards > + items: > + - const: dh,stm32mp135f-dhcor-dhsbc > + - const: dh,stm32mp131a-dhcor-som > + - const: st,stm32mp135 The entries look ordered by last compatible, so this breaks the order. Best regards, Krzysztof
On 4/22/24 6:21 AM, Krzysztof Kozlowski wrote: > On 22/04/2024 02:19, Marek Vasut wrote: >> Add DT compatible string for DH electronics STM32MP13xx DHCOR SoM and >> DHSBC carrier board. This stm32mp135f-dhcor-dhsbc board is a stack of >> DHCOR SoM based on STM32MP135F SoC (900MHz / crypto capabilities) >> populated on DHSBC carrier board. >> >> The SoM contains the following peripherals: >> - STPMIC (power delivery) >> - 512MB DDR3L memory >> - eMMC and SDIO WiFi module >> >> The DHSBC carrier board contains the following peripherals: >> - Two RGMII Ethernet ports >> - USB-A Host port, USB-C peripheral port, USB-C power supply plug >> - Expansion connector >> >> Signed-off-by: Marek Vasut <marex@denx.de> >> --- >> Cc: "Leonard Göhrs" <l.goehrs@pengutronix.de> >> Cc: Ahmad Fatoum <a.fatoum@pengutronix.de> >> Cc: Alexandre Torgue <alexandre.torgue@foss.st.com> >> Cc: Andre Przywara <andre.przywara@arm.com> >> Cc: Conor Dooley <conor+dt@kernel.org> >> Cc: Dario Binacchi <dario.binacchi@amarulasolutions.com> >> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org> >> Cc: Linus Walleij <linus.walleij@linaro.org> >> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com> >> Cc: Rob Herring <robh@kernel.org> >> Cc: Sean Nyekjaer <sean@geanix.com> >> Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de> >> Cc: devicetree@vger.kernel.org >> Cc: kernel@dh-electronics.com >> Cc: linux-arm-kernel@lists.infradead.org >> Cc: linux-stm32@st-md-mailman.stormreply.com >> --- >> Documentation/devicetree/bindings/arm/stm32/stm32.yaml | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml >> index bc2f43330ae42..7f61223b8ef24 100644 >> --- a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml >> +++ b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml >> @@ -59,6 +59,12 @@ properties: >> - prt,prtt1s # Protonic PRTT1S >> - const: st,stm32mp151 >> >> + - description: DH STM32MP135 DHCOR SoM based Boards >> + items: >> + - const: dh,stm32mp135f-dhcor-dhsbc >> + - const: dh,stm32mp131a-dhcor-som >> + - const: st,stm32mp135 > > The entries look ordered by last compatible, so this breaks the order. And uh ... I will not do last minute changes before sending out large series next time, sorry. I'll wait for Alex to see if 02..19 better be squashed or separate, and then fix this up and send V2. Thanks
On Mon, Apr 22, 2024 at 02:19:15AM +0200, Marek Vasut wrote: > Add DT compatible string for DH electronics STM32MP13xx DHCOR SoM and > DHSBC carrier board. This stm32mp135f-dhcor-dhsbc board is a stack of > DHCOR SoM based on STM32MP135F SoC (900MHz / crypto capabilities) > populated on DHSBC carrier board. > > The SoM contains the following peripherals: > - STPMIC (power delivery) > - 512MB DDR3L memory > - eMMC and SDIO WiFi module > > The DHSBC carrier board contains the following peripherals: > - Two RGMII Ethernet ports > - USB-A Host port, USB-C peripheral port, USB-C power supply plug > - Expansion connector > > Signed-off-by: Marek Vasut <marex@denx.de> > --- > Cc: "Leonard Göhrs" <l.goehrs@pengutronix.de> > Cc: Ahmad Fatoum <a.fatoum@pengutronix.de> > Cc: Alexandre Torgue <alexandre.torgue@foss.st.com> > Cc: Andre Przywara <andre.przywara@arm.com> > Cc: Conor Dooley <conor+dt@kernel.org> > Cc: Dario Binacchi <dario.binacchi@amarulasolutions.com> > Cc: Krzysztof Kozlowski <krzk+dt@kernel.org> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com> > Cc: Rob Herring <robh@kernel.org> > Cc: Sean Nyekjaer <sean@geanix.com> > Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de> > Cc: devicetree@vger.kernel.org > Cc: kernel@dh-electronics.com > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-stm32@st-md-mailman.stormreply.com > --- > Documentation/devicetree/bindings/arm/stm32/stm32.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml > index bc2f43330ae42..7f61223b8ef24 100644 > --- a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml > +++ b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml > @@ -59,6 +59,12 @@ properties: > - prt,prtt1s # Protonic PRTT1S > - const: st,stm32mp151 > > + - description: DH STM32MP135 DHCOR SoM based Boards > + items: > + - const: dh,stm32mp135f-dhcor-dhsbc > + - const: dh,stm32mp131a-dhcor-som Either this or your dts is wrong. Either way, please test your dts files against the schemas. > + - const: st,stm32mp135 > + > - description: DH STM32MP151 DHCOR SoM based Boards > items: > - const: dh,stm32mp151a-dhcor-testbench > -- > 2.43.0 >
On 4/22/24 5:08 PM, Rob Herring wrote: > On Mon, Apr 22, 2024 at 02:19:15AM +0200, Marek Vasut wrote: >> Add DT compatible string for DH electronics STM32MP13xx DHCOR SoM and >> DHSBC carrier board. This stm32mp135f-dhcor-dhsbc board is a stack of >> DHCOR SoM based on STM32MP135F SoC (900MHz / crypto capabilities) >> populated on DHSBC carrier board. >> >> The SoM contains the following peripherals: >> - STPMIC (power delivery) >> - 512MB DDR3L memory >> - eMMC and SDIO WiFi module >> >> The DHSBC carrier board contains the following peripherals: >> - Two RGMII Ethernet ports >> - USB-A Host port, USB-C peripheral port, USB-C power supply plug >> - Expansion connector >> >> Signed-off-by: Marek Vasut <marex@denx.de> >> --- >> Cc: "Leonard Göhrs" <l.goehrs@pengutronix.de> >> Cc: Ahmad Fatoum <a.fatoum@pengutronix.de> >> Cc: Alexandre Torgue <alexandre.torgue@foss.st.com> >> Cc: Andre Przywara <andre.przywara@arm.com> >> Cc: Conor Dooley <conor+dt@kernel.org> >> Cc: Dario Binacchi <dario.binacchi@amarulasolutions.com> >> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org> >> Cc: Linus Walleij <linus.walleij@linaro.org> >> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com> >> Cc: Rob Herring <robh@kernel.org> >> Cc: Sean Nyekjaer <sean@geanix.com> >> Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de> >> Cc: devicetree@vger.kernel.org >> Cc: kernel@dh-electronics.com >> Cc: linux-arm-kernel@lists.infradead.org >> Cc: linux-stm32@st-md-mailman.stormreply.com >> --- >> Documentation/devicetree/bindings/arm/stm32/stm32.yaml | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml >> index bc2f43330ae42..7f61223b8ef24 100644 >> --- a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml >> +++ b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml >> @@ -59,6 +59,12 @@ properties: >> - prt,prtt1s # Protonic PRTT1S >> - const: st,stm32mp151 >> >> + - description: DH STM32MP135 DHCOR SoM based Boards >> + items: >> + - const: dh,stm32mp135f-dhcor-dhsbc >> + - const: dh,stm32mp131a-dhcor-som > > Either this or your dts is wrong. Either way, please test your dts files > against the schemas. Yes, I know ... last minute change went wrong, sorry.
Hi Marek On 4/22/24 14:52, Marek Vasut wrote: > On 4/22/24 6:21 AM, Krzysztof Kozlowski wrote: >> On 22/04/2024 02:19, Marek Vasut wrote: >>> Add DT compatible string for DH electronics STM32MP13xx DHCOR SoM and >>> DHSBC carrier board. This stm32mp135f-dhcor-dhsbc board is a stack of >>> DHCOR SoM based on STM32MP135F SoC (900MHz / crypto capabilities) >>> populated on DHSBC carrier board. >>> >>> The SoM contains the following peripherals: >>> - STPMIC (power delivery) >>> - 512MB DDR3L memory >>> - eMMC and SDIO WiFi module >>> >>> The DHSBC carrier board contains the following peripherals: >>> - Two RGMII Ethernet ports >>> - USB-A Host port, USB-C peripheral port, USB-C power supply plug >>> - Expansion connector >>> >>> Signed-off-by: Marek Vasut <marex@denx.de> >>> --- >>> Cc: "Leonard Göhrs" <l.goehrs@pengutronix.de> >>> Cc: Ahmad Fatoum <a.fatoum@pengutronix.de> >>> Cc: Alexandre Torgue <alexandre.torgue@foss.st.com> >>> Cc: Andre Przywara <andre.przywara@arm.com> >>> Cc: Conor Dooley <conor+dt@kernel.org> >>> Cc: Dario Binacchi <dario.binacchi@amarulasolutions.com> >>> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org> >>> Cc: Linus Walleij <linus.walleij@linaro.org> >>> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com> >>> Cc: Rob Herring <robh@kernel.org> >>> Cc: Sean Nyekjaer <sean@geanix.com> >>> Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de> >>> Cc: devicetree@vger.kernel.org >>> Cc: kernel@dh-electronics.com >>> Cc: linux-arm-kernel@lists.infradead.org >>> Cc: linux-stm32@st-md-mailman.stormreply.com >>> --- >>> Documentation/devicetree/bindings/arm/stm32/stm32.yaml | 6 ++++++ >>> 1 file changed, 6 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml >>> b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml >>> index bc2f43330ae42..7f61223b8ef24 100644 >>> --- a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml >>> +++ b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml >>> @@ -59,6 +59,12 @@ properties: >>> - prt,prtt1s # Protonic PRTT1S >>> - const: st,stm32mp151 >>> + - description: DH STM32MP135 DHCOR SoM based Boards >>> + items: >>> + - const: dh,stm32mp135f-dhcor-dhsbc >>> + - const: dh,stm32mp131a-dhcor-som >>> + - const: st,stm32mp135 >> >> The entries look ordered by last compatible, so this breaks the order. > > And uh ... I will not do last minute changes before sending out large > series next time, sorry. > > I'll wait for Alex to see if 02..19 better be squashed or separate, and > then fix this up and send V2. Yes I would prefer that you squash pins definition patches. Thanks Alex > > Thanks
diff --git a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml index bc2f43330ae42..7f61223b8ef24 100644 --- a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml +++ b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml @@ -59,6 +59,12 @@ properties: - prt,prtt1s # Protonic PRTT1S - const: st,stm32mp151 + - description: DH STM32MP135 DHCOR SoM based Boards + items: + - const: dh,stm32mp135f-dhcor-dhsbc + - const: dh,stm32mp131a-dhcor-som + - const: st,stm32mp135 + - description: DH STM32MP151 DHCOR SoM based Boards items: - const: dh,stm32mp151a-dhcor-testbench
Add DT compatible string for DH electronics STM32MP13xx DHCOR SoM and DHSBC carrier board. This stm32mp135f-dhcor-dhsbc board is a stack of DHCOR SoM based on STM32MP135F SoC (900MHz / crypto capabilities) populated on DHSBC carrier board. The SoM contains the following peripherals: - STPMIC (power delivery) - 512MB DDR3L memory - eMMC and SDIO WiFi module The DHSBC carrier board contains the following peripherals: - Two RGMII Ethernet ports - USB-A Host port, USB-C peripheral port, USB-C power supply plug - Expansion connector Signed-off-by: Marek Vasut <marex@denx.de> --- Cc: "Leonard Göhrs" <l.goehrs@pengutronix.de> Cc: Ahmad Fatoum <a.fatoum@pengutronix.de> Cc: Alexandre Torgue <alexandre.torgue@foss.st.com> Cc: Andre Przywara <andre.przywara@arm.com> Cc: Conor Dooley <conor+dt@kernel.org> Cc: Dario Binacchi <dario.binacchi@amarulasolutions.com> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org> Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com> Cc: Rob Herring <robh@kernel.org> Cc: Sean Nyekjaer <sean@geanix.com> Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de> Cc: devicetree@vger.kernel.org Cc: kernel@dh-electronics.com Cc: linux-arm-kernel@lists.infradead.org Cc: linux-stm32@st-md-mailman.stormreply.com --- Documentation/devicetree/bindings/arm/stm32/stm32.yaml | 6 ++++++ 1 file changed, 6 insertions(+)