diff mbox series

[v2,17/19] fbdev: imx: Constify lcd_ops

Message ID 20240424-video-backlight-lcd-ops-v2-17-1aaa82b07bc6@kernel.org (mailing list archive)
State New
Headers show
Series backlight: Constify lcd_ops | expand

Commit Message

Krzysztof Kozlowski April 24, 2024, 6:33 a.m. UTC 
'struct lcd_ops' is not modified by core backlight code, so it can be
made const for increased code safety.

Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---

Depends on the first patch in the series.
---
 drivers/video/fbdev/imxfb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Peng Fan April 24, 2024, 7:05 a.m. UTC | #1 
> Subject: [PATCH v2 17/19] fbdev: imx: Constify lcd_ops
> 
> 'struct lcd_ops' is not modified by core backlight code, so it can be made
> const for increased code safety.
> 
> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

Reviewed-by: Peng Fan <peng.fan@nxp.com>
> ---
> 
> Depends on the first patch in the series.
> ---
>  drivers/video/fbdev/imxfb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/video/fbdev/imxfb.c b/drivers/video/fbdev/imxfb.c index
> a4dbc72f93c3..4ebfe9b9df60 100644
> --- a/drivers/video/fbdev/imxfb.c
> +++ b/drivers/video/fbdev/imxfb.c
> @@ -857,7 +857,7 @@ static int imxfb_lcd_set_power(struct lcd_device
> *lcddev, int power)
>  	return 0;
>  }
> 
> -static struct lcd_ops imxfb_lcd_ops = {
> +static const struct lcd_ops imxfb_lcd_ops = {
>  	.check_fb	= imxfb_lcd_check_fb,
>  	.get_contrast	= imxfb_lcd_get_contrast,
>  	.set_contrast	= imxfb_lcd_set_contrast,
> 
> --
> 2.43.0
>
diff mbox series

Patch

diff --git a/drivers/video/fbdev/imxfb.c b/drivers/video/fbdev/imxfb.c
index a4dbc72f93c3..4ebfe9b9df60 100644
--- a/drivers/video/fbdev/imxfb.c
+++ b/drivers/video/fbdev/imxfb.c
@@ -857,7 +857,7 @@  static int imxfb_lcd_set_power(struct lcd_device *lcddev, int power)
 	return 0;
 }
 
-static struct lcd_ops imxfb_lcd_ops = {
+static const struct lcd_ops imxfb_lcd_ops = {
 	.check_fb	= imxfb_lcd_check_fb,
 	.get_contrast	= imxfb_lcd_get_contrast,
 	.set_contrast	= imxfb_lcd_set_contrast,