diff mbox series

arm64: dts: rockchip: Enable GPU on Orange Pi 5

Message ID 20240425222913.1760-1-honyuenkwun@gmail.com (mailing list archive)
State New
Headers show
Series arm64: dts: rockchip: Enable GPU on Orange Pi 5 | expand

Commit Message

Jimmy Hon April 25, 2024, 10:29 p.m. UTC
Enable the Mali GPU in the Orange Pi 5

Signed-off-by: Jimmy Hon <honyuenkwun@gmail.com>
---
 arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Rob Herring (Arm) April 26, 2024, 2:22 p.m. UTC | #1
On Thu, 25 Apr 2024 17:29:13 -0500, Jimmy Hon wrote:
> Enable the Mali GPU in the Orange Pi 5
> 
> Signed-off-by: Jimmy Hon <honyuenkwun@gmail.com>
> ---
>  arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts | 5 +++++
>  1 file changed, 5 insertions(+)
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y rockchip/rk3588s-orangepi-5.dtb' for 20240425222913.1760-1-honyuenkwun@gmail.com:

arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dtb: gpio-func: leds-gpio: {'rockchip,pins': [[0, 2, 0, 223]], 'phandle': [[231]]} is not of type 'array'
	from schema $id: http://devicetree.org/schemas/gpio/gpio-consumer.yaml#
Jimmy Hon April 26, 2024, 10:45 p.m. UTC | #2
Resend as plain-text.

On Fri, Apr 26, 2024 at 9:22 AM Rob Herring <robh@kernel.org> wrote:
>
> New warnings running 'make CHECK_DTBS=y rockchip/rk3588s-orangepi-5.dtb' for 20240425222913.1760-1-honyuenkwun@gmail.com:
>
> arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dtb: gpio-func: leds-gpio: {'rockchip,pins': [[0, 2, 0, 223]], 'phandle': [[231]]} is not of type 'array'
>         from schema $id: http://devicetree.org/schemas/gpio/gpio-consumer.yaml#
>

That doesn't look like a "new" warning.

When I run the check on tag v6.10-rockchip-dts64-1, there is an
existing error for leds-gpio.

  DTC_CHK arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dtb
arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dtb: /gpu@fb000000:
failed to match any schema with compatible: ['rockchip,rk3588-mali',
'arm,mali-valhall-csf']
arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dtb: /gpu@fb000000:
failed to match any schema with compatible: ['rockchip,rk3588-mali',
'arm,mali-valhall-csf']
arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dtb: /phy@fed80000:
failed to match any schema with compatible:
['rockchip,rk3588-usbdp-phy']
/home/jimmy/linux-rk3588/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dtb:
gpio-func: leds-gpio: {'rockchip,pins': [[0, 2, 0, 222]], 'phandle':
[[230]]} is not of type 'array'
from schema $id: http://devicetree.org/schemas/gpio/gpio-consumer.yaml#
/home/jimmy/linux-rk3588/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dtb:
vcc-3v3-sd-s0-regulator: Unevaluated properties are not allowed
('enable-active-low' was unexpected)
from schema $id: http://devicetree.org/schemas/regulator/fixed-regulator.yaml#

Jimmy
Heiko Stuebner May 3, 2024, 11:38 a.m. UTC | #3
On Thu, 25 Apr 2024 17:29:13 -0500, Jimmy Hon wrote:
> Enable the Mali GPU in the Orange Pi 5
> 
> 

Applied, thanks!

[1/1] arm64: dts: rockchip: Enable GPU on Orange Pi 5
      commit: 8beafb228f2be5de03e73178ac1081847d0d411f

Best regards,
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts b/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts
index c61898355f3e..3f059fb33fda 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts
@@ -147,6 +147,11 @@  &gmac1_rgmii_clk
 	status = "okay";
 };
 
+&gpu {
+	mali-supply = <&vdd_gpu_s0>;
+	status = "okay";
+};
+
 &i2c0 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&i2c0m2_xfer>;