From patchwork Fri Apr 26 15:25:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 13645005 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 08A65C04FFE for ; Fri, 26 Apr 2024 15:25:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=jgJYZiTxwQWJbebl5jlwNZbYsPoOx7g01CmqTYArFO8=; b=h8zK523W6bnE40 GYi/wMJLFiQfrSQsT8eT/E5vcsUKh/B7Ud3XLTE7KAGkT8BuUK34TwhuPvPpus8/GamwXsgGUoYIo Qndd2MC/EWtKegRRsFhsxaBYQkq/UJor4ylzuDLmQKc+si+ujeprD5YZ+7G5WDfWNGKhi2LuUVLsa OhmLlPhZ3Y2VKjsLHAHauB43M2BydlD/HrJ+bU/tHI8GZiKWGwf+64L9utwIcQYwGlIadpvUmWmZQ +F1SS6lSd8UuqVZlKVp5A9Zrx4rwP3yPUSDm+wJcm6dWD3GayxUfh2YNMVtvjLewPGx4O996+ExpA Pjfjg6FKztO2gwROFuRA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s0NSB-0000000D1sm-3sPm; Fri, 26 Apr 2024 15:25:35 +0000 Received: from mgamail.intel.com ([198.175.65.16]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s0NS9-0000000D1r9-0BlA for linux-arm-kernel@lists.infradead.org; Fri, 26 Apr 2024 15:25:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1714145133; x=1745681133; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=IL2++mNo2aq1MBXdWEeDx4hUUCVamp5GSDIQcKWJuhY=; b=RNTRe161LOr/5ptq90ev0Wa1eq2n2x14GA3vepkNRaWcP27xvUSFuMkZ WLEU6bBvjUvlB5ME77nE1x1EPotLyayErOmIr+o2u/FSA/4S5NpgDN0MM eB0drR6R3+smdeZvpwgLYHXn9+puuXxaO05i+0C9FyMUJpkfx7ZhcNOpJ xPBXjLgYIH78RDxMDhVFe+RfePBvm/pDsFgHffuSMODtmKQNGTaf0Z5Qh 4V3BL/kZqT6JL6UdDUkv+jC+7ETrYwuszMkCxWjoxUGepzUZYm/Z82a4C buOBNSv2xptf4SmJA+g6MTe2RJZNzM7Ua8Yicne3Gdi9QWULKBDg6Bq0l A==; X-CSE-ConnectionGUID: 2NTUPyr0S7mVCw26xWd4BQ== X-CSE-MsgGUID: gMEtHPuiTjeRc+qqSG8oRQ== X-IronPort-AV: E=McAfee;i="6600,9927,11056"; a="10005890" X-IronPort-AV: E=Sophos;i="6.07,232,1708416000"; d="scan'208";a="10005890" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2024 08:25:32 -0700 X-CSE-ConnectionGUID: 1bBkQqt7QkSddjdFx/K+hg== X-CSE-MsgGUID: AtZdl5jVTUSEYoTRDvhmlw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,232,1708416000"; d="scan'208";a="30084013" Received: from black.fi.intel.com ([10.237.72.28]) by fmviesa004.fm.intel.com with ESMTP; 26 Apr 2024 08:25:30 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 1DFF01CB; Fri, 26 Apr 2024 18:25:28 +0300 (EEST) From: Andy Shevchenko To: Samuel Holland , Andy Shevchenko , linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Pavel Machek , Lee Jones , Chen-Yu Tsai , Jernej Skrabec Subject: [PATCH v1 1/1] leds: sun50i-a100: Use match_string() helper to simplify the code Date: Fri, 26 Apr 2024 18:25:15 +0300 Message-ID: <20240426152515.872917-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1336.g36b5255a03ac MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240426_082533_144525_A630736F X-CRM114-Status: GOOD ( 12.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org match_string() returns the array index of a matching string. Use it instead of the open-coded implementation. Signed-off-by: Andy Shevchenko Reviewed-by: Jernej Skrabec --- drivers/leds/leds-sun50i-a100.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/leds/leds-sun50i-a100.c b/drivers/leds/leds-sun50i-a100.c index 62d21c3a3575..119eff9471f0 100644 --- a/drivers/leds/leds-sun50i-a100.c +++ b/drivers/leds/leds-sun50i-a100.c @@ -252,18 +252,16 @@ static int sun50i_a100_ledc_parse_format(struct device *dev, struct sun50i_a100_ledc *priv) { const char *format = "grb"; - u32 i; + int i; device_property_read_string(dev, "allwinner,pixel-format", &format); - for (i = 0; i < ARRAY_SIZE(sun50i_a100_ledc_formats); i++) { - if (!strcmp(format, sun50i_a100_ledc_formats[i])) { - priv->format = i; - return 0; - } - } + i = match_string(sun50i_a100_ledc_formats, ARRAY_SIZE(sun50i_a100_ledc_formats), format); + if (i < 0) + return dev_err_probe(dev, i, "Bad pixel format '%s'\n", format); - return dev_err_probe(dev, -EINVAL, "Bad pixel format '%s'\n", format); + priv->format = i; + return 0; } static void sun50i_a100_ledc_set_format(struct sun50i_a100_ledc *priv)