| Message ID | 20240426203245.v2.1.Ia0a99d90acb512aa020a6e7a8cca8cc1b71f1759@changeid (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | ARM: st: add new compatible for PWR regulators on STM32MP13 | expand |
On Fri, 26 Apr 2024 20:32:50 +0200, Patrick Delaunay wrote: > Add new compatible "st,stm32mp13-pwr-reg" for STM32MP13 SoC family. > > Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com> > --- > > Changes in v2: > - update for Rob review, only add compatible for STM32MP13 family > > .../devicetree/bindings/regulator/st,stm32mp1-pwr-reg.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: ./Documentation/devicetree/bindings/regulator/st,stm32mp1-pwr-reg.yaml:15:5: [warning] wrong indentation: expected 6 but found 4 (indentation) dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/regulator/st,stm32mp1-pwr-reg.yaml: properties:compatible:oneOf: [{'const': 'st,stm32mp1,pwr-reg'}, {'const': 'st,stm32mp13-pwr-reg'}] should not be valid under {'items': {'propertyNames': {'const': 'const'}, 'required': ['const']}} hint: Use 'enum' rather than 'oneOf' + 'const' entries from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240426203245.v2.1.Ia0a99d90acb512aa020a6e7a8cca8cc1b71f1759@changeid The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 26/04/2024 20:32, Patrick Delaunay wrote: > Add new compatible "st,stm32mp13-pwr-reg" for STM32MP13 SoC family. > > Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com> > --- > > Changes in v2: > - update for Rob review, only add compatible for STM32MP13 family Please start testing your patches BEFORE sending. Best regards, Krzysztof
On 4/29/24 07:11, Krzysztof Kozlowski wrote: > On 26/04/2024 20:32, Patrick Delaunay wrote: >> Add new compatible "st,stm32mp13-pwr-reg" for STM32MP13 SoC family. >> >> Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com> >> --- >> >> Changes in v2: >> - update for Rob review, only add compatible for STM32MP13 family > Please start testing your patches BEFORE sending. Sorry, I don't know why I don't see the issue even if I executed make dt_binding_check SCHEMA_FILES=stm32 I will sent a V3 and I update my way of working to avoid this error => clean the output biding directory before to execute again "dt_binding_check" > > Best regards, > Krzysztof Regards Patrick
On 13/05/2024 11:46, Patrick DELAUNAY wrote: > > On 4/29/24 07:11, Krzysztof Kozlowski wrote: >> On 26/04/2024 20:32, Patrick Delaunay wrote: >>> Add new compatible "st,stm32mp13-pwr-reg" for STM32MP13 SoC family. >>> >>> Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com> >>> --- >>> >>> Changes in v2: >>> - update for Rob review, only add compatible for STM32MP13 family >> Please start testing your patches BEFORE sending. > > > Sorry, > > I don't know why I don't see the issue even if I executed > > make dt_binding_check SCHEMA_FILES=stm32 The code is incorrect, which is easily visible by the diff. dtschema detects it so, your setup is probably not complete, if you claim you run it before sending. writing-schema doc has short guide how to setup, but that's basically only one command - pip install dtschema Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/regulator/st,stm32mp1-pwr-reg.yaml b/Documentation/devicetree/bindings/regulator/st,stm32mp1-pwr-reg.yaml index c9586d277f41..b0c6c62a84ea 100644 --- a/Documentation/devicetree/bindings/regulator/st,stm32mp1-pwr-reg.yaml +++ b/Documentation/devicetree/bindings/regulator/st,stm32mp1-pwr-reg.yaml @@ -11,7 +11,9 @@ maintainers: properties: compatible: - const: st,stm32mp1,pwr-reg + oneOf: + - const: st,stm32mp1,pwr-reg + - const: st,stm32mp13-pwr-reg reg: maxItems: 1
Add new compatible "st,stm32mp13-pwr-reg" for STM32MP13 SoC family. Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com> --- Changes in v2: - update for Rob review, only add compatible for STM32MP13 family .../devicetree/bindings/regulator/st,stm32mp1-pwr-reg.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)