From patchwork Mon Apr 29 15:04:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda X-Patchwork-Id: 13647162 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 70332C4345F for ; Mon, 29 Apr 2024 15:07:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SY4yxp1sLkVlU43t8elKp+3jiiXSJ+OvPTBS+KF3tAQ=; b=wHr7NIHb+5FoPf yJT/LtPuWdYlY6sz+EoKgkHQ4+Z9NyfLqe3j99fV4B+IWTyQLgnxHlUE94VcX5n8qfYnpC1RFjsNN QPDHrUSVXMty+dSt0akAbAmZWX3yZlqLvxXaGKMKhEdYYsBSvVy8ws+jTYM0NDQJwLBwclqj0icS+ SlAjvaWX93lLkqoeQwA8gHd5rB7MXtrmaGPNfwowkgk6KbBcRonG2ejIGRbweiYOD/k4yNPU1K8MB AddF29o99+T5TP5ccD+pcUfAluUaFThLjfxj3uvKzGZtqRVM/+lpsOsHDZFNa7tjM7bE60CCI4E3C P9VsOynN8FAaORBuU2yw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1Sb2-00000003GlR-1uoi; Mon, 29 Apr 2024 15:07:12 +0000 Received: from mail-qk1-x734.google.com ([2607:f8b0:4864:20::734]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1SYk-00000003FJN-2wcU for linux-arm-kernel@lists.infradead.org; Mon, 29 Apr 2024 15:04:52 +0000 Received: by mail-qk1-x734.google.com with SMTP id af79cd13be357-790f91b834cso71791585a.0 for ; Mon, 29 Apr 2024 08:04:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1714403089; x=1715007889; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=AThUs0uZjFFwmlw5yFatMODeeCPF6NJNDOtB7Vvi1Co=; b=gJxGuY5wirGJZPlkNNAgLVYbscbkk2DtPubr4NUmrvaUuDViLMuwS3m+SNEKPKVoOY 5KIb2Ber3/hb2bqYAs7s31or6hW9V+gAqOONXkuUJ5De3ljSioPaaOqOYMK0u9Bnray8 KEaY4AH5+0d1nt0rZfwUQ5cf14LUSXQOlVQzQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714403089; x=1715007889; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AThUs0uZjFFwmlw5yFatMODeeCPF6NJNDOtB7Vvi1Co=; b=Oty7aGCS7ltrGxMskDdvg40dT9SXD37ciY3JI8kTj5fOWARtKASUrFOmJWcroLWh0E B5TjUeSujils8P1KvrHL4nHblkyH8+8TVxAowDuzyzXP9t/sr6ZU24L9UR8HNUWT2UNS HRkbLFpZNhmN50xwnhXuaBOflL5q4aIOefNgGTXmnYIPGEQgsTkKFbkHyZ2W6JeEqG10 qa0wRp3d3XcR5SvKQJr11G19zhcSjP4rjS9TnSGFPLRMfV+5FE2ZqXWpnAPX/IGINrKP l7ILH6ycTnuU6MhXO+q/Iu8ehNBeaKEkFpEgv0NZGqcb0WH7xWw1gbd+9U0n28T+S9lk f+GQ== X-Forwarded-Encrypted: i=1; AJvYcCU8cVEylfQBzBO5eMB55lkgSpLyNjIODIZ6HJ+210TYqBYc9N/l5PGBmN24inOQMnIQEzH4CrY+R2mgsOi3CYO3Ba495claJbxA+ddW0WOwSjI9vhk= X-Gm-Message-State: AOJu0YyIhaFRcHduO1kh8EBKTHy/mG0EPpMNAr2PIUJtFyiPt+Kj5bVi GXvGJRPHEYEm2mOls1jlw2Bl3aGjg8X/rCHHcCyHiPehb4bbMgxl6l1hz8gPjA== X-Google-Smtp-Source: AGHT+IGBuMWlT8BGDJs/bsSnyVE6ctAfT7ka0JR0PlzLBPx7ju98o6D15U4PhJiULbsFLxQvf+DlVA== X-Received: by 2002:a05:620a:4094:b0:790:f4dc:ba36 with SMTP id f20-20020a05620a409400b00790f4dcba36mr4480887qko.33.1714403089247; Mon, 29 Apr 2024 08:04:49 -0700 (PDT) Received: from denia.c.googlers.com (114.152.245.35.bc.googleusercontent.com. [35.245.152.114]) by smtp.gmail.com with ESMTPSA id p7-20020a05620a056700b0078d3b9139edsm10568591qkp.97.2024.04.29.08.04.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Apr 2024 08:04:48 -0700 (PDT) From: Ricardo Ribalda Date: Mon, 29 Apr 2024 15:04:45 +0000 Subject: [PATCH v3 06/26] media: stm32-dcmipp: Remove redundant printk MIME-Version: 1.0 Message-Id: <20240429-fix-cocci-v3-6-3c4865f5a4b0@chromium.org> References: <20240429-fix-cocci-v3-0-3c4865f5a4b0@chromium.org> In-Reply-To: <20240429-fix-cocci-v3-0-3c4865f5a4b0@chromium.org> To: Martin Tuma , Mauro Carvalho Chehab , Laurent Pinchart , Hugues Fruchet , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Paul Kocialkowski , Greg Kroah-Hartman , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Sakari Ailus , Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Luca Ceresoli , Matthias Brugger , AngeloGioacchino Del Regno , Hans Verkuil , Sergey Kozlov , Abylay Ospan , Ezequiel Garcia , Dmitry Osipenko , Benjamin Mugnier , Sylvain Petinot , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240429_080450_935812_EB5BF09A X-CRM114-Status: GOOD ( 14.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org platform_get_irq() already prints an error message. Also platform_get_irq() can never return 0, so lets fix the condition now that we are at it. Found by cocci: drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c:444:3-10: line 444 is redundant because platform_get_irq() already prints an error Signed-off-by: Ricardo Ribalda --- drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c b/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c index bce821eb71ce..4acc3b90d03a 100644 --- a/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c +++ b/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c @@ -439,11 +439,8 @@ static int dcmipp_probe(struct platform_device *pdev) "Could not get reset control\n"); irq = platform_get_irq(pdev, 0); - if (irq <= 0) { - if (irq != -EPROBE_DEFER) - dev_err(&pdev->dev, "Could not get irq\n"); - return irq ? irq : -ENXIO; - } + if (irq < 0) + return irq; dcmipp->regs = devm_platform_get_and_ioremap_resource(pdev, 0, NULL); if (IS_ERR(dcmipp->regs)) {