From patchwork Tue Apr 30 12:55:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ricardo Ribalda X-Patchwork-Id: 13648985 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5AEF9C4345F for ; Tue, 30 Apr 2024 12:56:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xHEb5p+NZghBvIsAX1NycOOXOn81HMzP9UoMCW4iamY=; b=wpjickv85LGjN9 JZ12IdGKWgArRd2GDxyslbPhz89I0+ZxFhzqtCVg8qi9OmzEjyfJemNT5Lp4z++fnut5uFsXpJMhf cqvqhLfExJvgKyK94wBtvR9G2xxuwG3C+9irk4fmQ/Apn3oJvov/b/R//gqLXp/qhRvHLvGjJsLL1 r6EISllIxHB8eKEw1NH59qINgy6hVVqJDjjkdchZZ2SBLC+uxuR6iMgealom7OJ8hjWd2YxEw602j eP4sDS0jM93oeDSpIyWM01webAH11ON3cb80BqmLRog9DN47WOQ5Zb4RSVJLCzJOMNRP07n/4KzgK b66B035tbc38yHjvF2CQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1n1j-00000006P5F-0lNb; Tue, 30 Apr 2024 12:56:07 +0000 Received: from mail-qk1-x72e.google.com ([2607:f8b0:4864:20::72e]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1n1S-00000006Ovc-3RPf for linux-arm-kernel@lists.infradead.org; Tue, 30 Apr 2024 12:55:52 +0000 Received: by mail-qk1-x72e.google.com with SMTP id af79cd13be357-79100a90868so119645285a.2 for ; Tue, 30 Apr 2024 05:55:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1714481748; x=1715086548; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=/vGWU+yuHMlxGeQ2v0UxRXrwFtugXz7htO5Olbld0OY=; b=XZOFYVFdENS8NgPsxiEutGL5QKMoPgo/8HLV7k52w+4677UrAys2mpyF8KBcUwKxVR l9vyxI9OMcPf0RrdZMg0KYQ9fXhzBQM8cVimeA9kV1ZpiDHciLedOv8AQrSe3gBa5Bw8 +N58z3tzNZ28mi8mGxtclwLsFYmg4pxGIgZu8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714481748; x=1715086548; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/vGWU+yuHMlxGeQ2v0UxRXrwFtugXz7htO5Olbld0OY=; b=I6qJpSG9XFim725ZxbOFHoS0cm+FCoaJumcLTSzJKCIsNpGGpPNRNypw6NHNefpoED Of/GdJEmUyhr5S7BfxJ/jHGthFxSTcrQALEpeoBZG6ecJCTHASOdzFK4JqWyUQa22QKQ r8GB3sLyjJdNKJwWLRh2jijC035jnoX7S4C+1Z5ej4F1q+Iax37CVbwURjdB4O0IMUig pU2xfQZm39xJvDbOiCI94dtSXnUIh0VBkS3KZVRLa2t2YcTSbd395HYBaz9ZpcBev2ja 4c7mC19Z+mIeSqUXYdl2yeFBp/CPGgQppmAJ3H4yncwokcAl1VG9SqCX0tdqbOuCOduQ hUeg== X-Forwarded-Encrypted: i=1; AJvYcCUdE/q3IWHfyQjIJqE2IvwbdYqPNsx+GWYKOi9Hqymb1ouFsSAfMQ9ktzfM4NwQ9rB29VoAQ64tgMXUMMkGhctx9UCZNDtZymeqvs8yno+1qmmHgwE= X-Gm-Message-State: AOJu0YzKUpH9qJ2Wx3CB8KNe6Fj+U8Km7Bk8+Ezl7CPpKYuSdsBXD20z ROzqp5agjv11Y9xEgaO6hlF6Fa0Oyvy3OMapz+Wc/9EN0IqQ0SLKFl3plAO9kg== X-Google-Smtp-Source: AGHT+IHmc9EduiMj1OpTnvSkXwddOA0ZCHmY0W5Zlq6AnSEMhPm3qZQyuicCrl7kaS0cmeF1jbBCsg== X-Received: by 2002:a05:620a:57d7:b0:78d:68fa:6e41 with SMTP id wl23-20020a05620a57d700b0078d68fa6e41mr15004216qkn.64.1714481748273; Tue, 30 Apr 2024 05:55:48 -0700 (PDT) Received: from denia.c.googlers.com (114.152.245.35.bc.googleusercontent.com. [35.245.152.114]) by smtp.gmail.com with ESMTPSA id o16-20020a05620a111000b00790f90ffc32sm1553667qkk.22.2024.04.30.05.55.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Apr 2024 05:55:47 -0700 (PDT) From: Ricardo Ribalda Date: Tue, 30 Apr 2024 12:55:34 +0000 Subject: [PATCH 2/4] media: intel/ipu6: Switch to RUNTIME_PM_OPS() and SYSTEM_SLEEP_PM_OPS MIME-Version: 1.0 Message-Id: <20240430-fix-ipu6-v1-2-9b31fbbce6e4@chromium.org> References: <20240430-fix-ipu6-v1-0-9b31fbbce6e4@chromium.org> In-Reply-To: <20240430-fix-ipu6-v1-0-9b31fbbce6e4@chromium.org> To: Mauro Carvalho Chehab , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Sakari Ailus , Bingbu Cao , Tianshu Qiu Cc: linux-media@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Hans Verkuil , Ricardo Ribalda X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240430_055550_913916_1BAE3086 X-CRM114-Status: GOOD ( 13.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Replace the old helpers with its modern alternative. Now we do not need to set '__maybe_unused' annotations when we are not enabling the PM configurations. Fixes: drivers/media/pci/intel/ipu6/ipu6.c:841:12: warning: ‘ipu6_runtime_resume’ defined but not used [-Wunused-function] drivers/media/pci/intel/ipu6/ipu6.c:806:12: warning: ‘ipu6_resume’ defined but not used [-Wunused-function] drivers/media/pci/intel/ipu6/ipu6.c:801:12: warning: ‘ipu6_suspend’ defined but not used [-Wunused-function] Signed-off-by: Ricardo Ribalda --- drivers/media/pci/intel/ipu6/ipu6.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/pci/intel/ipu6/ipu6.c b/drivers/media/pci/intel/ipu6/ipu6.c index 4b1f69d14d71..ff5ca0c52781 100644 --- a/drivers/media/pci/intel/ipu6/ipu6.c +++ b/drivers/media/pci/intel/ipu6/ipu6.c @@ -803,7 +803,7 @@ static int ipu6_suspend(struct device *dev) return 0; } -static int ipu6_resume(struct device *dev) +static int __maybe_unused ipu6_resume(struct device *dev) { struct pci_dev *pdev = to_pci_dev(dev); struct ipu6_device *isp = pci_get_drvdata(pdev); @@ -860,8 +860,8 @@ static int ipu6_runtime_resume(struct device *dev) } static const struct dev_pm_ops ipu6_pm_ops = { - SET_SYSTEM_SLEEP_PM_OPS(&ipu6_suspend, &ipu6_resume) - SET_RUNTIME_PM_OPS(&ipu6_suspend, &ipu6_runtime_resume, NULL) + SYSTEM_SLEEP_PM_OPS(&ipu6_suspend, &ipu6_resume) + RUNTIME_PM_OPS(&ipu6_suspend, &ipu6_runtime_resume, NULL) }; MODULE_DEVICE_TABLE(pci, ipu6_pci_tbl);