From patchwork Thu May 2 13:46:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Panis X-Patchwork-Id: 13651729 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 49B1AC4345F for ; Thu, 2 May 2024 13:46:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Message-Id:MIME-Version:Subject: Date:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=2ZqLJHV2LvS/vPy9BIX8rnv1fd1BC+AeTsVynlJMzX0=; b=i93B3GNkp5A59q LvquJ119OwvpoKiDKdEfCpRpE18wufzXaJ0LPiU6QJkkUpGah71lgGD0sf0XtNIcEbKqEBKSEyRGw ZboCX6XVjZfkpSkU3MFp1oDgeXgU7iReNnJUbgGwAwJIAQRlynB4y9QQ3g5ji6jCoz+on0UtbHVUC V5MS6ntDN5dc6quQdL2v6KsDkRrrX0XT9/F21zKujV19GTZVOmHH8zqJKmWIYIJtC0Q9fhEdQBJeI jsvx+JDksaOdq2/y7a2slTZVDqwE9cTUUTcPWOVYgxsfO6/OUigWeXqzHy+zgEWdOvsLDMUJxDk9L 1NGY/T4a7KhbUDCmG/uA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s2WlO-0000000Cpqr-3dyM; Thu, 02 May 2024 13:46:18 +0000 Received: from mail-lf1-x12f.google.com ([2a00:1450:4864:20::12f]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s2WlL-0000000Cpo5-3tBG for linux-arm-kernel@lists.infradead.org; Thu, 02 May 2024 13:46:17 +0000 Received: by mail-lf1-x12f.google.com with SMTP id 2adb3069b0e04-51f25f87e58so822182e87.2 for ; Thu, 02 May 2024 06:46:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1714657571; x=1715262371; darn=lists.infradead.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=KjbvBW6RdAEPTXQDkB746T8DtbLmBQp7aI+NR/HIMtA=; b=b/K/o/u7lJAdMxTrKL8qkyqYyA2chWD79QQwf9hXncZaWUCbmgepQ6VVTgCHnflXm+ GdKVh7k89Ki8nqev867LqBvE+apAwyBZHyVYl7HWCSK31+WjBuRBEMrzeFebRB1h5t9L vkmNgtZnIFZ7uWrwBHAc8xKD6jZ1S67e2CPUy7WDQkKrEuy5ymxJU8eNdzCsno5nFy/m F0JhvIaOTZ1KbHOGtwJz7/nR2MBxp7WcfPPa4uOagxkvRVckp67D50lNypbEgaV185Sn w+fJanXP2DiyRaxQ6XtjYcG/6f5/j7mGT289FUYmIfkj4ZDtojU9CTWyLRi4g+OtI3Dk WGaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714657571; x=1715262371; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KjbvBW6RdAEPTXQDkB746T8DtbLmBQp7aI+NR/HIMtA=; b=v24CSsxnz0M83qYxhJAu6DxOvjADWlXEgliApyeTNPiBB6H6RfB6hrUl1SuJDsPQGu Q/OsC4SvFXvaT0HUMVEGsWYUl37QhX7gScQofLqqddXqW6edDt5qak0wCw1cQHrFYLg6 /NY2oTpj6jySpD72/PQ8qr1GNF4oTPc+Xm4j7H+qHjzBVkgW2+3cXFAYY27/3zG55nsP duwZH63numz3d3cImsWLohrG+7qtIC8C4owkg3LxdK6aI+vki2PKfU6R4/fYvfn0aw2k 6QSgBjpT/yozv508uZNPTeRtSsb01au48D2Ha67qPaeYyUhl7pjIpu3YoKKrvNHjZJZ7 IE8Q== X-Forwarded-Encrypted: i=1; AJvYcCXS23/I6S+AtWvTKhgpYTNsOCgnZbGk3SqJU1JTjDLf1s6fqf9oYK0G/0MGRWziQubPWmAdeOaRiNkT1y8/S3Z0LUmysuA0DdqYVKReJSo2CRSfevI= X-Gm-Message-State: AOJu0Yx1GTguvq2PsnwoDaiHhCB65j1lW1YsxR3+10PsIHd6cdoUDFXi HCTJWDlO75lelM2nrSsoKX0GSOqzW74XlXKFw6tIsIpzJt+v3puEDErG/zdMkteZ/Q/lfsCvH/t 2 X-Google-Smtp-Source: AGHT+IFep4NL01L9Ttyd1vLDcDsr7A1IdG5IgCdv67mtSJhnn0nKGdEu7Tq10aLQKCI1NwgsUJdJ7w== X-Received: by 2002:a05:6512:3083:b0:51a:a400:785e with SMTP id z3-20020a056512308300b0051aa400785emr5147210lfd.43.1714657571559; Thu, 02 May 2024 06:46:11 -0700 (PDT) Received: from [127.0.1.1] ([79.87.205.120]) by smtp.gmail.com with ESMTPSA id c1-20020a05600c0a4100b0041bf3a716b9sm2014447wmq.34.2024.05.02.06.46.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 May 2024 06:46:10 -0700 (PDT) From: Julien Panis Date: Thu, 02 May 2024 15:46:03 +0200 Subject: [PATCH] thermal/drivers/mediatek/lvts_thermal: Check NULL ptr on lvts_data MIME-Version: 1.0 Message-Id: <20240502-mtk-thermal-lvts-data-v1-1-65f1b0bfad37@baylibre.com> X-B4-Tracking: v=1; b=H4sIABqZM2YC/zWNwQrCMBBEf6Xs2YU0RFF/RTxsmtUE2yi7SymU/ rup4PEx82ZWUJbCCtduBeG5aHnXBv2hgyFTfTKW1Bi888EdncfJXmiZZaIRx9kUExlhiP0ludO 5NQI0N5IyRqE65N2uvBj+J/b8I/woy+/3dt+2L7gkdLaHAAAA To: "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Matthias Brugger , AngeloGioacchino Del Regno , Nicolas Pitre Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Julien Panis X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1714657570; l=935; i=jpanis@baylibre.com; s=20230526; h=from:subject:message-id; bh=umAKYkGw6Qh2FAI5WcUUghAsI5djPBhIsfyxFgp451E=; b=XsliQEKG1eu9+im+fcPyY5Bbcd0sVJkvx/RcjpKU1v7XxCLRK2GVF3ir4d6kad7e4Geja8X1n U9XUTA8WUMvBsVCV6f7yMC4aFi2H/666pKzVpdEoUoeX/0+JSCS+uxO X-Developer-Key: i=jpanis@baylibre.com; a=ed25519; pk=8eSM4/xkiHWz2M1Cw1U3m2/YfPbsUdEJPCWY3Mh9ekQ= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240502_064616_018977_1121366E X-CRM114-Status: GOOD ( 10.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Verify that lvts_data is not NULL before using it. Signed-off-by: Julien Panis --- At probe, verify that lvts_data is not NULL before using it. --- drivers/thermal/mediatek/lvts_thermal.c | 2 ++ 1 file changed, 2 insertions(+) --- base-commit: 9c6ecb3cb6e20c4fd7997047213ba0efcf9ada1a change-id: 20240502-mtk-thermal-lvts-data-4b19d0685024 Best regards, diff --git a/drivers/thermal/mediatek/lvts_thermal.c b/drivers/thermal/mediatek/lvts_thermal.c index 86b2f44355ac..20a64b68f9c0 100644 --- a/drivers/thermal/mediatek/lvts_thermal.c +++ b/drivers/thermal/mediatek/lvts_thermal.c @@ -1271,6 +1271,8 @@ static int lvts_probe(struct platform_device *pdev) return -ENOMEM; lvts_data = of_device_get_match_data(dev); + if (!lvts_data) + return -ENODEV; lvts_td->clk = devm_clk_get_enabled(dev, NULL); if (IS_ERR(lvts_td->clk))