From patchwork Sat May 4 00:49:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13653736 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F2296C4345F for ; Sat, 4 May 2024 00:43:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To:In-Reply-To: References:Message-Id:Subject:Date:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=t63m+l29rQAPWVVVzmyjSBrPa1auOjVheyVSyYoKnd4=; b=VcehC/jmBjSaEwSS9Xr+VdqQ4I iCZE5al74hsDmENT+A109V3XBM1l1mrz5wRw8ku5Ek4oNXfI7or4iIYQ7vXH8b+9i0QrgHTj9J2Xq o6/C5z5I+xD7qLGjvMBSkliUap2AeOXErjvsBmBAPGqJwEJOUwmiCluvfO3/7QnHk/ej51aPXlRbq EJ9z2FwprHJdK2bkmHzL+oksvdoC2oAqqvIExsEbuWhychIh8+XEbIsLkJaB7y2FUH4hSpdoSoun2 fPdhUDv3lOw+4tdXOiWmula9993AwmbvmZM1hpgRP53QfmHG6EgdJ/ZeIifWPoEyYG/mgB84Mb/d7 ShnxLwog==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s33UZ-00000000u0C-2zSs; Sat, 04 May 2024 00:43:08 +0000 Received: from mail-vi1eur02on20600.outbound.protection.outlook.com ([2a01:111:f403:2607::600] helo=EUR02-VI1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s33UO-00000000tjx-1r2c for linux-arm-kernel@lists.infradead.org; Sat, 04 May 2024 00:43:03 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gSsE43sf3Ip9guXN/I1G55EQhEDluFM22uri3q4bY/6F3rDvPtvuZZoK/bROkbfaTbgvhMVWmaIFZZ1ttVcW1KaubrxMIKuZvu9F89mwuaIrrZQeZZovkTvp1rZZ66+i3/LflB5cHA6N7/Zi4qZWGa8gPbdLqtx5m2fOiGkCI+sab5RbdMsWubwbAVIKokm66rcGxx6OxT/05OOyAZklTkAtsN5jcdD4BtXd+ShIj77vIJWvM21NJbYLTdmisueAlDsxO791J1CigWVmJji6Sj0BEFq4owKkVBCMx2dISZ0AeKUCDFfR9QOYlDGoKT+tOluzmNM0uGceBGpTmpLLQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=morjSPZoht/sZgZZlrJFTpm7VksD0m/Vy6jf//XeATM=; b=lVvooT4F0LoiW9cTIfYUSmp2EkoA3fGDLJxj2gJ/xTVlG7T44/+Ggwp27LvPkioVseoTTOqBa9B+ucgurjPJzhVO1j5BLqx9rH5nXcvGWQ2fYlO2mk+guM6ahOvGSJCj/FPR9EMnR5vASVePGrhRGUNWRw5UdaPFJJZOszL+epqxUIiiJOTeRddlRMBZAtI3uscGD5JCFyqg0DkaBWxV6GaXD5xeyhd3Gq7ifr3/Bucl2mHZl55AkPfRqgRwuQ91gCrF5kGqc4BGfvKK93Na+7JMoer/A2jkuotSm9cyEDD7DLAomgH5hHaUPiDQpygOeP253j2QH6SUOktjgbkVng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=morjSPZoht/sZgZZlrJFTpm7VksD0m/Vy6jf//XeATM=; b=UHDFD4IYz31jMk1YtV1KaikCFXSpv8QtpjotNhe0a7OMRRSNMIma71W5l2yFWkKO0e/LKszRX/9LWxDODd3X0FawzdbpH1Tm6J936pL3kR8vJK8cBkjwjujsE74klPkaVoqTSnx2+M4wv+cruzon+kite5q6rasu9WK8T4WemFQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by PA4PR04MB7726.eurprd04.prod.outlook.com (2603:10a6:102:ea::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.29; Sat, 4 May 2024 00:42:35 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d%4]) with mapi id 15.20.7544.029; Sat, 4 May 2024 00:42:35 +0000 From: "Peng Fan (OSS)" Date: Sat, 04 May 2024 08:49:10 +0800 Subject: [PATCH 17/18] clk: imx: imx8qxp: Parent should be initialized earlier than the clock Message-Id: <20240504-imx-clk-v1-17-f7915489d58d@nxp.com> References: <20240504-imx-clk-v1-0-f7915489d58d@nxp.com> In-Reply-To: <20240504-imx-clk-v1-0-f7915489d58d@nxp.com> To: Abel Vesa , Michael Turquette , Stephen Boyd , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Jacky Bai , Ye Li , Dong Aisheng Cc: linux-clk@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Abel Vesa , Peng Fan X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1714783747; l=2435; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=hrw2P3sZckBHVBC6N5CEm5mGrpqUDVpTtcM6jOZ4s+Q=; b=kMNh8mRqhB2ZDTaJfXa8sIEqusAxeIdV1ctqQPQJT619wLq1V1wOyRkq7JmU8v0JMclWoOtqu 5CJIiqYI6P6DMjk1UvpSbkZbv433QFF+vi0FycR61sqi+S9C5XzB2F2 X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI1PR02CA0055.apcprd02.prod.outlook.com (2603:1096:4:1f5::16) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|PA4PR04MB7726:EE_ X-MS-Office365-Filtering-Correlation-Id: c7bece1c-ef20-4b36-406a-08dc6bd31782 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|7416005|52116005|366007|1800799015|376005|921011|38350700005; X-Microsoft-Antispam-Message-Info: =?utf-8?q?17yl/1FuUYGzaqYfevleyfbYTkelQBH?= =?utf-8?q?jMyodlD6zG578bkVUNp82upwi/79ZelYjT3818pv2wJC4Dhlvg19L0hLwjZ8yjJQM?= =?utf-8?q?rB+4VFeNG2pr8ZO/C3dBbquAR8vEZGxXJ0HBOYW8vMCMCe2HmAZzpaQGQGL91Hw4e?= =?utf-8?q?PoyLTKcvord7+Nz1j3i6xM3bO79hz4pAwq9psmPj2KVGJJC0if5M6uxLhp9mH9eTl?= =?utf-8?q?zk6r1E1gEhzFvrt6vccL1sbKWLWyD4GU1ydE1ApWJHXrZbfM0EVucjpO/5xSPskYa?= =?utf-8?q?9/7G/WrSN9yCEsY4K2mVAD+puNVSDKRdKpn4bdLEnQTAjn9D3KBVCJ4RinZazjEJo?= =?utf-8?q?XOs42sQsBGc5cVad//327g8rPDzjSPTWrIrGpjDjHs2HNysHdQ2PCJJ95uqnq5U4d?= =?utf-8?q?aciwZa788fkcaWcK3LE/wNrAkKbAH59Vp2HdIQwoI0FkvHY8Yzu9x+EYT8TcgsG4b?= =?utf-8?q?4kyCX0z3HtmNPjK6RM7tvuhzIUT8GZvQu/MHNdb70y1SIkd+hZ/Jr8F2cNa2Yyo6V?= =?utf-8?q?EfRAS7HcI4l88D6RpDaV/71K9Xllk4uq3QqW61A70pdjkQkgjSscvEBBF8IIVxFWu?= =?utf-8?q?ALNS78dK25ag96pIJHQWmn0aDl4UFnwKJZ5GZdSMMdw3PDMOlhQzgcJXIvZb3rprr?= =?utf-8?q?RauMzB3YmCSQFrWb5/hWg7nbLQWXCv+sDvX+KsmVDgIBALchbBvLkttl8aXdwYfvv?= =?utf-8?q?V1rvxhqNWihHiYnG/8aei/w74Ci1bg9SEc1Dl/pfJLE9RqXvYjP1riP60eYVPH0jF?= =?utf-8?q?YztD+Gpyny85DDgkX2/kSc222YRVBwgpAl86mQT7tAvqFqEghvQTmZ/x+SM3um7ya?= =?utf-8?q?P//raStVWgZxuzrNHjnBQKNlvaEvmDHP2k3olkbq6xLzY4X5lJa98HIhXZlbX4Uno?= =?utf-8?q?KJQDkMGG33AX3ZdepxHrOjxUFKjuoBStaGQKlzq6LJWyQdledpBjt2QJWOvLIr1wO?= =?utf-8?q?yIveA1qHC9fmoCIVPHEkgptNdustprR8GdMKV/tEX94WLsb1GtNCrU05zMFjd1laZ?= =?utf-8?q?YxffbyZps7gD7/wkzGgdpIJoq5dGhOfs4wKDoUcdv7MpFrpvB7TJ5uBQv+kwVWJa5?= =?utf-8?q?4ULTKqqo/jz8niyAYHfUoemGXRpxsfyn5K3ECM6jp5NnjeLuEpCGpJcKdO8XuhvVT?= =?utf-8?q?vKBQ9r1eGy9xxLGeDDxIDgWuYSalWodOz434LcMRZ0a3n5f87zeUkvYUU24PuM54T?= =?utf-8?q?1+aY3uAmfgfGfKc9oPfCt1N4Evh7GSU8nzSuBMo2MpbmNtW4vp0QZD+3QryFmi9/b?= =?utf-8?q?XrN3onAkwHD7uJvAAIlIZ3fwldUih7p0X8tmJZaRGGhJfAkvlf7Ovpi4=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(7416005)(52116005)(366007)(1800799015)(376005)(921011)(38350700005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?UNiVcjMtY15NFyp6yu5zE3mmJyG5?= =?utf-8?q?UPsGqlw98mGWEhk8TtuhKBPOuUlKfRijD7AqMDPHh9BzY5PfBZ674f1LMjXv4w6TT?= =?utf-8?q?FaR2uSktAq/8gMe32KsLEd+aIhnuxtXKiaPdNKX3w7KFb9T7G0TqJWWREk3wQa1o1?= =?utf-8?q?7tnsgj4K09/ztJ0kJZJMRTBemc0VLZMxm3BxllQLi4GtPzeFTadVzenKHsXOXWbVA?= =?utf-8?q?gILfVkn+/heCg6WHq1m+8R9WPfaCUDHfaRRLzb2hW7J4aLAKH4uz+TNe0YpNUeKZl?= =?utf-8?q?DdySQ3mxiXQLvRnZMCc0+2cxgg+KGpo8NqbOWHTvBLwwmg0CtIV5S9KKWuB8oR5od?= =?utf-8?q?xiVkXAV78iixcNqc2o0dcMztsdO6G/wEGpQNP4UoFHcGiEk1YupkNFuMdHFB2VGB3?= =?utf-8?q?tHUthbQAcch7EpVus/+7SmlF1V4T59FATJ33188aF7GE29/S5fBUdcZul4i6sqADe?= =?utf-8?q?naIymioXbZBdqP34W0NfALZ/aCUSsRSEsoIdnOpgzIlVrKYV4xuzCwGhtDm9A3/gr?= =?utf-8?q?3Lz+LEJUjWfWSFGeNJVxIGqUszcwmVwLP//igPVxdnVhhk5q2DmWw/58ewL+gO6pw?= =?utf-8?q?LIC/QaddEjOy3dhzscymmhdtctA9UcGWL9HwiD/eKeMaiNk3Pw+4RI/wDLJGKlhRw?= =?utf-8?q?KExD0wKuSeTNrPV+1dK/QJSxSH16PoAFKpo+zGWzNYewg0BabLEf8xYg+mSZD35mX?= =?utf-8?q?dT3jzF8dmamCuUW+WkCTwcqVKYels2ELehyiOjPa71NYF8CVNLvA/SD6Gm/Kzu9Pt?= =?utf-8?q?IhYreOpqD5u+8X8svITjw3wf/5MznE39ZMcN5tyNYFhb1ZfMPi6ZCOAtZn+5zLVuh?= =?utf-8?q?KHg0dfaA7NzMpICiAJTC+7Ml5kApJkN5pHXCdoK+SNKXLbnEN6BF5+SSd9bPPv7QD?= =?utf-8?q?S4U86eGOHZpQoRdoxo3vsMwPyplhsVbMhS+7EI5KGl1X5oRiLm1YmAqPVSSnEpwNr?= =?utf-8?q?pQGuosDBFBT+WFm1PlX5j2iZ8Ct/K4tn1EpKVL4dcQ3HK2WP8I4cbhYL7vA9qka6t?= =?utf-8?q?iH0SdxYPASnwraNtzYyyq99AyWRaEi7S6uvuzKfOH2pgCtNS3QhybENEoPFRr2RqP?= =?utf-8?q?IwKpzs9L9Ito772ie7kXpFzvJE/Xr+Qc6sAwlAUyM2LBOjck2UsYYm4WNoY4aWNRd?= =?utf-8?q?ZP1FgBXQwR2BAEqvp1lzoDVil6KfjXVlEBvOzDPUElaopBEfOCyfVh9/X9UWIZl2q?= =?utf-8?q?nBlXu2GwOHdt6SU0G02M7GuGWV9itc09Y69Hq5KOfpUZ7G5fuX2oBx646XO4Gn4Os?= =?utf-8?q?PKSshamxv+drN/9nKRRWGC0EeUGX+yKnW4BQjDS9yFAb/SI7JA7ElThjGAWPFpYFA?= =?utf-8?q?tGJ8x97OECFPHwx4VV/Mby+Qe+zvisPtBp8sgw6e0Jlw5dBd+ES7VdGjD/O+2QtwA?= =?utf-8?q?4i4ZQblO1ZY0vXh3jT9BKEZh/8qLpE5jh+olJrx27W3Abwf04hBI6rjt+sJ/SVgSr?= =?utf-8?q?gT4uvRwldIiZKLYHLl4D8LIVKRvGXOlQELPb9pB/snlLq1qpY4YQun4oVIoqp5fO6?= =?utf-8?q?MRpJCx5Q6C2V?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: c7bece1c-ef20-4b36-406a-08dc6bd31782 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2024 00:42:35.7214 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hvDZXT+pEobDOUD8GHKuZhTP30Ad7uHwX17EWzs4ePJZMaLKn3kFHhaqSXMCA0203P1M8DQK/mbu9SBubRmSJA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7726 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240503_174256_668822_4F5927E3 X-CRM114-Status: GOOD ( 10.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Peng Fan The initialization order of SCU clocks affects the sequence of SCU clock resume. If there are no other effects, the earlier the initialization, the earlier the resume. During SCU clock resume, the clock rate is restored. As SCFW guidelines, configure the parent clock rate before configuring the child rate. Fixes: babfaa9556d7 ("clk: imx: scu: add more scu clocks") Signed-off-by: Peng Fan --- drivers/clk/imx/clk-imx8qxp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/clk/imx/clk-imx8qxp.c b/drivers/clk/imx/clk-imx8qxp.c index 47f4ceab1179..3ae162625bb1 100644 --- a/drivers/clk/imx/clk-imx8qxp.c +++ b/drivers/clk/imx/clk-imx8qxp.c @@ -186,8 +186,8 @@ static int imx8qxp_clk_probe(struct platform_device *pdev) imx_clk_scu("pwm_clk", IMX_SC_R_LCD_0_PWM_0, IMX_SC_PM_CLK_PER); imx_clk_scu("elcdif_pll", IMX_SC_R_ELCDIF_PLL, IMX_SC_PM_CLK_PLL); imx_clk_scu2("lcd_clk", lcd_sels, ARRAY_SIZE(lcd_sels), IMX_SC_R_LCD_0, IMX_SC_PM_CLK_PER); - imx_clk_scu2("lcd_pxl_clk", lcd_pxl_sels, ARRAY_SIZE(lcd_pxl_sels), IMX_SC_R_LCD_0, IMX_SC_PM_CLK_MISC0); imx_clk_scu("lcd_pxl_bypass_div_clk", IMX_SC_R_LCD_0, IMX_SC_PM_CLK_BYPASS); + imx_clk_scu2("lcd_pxl_clk", lcd_pxl_sels, ARRAY_SIZE(lcd_pxl_sels), IMX_SC_R_LCD_0, IMX_SC_PM_CLK_MISC0); /* Audio SS */ imx_clk_scu("audio_pll0_clk", IMX_SC_R_AUDIO_PLL_0, IMX_SC_PM_CLK_PLL); @@ -229,11 +229,11 @@ static int imx8qxp_clk_probe(struct platform_device *pdev) imx_clk_scu2("dc0_disp1_clk", dc0_sels, ARRAY_SIZE(dc0_sels), IMX_SC_R_DC_0, IMX_SC_PM_CLK_MISC1); imx_clk_scu("dc0_bypass1_clk", IMX_SC_R_DC_0_VIDEO1, IMX_SC_PM_CLK_BYPASS); - imx_clk_scu2("dc1_disp0_clk", dc1_sels, ARRAY_SIZE(dc1_sels), IMX_SC_R_DC_1, IMX_SC_PM_CLK_MISC0); - imx_clk_scu2("dc1_disp1_clk", dc1_sels, ARRAY_SIZE(dc1_sels), IMX_SC_R_DC_1, IMX_SC_PM_CLK_MISC1); imx_clk_scu("dc1_pll0_clk", IMX_SC_R_DC_1_PLL_0, IMX_SC_PM_CLK_PLL); imx_clk_scu("dc1_pll1_clk", IMX_SC_R_DC_1_PLL_1, IMX_SC_PM_CLK_PLL); imx_clk_scu("dc1_bypass0_clk", IMX_SC_R_DC_1_VIDEO0, IMX_SC_PM_CLK_BYPASS); + imx_clk_scu2("dc1_disp0_clk", dc1_sels, ARRAY_SIZE(dc1_sels), IMX_SC_R_DC_1, IMX_SC_PM_CLK_MISC0); + imx_clk_scu2("dc1_disp1_clk", dc1_sels, ARRAY_SIZE(dc1_sels), IMX_SC_R_DC_1, IMX_SC_PM_CLK_MISC1); imx_clk_scu("dc1_bypass1_clk", IMX_SC_R_DC_1_VIDEO1, IMX_SC_PM_CLK_BYPASS); /* MIPI-LVDS SS */