From patchwork Tue May 7 13:18:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda X-Patchwork-Id: 13657050 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F07E7C10F1A for ; Tue, 7 May 2024 13:23:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QaO2bNnF968t7JXaftnAFuEpo1t26tO8D7IcFSYv0GE=; b=Ngdp43VgoVFoDS Jrxlc+v44fpkhiUjgsAEFLgYGDZvXVH0ItiO3GBG8UbYrlfe64/R3CFANz3IyEs60ooN01CLmjKof btSpe6Udtx0KSqRGppKm+t+A7CmxcL85XDGA6a66b5YfkP+FiacMMDTI3yKJewAiA3y3PKYayKdfp YtcAo8OTABYvjkPy0AEf15rM+rkyfNRK98bzZMPUnqaDgfThUNHCiwQ+LDshZhiTrIfjCkhWPY4Yg uA5IL8tv6/vBpzF4ShWQMAho57Z0rVVifBDDUc2Ps6LGRgUmDUX2/m4YXfuD3pi5raR5D4q83tK3m cSLcBsRoIASVpU/xPJ5A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4Kmm-0000000BD27-2DdO; Tue, 07 May 2024 13:23:12 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4Kio-0000000BADr-2JBM for linux-arm-kernel@bombadil.infradead.org; Tue, 07 May 2024 13:19:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Cc:To:In-Reply-To:References:Message-Id :Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From:Sender :Reply-To:Content-ID:Content-Description; bh=JKfhOSoHE1VqyRhgB0xYInvnK6a8zz5LZUqmCULZe+M=; b=o5jwnc/qva2tTLUsJG/VAZ3Htb /4D0BmJDvTZcSp2QJWB34LPZjJLFQj5Tew0zLqy2fdADpUNVS/lIb3Mzf3DC7yWfQheDbm1w5wwWn OKgsJ3NKUMVc9WRhTOh2M9ra3WoKHNWDIuRrSIKSjKCtwMgWOQtksdNivv/V4PTWueNd19WT9p7aT CdRfMgc1aozRJZK6ySGDtQtpEa9I2sBqtoE85gOQgvW0lK3UxxFOmAb6HxcsLXmtvr+85A6XP8W4X SzB0ZDlaPRxc5BQGWYxYcdkSbjXV3lKS4eXjHW6WyJ2z4jvzv/fPVpda6LPVi6yPTldzmdOPP385K Ou3O+LmQ==; Received: from mail-qk1-x72b.google.com ([2607:f8b0:4864:20::72b]) by casper.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4Kii-0000000DIac-2RWz for linux-arm-kernel@lists.infradead.org; Tue, 07 May 2024 13:19:05 +0000 Received: by mail-qk1-x72b.google.com with SMTP id af79cd13be357-7928ec5308cso288067285a.1 for ; Tue, 07 May 2024 06:19:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1715087917; x=1715692717; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=JKfhOSoHE1VqyRhgB0xYInvnK6a8zz5LZUqmCULZe+M=; b=jboO69SdzgaJshs9ffExsz/m+4Eon26eAq3qp3yxRCwc73B1unCE7m5+PKP2InRc+Q ryZQLYZGfmwD0Nf5xwqlYLISNWW5rbClImeMxrrt+UqnjXZraeFUXKWKZ9FpbtOj03pY 1U1jFQzINJ1z/equrjIYJCyI7cJblev5jcfSY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715087917; x=1715692717; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JKfhOSoHE1VqyRhgB0xYInvnK6a8zz5LZUqmCULZe+M=; b=CAB4+bBoELDPhDaBMWfDuawg9xoC5ZIO/8IszBHr5h7pemnEUQRkHPQGFPq/+nb8lD XqL2lSbva97tQJbDtw+lVwLpdnd4XdtxSmdVCPpdjK7UwZGQ0VpTP3rR2nvzwLCsr6N1 7fOwQU/1GuSdZ+NEfKWLMWD5nxQ5L6f9I1nszBQfKFrr7kC7yjr2O/yQvPwx/CdmQIfz QrvapFn3ElpcTtp+tbLxyOcgNUbVY/qpb90xEu0QDR0Co3WhYUn9MnxHGmi5qxm1PkV3 li3syoIcoa4XrWx+4YR0l/L2tkeEC+3EnY2CIDEAOb8J4zTf74qc7spnuTZAQHAfnn5E WJaA== X-Forwarded-Encrypted: i=1; AJvYcCUXBbuqGdBFnh5COZR7Zu55xre5CltRAckBz1l0nXBKtgvDD79HM6OQXZ3fLecGJUOxhsC8P/mAYJkdWHy669TgiKw3hRAi8HQLLxp9VxeLOZNrFtU= X-Gm-Message-State: AOJu0YwnfWKuJIV5EOXTLnvZ63VahYSX7CbHnL+fqjYloXDGNrM6hY4a 1A62fkdm+jmU4+2f/sGbYx4jVNb20/9ZIqCo78Fs1Pjahfhsgv4VCpPsyqUf4A== X-Google-Smtp-Source: AGHT+IFKliypIzu0YjFcg14a69MBEAau+ZXpSAYRUE5dq1ueGc4ePsCBbZXpGGTph+KzlVWTljAkDg== X-Received: by 2002:a0c:e082:0:b0:6a0:f637:667 with SMTP id 6a1803df08f44-6a14600e407mr45875746d6.12.1715087917380; Tue, 07 May 2024 06:18:37 -0700 (PDT) Received: from denia.c.googlers.com (114.152.245.35.bc.googleusercontent.com. [35.245.152.114]) by smtp.gmail.com with ESMTPSA id t15-20020a05621405cf00b006a0d19c3139sm4655105qvz.118.2024.05.07.06.18.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 May 2024 06:18:36 -0700 (PDT) From: Ricardo Ribalda Date: Tue, 07 May 2024 13:18:34 +0000 Subject: [PATCH 08/18] media: siano: Use flex arrays for sms_firmware MIME-Version: 1.0 Message-Id: <20240507-cocci-flexarray-v1-8-4a421c21fd06@chromium.org> References: <20240507-cocci-flexarray-v1-0-4a421c21fd06@chromium.org> In-Reply-To: <20240507-cocci-flexarray-v1-0-4a421c21fd06@chromium.org> To: Michael Tretter , Pengutronix Kernel Team , Mauro Carvalho Chehab , Laurent Pinchart , Michal Simek , Andy Walls , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Hans Verkuil , Ricardo Ribalda X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240507_141900_724591_7AFBF7A7 X-CRM114-Status: GOOD ( 11.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Replace old style single array member, with flex array. The struct is allocated, but it seems like there was an over allocation error: fw_buf = kmalloc(ALIGN(fw->size + sizeof(struct sms_firmware), SMS_ALLOC_ALIGNMENT), GFP_KERNEL | coredev->gfp_buf_flags); This change fixes this cocci warning: drivers/media/common/siano/smscoreapi.h:669:6-13: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) Signed-off-by: Ricardo Ribalda --- drivers/media/common/siano/smscoreapi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/common/siano/smscoreapi.h b/drivers/media/common/siano/smscoreapi.h index bc61bc8b9ea9..82d9f8a64d99 100644 --- a/drivers/media/common/siano/smscoreapi.h +++ b/drivers/media/common/siano/smscoreapi.h @@ -666,7 +666,7 @@ struct sms_firmware { u32 check_sum; u32 length; u32 start_address; - u8 payload[1]; + u8 payload[]; }; /* statistics information returned as response for