From patchwork Tue May 7 14:14:47 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13657198 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 460DAC10F1A for ; Tue, 7 May 2024 14:15:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QlZlthhXD+orK7OFe7tiekEnlI1mbJVn9r9k+l+T5Mg=; b=L1Wad7Xkr1nU84 XksspR7ckjHntlwiVbv89C0ZJW/9THJfgCggyDZGvfc8FVaKq6tnFFxAA6IowbxJcnKAffMSheQH+ eKCPIVFWbH01A/u6uU0o8+zJOa2inZqiJwqfEjhPrd/DppP5+ReO3erlUj4UC7mq70HbxCAPEeUrO 8qPQhTCOub125nzD0+DVgij2pgcy1AIzfs4pXUv0EJ/T+Ot1kvWaXyu34FhMS5vvCLR5gskDPGqb9 FOW26e55w5O2xA+FMj/0hh6HWxRimNLOqnHa1Ky1ydsKYofpFfSFjThzuTIFYYR1GM+9pI1S0p8xC XfT26dW9Is2eImy3cJ+g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4Las-0000000BQXL-1nXO; Tue, 07 May 2024 14:14:58 +0000 Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4Lak-0000000BQS1-3A5n for linux-arm-kernel@lists.infradead.org; Tue, 07 May 2024 14:14:55 +0000 Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-a59b81d087aso682769466b.3 for ; Tue, 07 May 2024 07:14:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1715091287; x=1715696087; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=LRJY6HmSgpn53uyORMcRB9h2EnMXe+jzCDlKmur6pwc=; b=XtSYjE267deO5E5buO2f12Dw00h0srSpLlgg/02DpSZpodA9eAE8EuF3cIww1/xlWa gLlbCKEhENXs+elSq/UloLyxAd3mBdef1KOFzAK+ZCsi9xcMK5hAkRuy7NNJJz6mDL6e zTVU38V9P103XetjRzv1fBO2IlVYolyC/fT2lxr/oY0vMjPEtlXdmjJp1bGYttnx2/KI RQVevYhoxaddJRNMk9b0GkcN2e3Jdp/RWmwGSc+36oGi70DdxxPUN82s75VW7+cW9rtP lghBo8CQ0tCn2sUBFCAteZVBfVw++GHF9WX2HGtdlipKeu7rKOVAA8q5eQ9pTVahTyKI hLTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715091287; x=1715696087; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LRJY6HmSgpn53uyORMcRB9h2EnMXe+jzCDlKmur6pwc=; b=hTUeebWVKP6+pDMAXz3pfcQ7BdIRf7FCZ4LDUt/uo9qb0iHSrT2KOe6HSV+Oo8n35s Q1H1o9iQBhBfkXDj+iDmUUT2gmyIJ/EwCCd5SbPD+wu5ZU/ZEKR58B87xgQC+gAZCrsp lMuTCk42pmKcfo4znLWvaiyvI19y4cmXgFGi8IvsF7BOMbO4/sxpG0NTqBb69D3gG6vF NwUjjeG4d7Zwjvlsqg2lgenpBNdltkPOpZ3k73pkaTNKmgc53QvzBcA/KOnhOlBe1sQg 79ML/mmqGcmxWY9z37pGt3UFMRdLWjrG4o6jpEDsZm0iwOtQxQ6uakfjwMK51Ibev56m CWMQ== X-Forwarded-Encrypted: i=1; AJvYcCVEgg6ZM2XE2wCzhSf6lvhIrJ8Z5kQQd3QgM++5T8s6pVJ3Aa5f1ViDceH1i2oAIBE6Lb/PMJX1UfPZuCPUyU9NP7PWL3eYY9A908S6KSo4m11ma5s= X-Gm-Message-State: AOJu0YwinrZ+E2v39jrLGf8GN8p0sjHHqx7dpZCdAjw7lc4UbfKTFi+H fDVsli+PQE4ZXJ0b+ugWMXq0cjAOzILFGiJ++KMEEcjstMG+Klgz1XaYtgZ/LuU= X-Google-Smtp-Source: AGHT+IEdZxa78ehLtOjVAh87nK9d2t0R1fsYeVK5kmd0WktV4j/K80OYdHHk5mz5N7FPqzg+kN+QUg== X-Received: by 2002:a50:a45c:0:b0:572:9dc3:ce3b with SMTP id v28-20020a50a45c000000b005729dc3ce3bmr11623041edb.1.1715091287502; Tue, 07 May 2024 07:14:47 -0700 (PDT) Received: from puffmais.c.googlers.com (8.239.204.35.bc.googleusercontent.com. [35.204.239.8]) by smtp.gmail.com with ESMTPSA id x2-20020a056402414200b00572cf08369asm5621928eda.23.2024.05.07.07.14.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 May 2024 07:14:47 -0700 (PDT) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Tue, 07 May 2024 15:14:47 +0100 Subject: [PATCH 4/5] phy: exynos5-usbdrd: fix definition of EXYNOS5_FSEL_26MHZ MIME-Version: 1.0 Message-Id: <20240507-samsung-usb-phy-fixes-v1-4-4ccba5afa7cc@linaro.org> References: <20240507-samsung-usb-phy-fixes-v1-0-4ccba5afa7cc@linaro.org> In-Reply-To: <20240507-samsung-usb-phy-fixes-v1-0-4ccba5afa7cc@linaro.org> To: Vinod Koul , Kishon Vijay Abraham I , Krzysztof Kozlowski , Alim Akhtar , Sam Protsenko Cc: Peter Griffin , Tudor Ambarus , Will McVicker , kernel-team@android.com, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , =?utf-8?q?Andr=C3=A9?= =?utf-8?q?_Draszik?= X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240507_071450_823597_C155B62F X-CRM114-Status: GOOD ( 13.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Using 0x82 seems odd, where everything else is just a sequence. On E850, this macro isn't used (as a register value), only to assign its value to the 'extrefclk' variable, which is otherwise unused on that platform. Older platforms don't appear to support 26MHz in the first place (since this macro was added for E850). Furthermore, the downstream driver uses 0x82 to denote USBPHY_REFCLK_DIFF_26MHZ (whatever that means exactly), but for all the other values we match downstream's non-DIFF macros. Update to avoid confusion. No functional change intended. Signed-off-by: André Draszik Reviewed-by: Peter Griffin --- drivers/phy/samsung/phy-exynos5-usbdrd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/samsung/phy-exynos5-usbdrd.c b/drivers/phy/samsung/phy-exynos5-usbdrd.c index ed4898741c99..1da7a4881f72 100644 --- a/drivers/phy/samsung/phy-exynos5-usbdrd.c +++ b/drivers/phy/samsung/phy-exynos5-usbdrd.c @@ -30,7 +30,7 @@ #define EXYNOS5_FSEL_19MHZ2 0x3 #define EXYNOS5_FSEL_20MHZ 0x4 #define EXYNOS5_FSEL_24MHZ 0x5 -#define EXYNOS5_FSEL_26MHZ 0x82 +#define EXYNOS5_FSEL_26MHZ 0x6 #define EXYNOS5_FSEL_50MHZ 0x7 /* Exynos5: USB 3.0 DRD PHY registers */