| Message ID | 20240508-midas-wm1811-gpio-jack-v2-7-b4d36cd02c6e@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | ASoC: samsung: midas-audio: Add GPIO-based headset jack detection | expand |
On 08/05/2024 12:58, Artur Weber wrote: > Drop incorrect interrupt parent and add MCLK2 clock. 1. Separate patches. 2. Missing explanation why. "Incorrect" says a bit, but not too much. Also, imprecise - you remove all interrupts, not just incorrect parent. Please provide proper rationale, why this is not correct and information that bluetooth 32 kHz clock feeds both bluetooth module and audio codec. > Best regards, Krzysztof
diff --git a/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi b/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi index 8dc81112172c..20e5e7ba6b92 100644 --- a/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi +++ b/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi @@ -529,12 +529,11 @@ &i2c_4 { wm1811: audio-codec@1a { compatible = "wlf,wm1811"; reg = <0x1a>; - clocks = <&pmu_system_controller 0>; - clock-names = "MCLK1"; + clocks = <&pmu_system_controller 0>, + <&s5m8767_osc S2MPS11_CLK_BT>; + clock-names = "MCLK1", "MCLK2"; interrupt-controller; #interrupt-cells = <2>; - interrupt-parent = <&gpx3>; - interrupts = <6 IRQ_TYPE_LEVEL_HIGH>; gpio-controller; #gpio-cells = <2>;
Drop incorrect interrupt parent and add MCLK2 clock. Signed-off-by: Artur Weber <aweber.kernel@gmail.com> --- Changes in v2: - Split out wm1811 changes from midas-audio config change patch --- arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)