From patchwork Wed May 8 09:56:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13658365 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AA886C04FFE for ; Wed, 8 May 2024 09:56:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=QhPJk/4y2PjHpBBu1CvRKNOmJHLiog+alLbCLfajbro=; b=hIwVX4xjAjaMw/ W6qKm4bnAOKN9+/hx6wv61nAqTc2Htz6wIgC2blTmOIDGkrqH/s0VfzgYicdYgF6j9NHwzZoj07Iu OMlE2VjqKNf6Vb90m21u5qH+Ala7MhYRnBdihDG0DayyE8ISa/PmNcSk8NU2hQbwtQAiFecu8vJOF YX38aCMXPYh4h5nHVsOX21K9iRI8fG/8zBYUTw48kwokxZnwcpM4MKSSphLrOJjZ+MSMSzq1oxmkI ZIC0S+LZ11RaMWqRs2Gjbb9OTylovOz0G739CHVD3lhQZCrSqnUXBQjtqk3c/V6giChmcIvMooElO KyqA+BH4nYNDM6v9NAZQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4e2O-0000000EqsG-1kJ1; Wed, 08 May 2024 09:56:36 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4e2L-0000000Eqoe-09EH for linux-arm-kernel@lists.infradead.org; Wed, 08 May 2024 09:56:34 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s4e26-0003tz-2c; Wed, 08 May 2024 11:56:18 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1s4e22-000FZO-TL; Wed, 08 May 2024 11:56:14 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1s4e22-000P2m-2c; Wed, 08 May 2024 11:56:14 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Mark Brown , Shawn Guo , Sascha Hauer Cc: Pengutronix Kernel Team , Fabio Estevam , Martin Kaiser , Alexander Stein , Francesco Dolcini , linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: [PATCH] spi: imx: Don't expect DMA for i.MX{25,35,50,51,53} cspi devices Date: Wed, 8 May 2024 11:56:10 +0200 Message-ID: <20240508095610.2146640-2-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1292; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=4POJOZrPUHJ4nLXafYkKHc0N6Q4o99ssDV15veYIDv4=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBmO0w7jfwBMKYN5LrwTb8WMy4uLu8hgzfnw4SlG sO0fmfSZeGJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZjtMOwAKCRCPgPtYfRL+ TvqyB/oDstQEmdCXLVt/2A8ZzX9lJ4egjjfpipCboZqbVLrRSWx4y+ScewExE4oLHfYFbt8eMlG 828IAsPzjeM34V+YeBnNLAPMWR9DK/6/hj929Nqv6wMxp9TMarj8eqSzkAtwRAv9wa7cyA3JLIH FlLW1Swe0Zk5wda+KtsZQOhokZZHMbNbPWkhnueTbMaAyDiyTbyhcYKl+f2pV0DAYGrSjhmne1Q 9eB5AbSJ7jmeQycnEDewkJE+nKaRLJa09tX+SRFYlUUUOGk9kxsQmsVmA7BqV1Z83J0/XGJLahG CmDGwfaGnrxafovALzJezUnG7tdPQrVlOWLcsvG7TM7PAw8W X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240508_025633_093211_56971C4C X-CRM114-Status: GOOD ( 14.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org While in commit 2dd33f9cec90 ("spi: imx: support DMA for imx35") it was claimed that DMA works on i.MX25, i.MX31 and i.MX35 the respective device trees don't add DMA channels. The Reference manuals of i.MX31 and i.MX25 also don't mention the CSPI core being DMA capable. (I didn't check the others.) Since commit e267a5b3ec59 ("spi: spi-imx: Use dev_err_probe for failed DMA channel requests") this results in an error message spi_imx 43fa4000.spi: error -ENODEV: can't get the TX DMA channel! during boot. However that isn't fatal and the driver gets loaded just fine, just without using DMA. Signed-off-by: Uwe Kleine-König --- drivers/spi/spi-imx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: e7b4ef8fffaca247809337bb78daceb406659f2d diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c index f4006c82f867..4de5476f79b8 100644 --- a/drivers/spi/spi-imx.c +++ b/drivers/spi/spi-imx.c @@ -1060,7 +1060,7 @@ static struct spi_imx_devtype_data imx35_cspi_devtype_data = { .rx_available = mx31_rx_available, .reset = mx31_reset, .fifo_size = 8, - .has_dmamode = true, + .has_dmamode = false, .dynamic_burst = false, .has_targetmode = false, .devtype = IMX35_CSPI,