From patchwork Thu May 9 07:31:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hsin-Te Yuan X-Patchwork-Id: 13659506 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B3916C10F1A for ; Thu, 9 May 2024 07:32:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Message-Id:MIME-Version:Subject: Date:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=wT+/HmHJWKDrUGS605WrYnlHnILhAA423/jb3kl2ddI=; b=oPUjtMWSAW+D9q b+yeld9M9TpPvfSMYUuFFSjHr6RTdQWzn7KB/7DYrgF0DCNOx5J80/zntKWM5DSM3GxpLbMpuPybP giqR8EIJBJxcoU/o0uiIiC5Sq3+SaUJcRtlf8dFa9Mi1FxTIb1F2OauskdpaY1nw3CsFoc0JdjE77 cC4GT7+nAWdGLM9+jfgT3EZSUheW6hW5TY4bLCqtzNljlj2Q/thnq6Q4ZXw0RyfJsb1BdE5AlbcHI kk7PE+9eeubfydgg8Pj4TQS/Kwm8PHsvxSsdPwgffevEphgsB4nqmr1P3BUVj5JmZ3GiQrUlAQS7f qL2MbUaR/jdp7A8ECSZA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4yFj-00000000hFP-1raL; Thu, 09 May 2024 07:31:43 +0000 Received: from mail-oo1-xc32.google.com ([2607:f8b0:4864:20::c32]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4yFf-00000000hE9-3rbT for linux-arm-kernel@lists.infradead.org; Thu, 09 May 2024 07:31:41 +0000 Received: by mail-oo1-xc32.google.com with SMTP id 006d021491bc7-5b2733389f9so138978eaf.1 for ; Thu, 09 May 2024 00:31:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1715239895; x=1715844695; darn=lists.infradead.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=yFIJqrgUYRufZO44ifi0BeHH43Pj5mRVkX8VaE4POmU=; b=R4ktheX6kJw8y4n+Nj1fH6uOa9iYMac/kiKDOe+iuH9dNYmd84BOuwHZnk5cRk2kcm ukkL2IBaPO9/+KPg7hShzBIezx3uiB5EhHyZAJbgTi9ez4/dV4NIN2BvmnkcQM8zPYss 0mUhqFLTw+SNO/NifFLejAjjvTvdDFqM7NIP4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715239895; x=1715844695; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yFIJqrgUYRufZO44ifi0BeHH43Pj5mRVkX8VaE4POmU=; b=AcTLQVWKTJ9T7NwE8rTik8hfTt4QBvism3cWd4jyXKJq2+JExk5OsD8A9CHjmmvmD7 L6XV3ZV590lOfDqbpbvEdyo9su+m2U/I4vZPHImi+O6oQ4fRNcWAEHiv7DlPOX0SCKQu M4Q8SKpGvAAxXq/m5OtX2bRjKL4qzAfkHN7Z5Uh1AU8shSNJCq/+tJYkwvSd0ilDzXF7 90XZkF6G9GbiR0KgUA4c/GuoJ60jLtp3XpM7Cp+EnMeYVT1QNPRqfVO9ErUgF2B6hguo r35JlfMtoCrJsfYUE+BXH1MvNH3HxNZ2jjPWxld/SNKhmoycJgDd5e33oLWu87L30772 bOYA== X-Forwarded-Encrypted: i=1; AJvYcCXFbE6XelU1MPVR9+c+scS366faYwxak4JQdda0v5OnhM2zu/NaOvYb2h4wh8yghJXDiGlufn/jf8yPMc3WMa1h/3uzrdVyZWLDe8QxxYAXQsxdSTA= X-Gm-Message-State: AOJu0YxnT2kA+bDM+dhVc7PWo7SiVNJyJ5CTiTLpLqIUmzSTCCQGUuoN DHqulYaVT5PpWi3oneq++mPLWynCwT2Kka6OQyG4vYi7Fl9GXb89wGv59HWat0RGxt+/+5cjhu0 = X-Google-Smtp-Source: AGHT+IFxCbiVVPSFIyPcWAzqs1t5rme6BYl/0xBEXZ775m3VFUNpwbdtD+YpUNB1N0N06kSsvGevfg== X-Received: by 2002:a05:6358:54a2:b0:18e:a0ce:a35c with SMTP id e5c5f4694b2df-192d2c2b383mr578760355d.14.1715239895370; Thu, 09 May 2024 00:31:35 -0700 (PDT) Received: from yuanhsinte1.c.googlers.com (150.221.124.34.bc.googleusercontent.com. [34.124.221.150]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-63411346d46sm586459a12.79.2024.05.09.00.31.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 May 2024 00:31:34 -0700 (PDT) From: Hsin-Te Yuan Date: Thu, 09 May 2024 07:31:29 +0000 Subject: [PATCH] ASoC: mediatek: mt8192: fix register configuration for tdm MIME-Version: 1.0 Message-Id: <20240509-8192-tdm-v1-1-530b54645763@chromium.org> X-B4-Tracking: v=1; b=H4sIANB7PGYC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIxMDUwNLXQtDSyPdkpRc3eSkNKNEc+Nky5QUYyWg8oKi1LTMCrBR0bG1tQD PHd/7WgAAAA== To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Matthias Brugger , AngeloGioacchino Del Regno , Jiaxin Yu Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Hsin-Te Yuan X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240509_003140_022564_B8072C28 X-CRM114-Status: GOOD ( 13.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org For DSP_A, data is a BCK cycle behind LRCK trigger edge. For DSP_B, this delay doesn't exist. Fix the delay configuration to match the standard. Fixes: 52fcd65414abfc ("ASoC: mediatek: mt8192: support tdm in platform driver") Signed-off-by: Hsin-Te Yuan Reviewed-by: Chen-Yu Tsai Reviewed-by: AngeloGioacchino Del Regno --- sound/soc/mediatek/mt8192/mt8192-dai-tdm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- base-commit: 45db3ab70092637967967bfd8e6144017638563c change-id: 20240509-8192-tdm-cbf2a73c9dd3 Best regards, diff --git a/sound/soc/mediatek/mt8192/mt8192-dai-tdm.c b/sound/soc/mediatek/mt8192/mt8192-dai-tdm.c index 9ce06821c7d0f..49440db370af0 100644 --- a/sound/soc/mediatek/mt8192/mt8192-dai-tdm.c +++ b/sound/soc/mediatek/mt8192/mt8192-dai-tdm.c @@ -566,10 +566,10 @@ static int mtk_dai_tdm_hw_params(struct snd_pcm_substream *substream, tdm_con |= 1 << DELAY_DATA_SFT; tdm_con |= get_tdm_lrck_width(format) << LRCK_TDM_WIDTH_SFT; } else if (tdm_priv->tdm_out_mode == TDM_OUT_DSP_A) { - tdm_con |= 0 << DELAY_DATA_SFT; + tdm_con |= 1 << DELAY_DATA_SFT; tdm_con |= 0 << LRCK_TDM_WIDTH_SFT; } else if (tdm_priv->tdm_out_mode == TDM_OUT_DSP_B) { - tdm_con |= 1 << DELAY_DATA_SFT; + tdm_con |= 0 << DELAY_DATA_SFT; tdm_con |= 0 << LRCK_TDM_WIDTH_SFT; }