From patchwork Thu May 9 06:47:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 13659491 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 83057C10F1A for ; Thu, 9 May 2024 06:48:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=2nENC8oComZ3S+TN3d1a2XSe3IvPQB2Y27UMl09y4po=; b=REij7ndxcj1d74 eqL5IhMxtmBRPfVRK4DiYAo+xuENgA6Re06BG1lqGJR0K6JlIov2pwxVWbGoSaKb0eVrxDLKkLFXD SNRT16lP0y7Y7s3UAsW+7qbEpSItpGDvKieSvYfyy+Y+8ps6H6Elynv22lHskJdewFDHk1ER8BjA2 1VvbkcYDgJvjTPb8dfIt6H1WdlOBWHslOAppDYSRhzUosLCAZQd3bQ5QTPIkFgTvMtz8Z/o0ZgyM2 UGNIt1C9Jarj+iFFBoI4KZqA2R3Xtx9tK4EGHRU1v8Miqd0oB32czXqoXCNkv2x6pet+s8cXyVIge Mlg5ZIwysw3JpxymNbKA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4xZn-00000000biS-0b9c; Thu, 09 May 2024 06:48:23 +0000 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4xZj-00000000bhj-0d9q for linux-arm-kernel@lists.infradead.org; Thu, 09 May 2024 06:48:20 +0000 Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-1ee954e0aa6so3567335ad.3 for ; Wed, 08 May 2024 23:48:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715237296; x=1715842096; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=jZJ/qPvhWmaN0bPAlkl54j0+0U9B8BSbeBplUAy1OJA=; b=c2Pw7i/a1euo39CayyYIdx9IuRV1dhCcGB05oDVcaFLeJs2998HeqaFpSgIgRyWPST AXJ+9/PmDmwwxUlaPK2gpyIEJnrhwm+Su9GBxtYOBIvzZj+x0RkIbHMAlYNrybtuo7rY Zp7UEkq3Glsy0bb7vBr9PkJMMIYaFVezlhdxNnrz2S6CbMfo5z7r3DIOKRiZ6uNYH601 Bt7oqz6IoYgWkxltnH6/I2JjEYCFf0QtDHOgGcChqhLLjzSdvCqvit95EWehJjdA5fDm 6plmUWu8VImRtSHm1Qm0CRqB8i+ghKEr3Qj8zf3vB3Gqi9oMnPdqMU0iRRrq05Bets/U d6sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715237296; x=1715842096; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jZJ/qPvhWmaN0bPAlkl54j0+0U9B8BSbeBplUAy1OJA=; b=RjhDxvJGT20nI1S7n2CRBJ/JZ2IF3RC+zqHVfM38EsChNM6Nb9jrQD0ZQvRHxb6ruZ d8gT50I0ForsJ0lIrG6b6jQogYt3r7OKoMvHt14XKAw1v5WBBg/wlA079UDIumj3jA2Z 0MrTUle06w/LdDLT3ixvGN6kVgSor/wIuCfZNr8p1ePDL9kfrTlhR7NqGMKdeaZcD8Fk BUtObYc2oBd4U40sdzbeJi96E9vAvvfyT0pY/MoOHx6C55pGwfYgzXPgBY6obY+YLVIP W26a7liHqYiCGc+kI+5QHT03O2SP6aC83EogB7/FmAqdu5uvFxXZYWW/9POc/t2iTA1W 3fzA== X-Forwarded-Encrypted: i=1; AJvYcCVZ7URlFwWiVhKBTWTD1VkDst8ef/dSoeCVD6DxrfA/aocv2qs80Qxmzy6Qqjte4ZYxVIUmcNxnsWHs5G01gOx91XppwrTggEWQunwKBu2wM8gLm1o= X-Gm-Message-State: AOJu0YyIIUJ6o2k4jc3j1CtmFQQc/EbJIs/F8mS0eSdBZjaIXhGf1M1m C+luAD/0WoKbZNGfHAdQ9i0m9uzSwOGXTHIHVyozxK7F1Vv9z3aw X-Google-Smtp-Source: AGHT+IHuANNmgdYBKLvlqBD4TQvuUL2BgBfhsM6ZChKBoBdTPu/89MPDHwGCEaMcOqarwXUh+xlqsw== X-Received: by 2002:a17:903:2451:b0:1eb:57a9:53f1 with SMTP id d9443c01a7336-1eeb03a56a8mr59339955ad.1.1715237295838; Wed, 08 May 2024 23:48:15 -0700 (PDT) Received: from localhost.localdomain ([113.30.217.222]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0bf31da2sm6685885ad.165.2024.05.08.23.48.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 May 2024 23:48:15 -0700 (PDT) From: Anand Moon To: Chanwoo Choi , MyungJoo Ham , Kyungmin Park , Krzysztof Kozlowski , Alim Akhtar Cc: Anand Moon , linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v4] PM / devfreq: exynos: Use Use devm_clk_get_enabled() helpers Date: Thu, 9 May 2024 12:17:48 +0530 Message-ID: <20240509064754.10082-1-linux.amoon@gmail.com> X-Mailer: git-send-email 2.44.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240508_234819_214178_253BD86F X-CRM114-Status: GOOD ( 19.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The devm_clk_get_enabled() helpers: - call devm_clk_get() - call clk_prepare_enable() and register what is needed in order to call clk_disable_unprepare() when needed, as a managed resource. This simplifies the code and avoids the calls to clk_disable_unprepare(). While at it, use dev_err_probe consistently, and use its return value to return the error code. Signed-off-by: Anand Moon --- V4 - wrap up the error messagee within 80 char v3 - No change v2 - No change --- drivers/devfreq/exynos-bus.c | 22 +++++----------------- 1 file changed, 5 insertions(+), 17 deletions(-) diff --git a/drivers/devfreq/exynos-bus.c b/drivers/devfreq/exynos-bus.c index 00118580905a..7d06c476d8e9 100644 --- a/drivers/devfreq/exynos-bus.c +++ b/drivers/devfreq/exynos-bus.c @@ -160,7 +160,6 @@ static void exynos_bus_exit(struct device *dev) platform_device_unregister(bus->icc_pdev); dev_pm_opp_of_remove_table(dev); - clk_disable_unprepare(bus->clk); dev_pm_opp_put_regulators(bus->opp_token); } @@ -171,7 +170,6 @@ static void exynos_bus_passive_exit(struct device *dev) platform_device_unregister(bus->icc_pdev); dev_pm_opp_of_remove_table(dev); - clk_disable_unprepare(bus->clk); } static int exynos_bus_parent_parse_of(struct device_node *np, @@ -247,23 +245,16 @@ static int exynos_bus_parse_of(struct device_node *np, int ret; /* Get the clock to provide each bus with source clock */ - bus->clk = devm_clk_get(dev, "bus"); - if (IS_ERR(bus->clk)) { - dev_err(dev, "failed to get bus clock\n"); - return PTR_ERR(bus->clk); - } - - ret = clk_prepare_enable(bus->clk); - if (ret < 0) { - dev_err(dev, "failed to get enable clock\n"); - return ret; - } + bus->clk = devm_clk_get_enabled(dev, "bus"); + if (IS_ERR(bus->clk)) + return dev_err_probe(dev, PTR_ERR(bus->clk), + "failed to get bus clock\n"); /* Get the freq and voltage from OPP table to scale the bus freq */ ret = dev_pm_opp_of_add_table(dev); if (ret < 0) { dev_err(dev, "failed to get OPP table\n"); - goto err_clk; + return ret; } rate = clk_get_rate(bus->clk); @@ -281,8 +272,6 @@ static int exynos_bus_parse_of(struct device_node *np, err_opp: dev_pm_opp_of_remove_table(dev); -err_clk: - clk_disable_unprepare(bus->clk); return ret; } @@ -453,7 +442,6 @@ static int exynos_bus_probe(struct platform_device *pdev) err: dev_pm_opp_of_remove_table(dev); - clk_disable_unprepare(bus->clk); err_reg: dev_pm_opp_put_regulators(bus->opp_token);