| Message ID | 20240510-imx-clk-v2-6-c998f315d29c@nxp.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | clk: imx: misc update/fix | expand |
On 10/05/2024 11.19, Peng Fan (OSS) wrote: > From: Shengjiu Wang <shengjiu.wang@nxp.com> > > The generated clock frequency may not accurate, for example > the expected rate is 361267200U, but result is 361267199U. > Add rate_table for audio clocks to avoid such issue. > > Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com> > Reviewed-by: Jacky Bai <ping.bai@nxp.com> > Signed-off-by: Peng Fan <peng.fan@nxp.com> > --- > drivers/clk/imx/clk-pll14xx.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/clk/imx/clk-pll14xx.c b/drivers/clk/imx/clk-pll14xx.c > index 55812bfb9ec2..6b2c849f8b71 100644 > --- a/drivers/clk/imx/clk-pll14xx.c > +++ b/drivers/clk/imx/clk-pll14xx.c > @@ -64,6 +64,17 @@ static const struct imx_pll14xx_rate_table imx_pll1443x_tbl[] = { > PLL_1443X_RATE(650000000U, 325, 3, 2, 0), > PLL_1443X_RATE(594000000U, 198, 2, 2, 0), > PLL_1443X_RATE(519750000U, 173, 2, 2, 16384), > + PLL_1443X_RATE(393216000U, 262, 2, 3, 9437), > + PLL_1443X_RATE(361267200U, 361, 3, 3, 17511), Sorry, what? This reintroduces the two entries that were removed in 72d00e560d10, claiming that this produces an exact output, whereas that commit very clearly states (and it's easy to do the math and verify) that those entries actually resulted in output values of 393215995 and 361267196. So even if the dynamic computation would result in 361267199 (it doesn't, it gives an exact output), that would still be better than what these hard-coded entries achieve. Rasmus
> Subject: Re: [PATCH v2 06/17] clk: imx: pll14xx: use rate_table for audio plls > > On 10/05/2024 11.19, Peng Fan (OSS) wrote: > > From: Shengjiu Wang <shengjiu.wang@nxp.com> > > > > The generated clock frequency may not accurate, for example the > > expected rate is 361267200U, but result is 361267199U. > > Add rate_table for audio clocks to avoid such issue. > > > > Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com> > > Reviewed-by: Jacky Bai <ping.bai@nxp.com> > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > > --- > > drivers/clk/imx/clk-pll14xx.c | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/drivers/clk/imx/clk-pll14xx.c > > b/drivers/clk/imx/clk-pll14xx.c index 55812bfb9ec2..6b2c849f8b71 > > 100644 > > --- a/drivers/clk/imx/clk-pll14xx.c > > +++ b/drivers/clk/imx/clk-pll14xx.c > > @@ -64,6 +64,17 @@ static const struct imx_pll14xx_rate_table > imx_pll1443x_tbl[] = { > > PLL_1443X_RATE(650000000U, 325, 3, 2, 0), > > PLL_1443X_RATE(594000000U, 198, 2, 2, 0), > > PLL_1443X_RATE(519750000U, 173, 2, 2, 16384), > > + PLL_1443X_RATE(393216000U, 262, 2, 3, 9437), > > + PLL_1443X_RATE(361267200U, 361, 3, 3, 17511), > > Sorry, what? This reintroduces the two entries that were removed in > 72d00e560d10, I overlooked this. claiming that this produces an exact output, whereas that > commit very clearly states (and it's easy to do the math and verify) that those > entries actually resulted in output values of 393215995 and 361267196. So > even if the dynamic computation would result in 361267199 (it doesn't, it > gives an exact output), that would still be better than what these hard-coded > entries achieve. ok, I will let Shengjiu to comment on this. Thanks Peng. > > Rasmus
diff --git a/drivers/clk/imx/clk-pll14xx.c b/drivers/clk/imx/clk-pll14xx.c index 55812bfb9ec2..6b2c849f8b71 100644 --- a/drivers/clk/imx/clk-pll14xx.c +++ b/drivers/clk/imx/clk-pll14xx.c @@ -64,6 +64,17 @@ static const struct imx_pll14xx_rate_table imx_pll1443x_tbl[] = { PLL_1443X_RATE(650000000U, 325, 3, 2, 0), PLL_1443X_RATE(594000000U, 198, 2, 2, 0), PLL_1443X_RATE(519750000U, 173, 2, 2, 16384), + PLL_1443X_RATE(393216000U, 262, 2, 3, 9437), + PLL_1443X_RATE(361267200U, 361, 3, 3, 17511), + PLL_1443X_RATE(245760000U, 328, 4, 3, 0xae15), + PLL_1443X_RATE(225792000U, 226, 3, 3, 0xcac1), + PLL_1443X_RATE(122880000U, 328, 4, 4, 0xae15), + PLL_1443X_RATE(112896000U, 226, 3, 4, 0xcac1), + PLL_1443X_RATE(61440000U, 328, 4, 5, 0xae15), + PLL_1443X_RATE(56448000U, 226, 3, 5, 0xcac1), + PLL_1443X_RATE(49152000U, 393, 3, 6, 0x374c), + PLL_1443X_RATE(45158400U, 241, 2, 6, 0xd845), + PLL_1443X_RATE(40960000U, 109, 1, 6, 0x3a07), }; struct imx_pll14xx_clk imx_1443x_pll = {