Message ID | 20240517195344.813032-7-andriy.shevchenko@linux.intel.com (mailing list archive) |
---|---|
State | New |
Headers | show
Return-Path: <linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4EF7AC04FFE for <linux-arm-kernel@archiver.kernel.org>; Fri, 17 May 2024 19:54:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HNcAQ2+xQ6KiCYyLBhJHYT5ACj5pWhr/01ko1eIl9uQ=; b=AiDkDx5aPJhVWd WuDS+gkT2/DA2jd7e43Mj4F60GkPwiyp9amT7JFS3ig5EKwPT9Ay9gwr7iaezEuYD1wkCG+YVFDdI TLeU4Rog5YTrhV2gfgdngLRbqqZmtklJ9FbCRfOfMSTGtRmeY0/GTkNuRRen/YW4BcyvEqPwhpK39 8I7ZGV9OMKDIGW8HUcc1jKlpfjdM/Lid3ncm6hbPOpdnU9JkZP/noMaanWaZ07aWq2CVF1rMXpyC6 C0cq4otoWhr9QGbGZ8FAgmgO+YwkxJqHS9Ikt2MUcrNxbjPEQdMcMi9oO/755YBdmWV4KV0eXvzGc ynJdA+w2TlKCN4DRO05g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s83ea-00000008s1v-1y4R; Fri, 17 May 2024 19:54:08 +0000 Received: from mgamail.intel.com ([198.175.65.18]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s83eP-00000008rrf-19p9 for linux-arm-kernel@lists.infradead.org; Fri, 17 May 2024 19:53:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1715975637; x=1747511637; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=HBWQ6IuxWBHRAQ4QfisCUK6oqXawkSugTUNHrkfwhz4=; b=IOwrQM+8exnePlZADAjzQ1CdbtxHppH+oKUUQfc/flMh3bifSU+X20lE uTA97g96ywMb8oeb402hS/odrv9u5hCDJUhhE28QCJDcOVKquR2TlmRD2 gs2tgwbxbBeiMa4WPthLXNDCV4uDlFGg1Rq00yRiAY7IGY4JADLeVT79r qia86lGrvQoILdpQxD81osjoufAkZ74iLT5VvNqSHcMMifQMlW441Hqbc /GtzaBLfsTzqKsmZLxVlClGodDVht2oZQntVvlh6SOcI38kjZ6oviuNGk s1mx2ibJlrP38Hd8kRLc/q3fw4zJP1xN20WntImUwWKXBqaDjynnd/dyP g==; X-CSE-ConnectionGUID: qraDWjloT1mPER+xQdms3A== X-CSE-MsgGUID: LikJ5suiTbmV1GX5xcKjyg== X-IronPort-AV: E=McAfee;i="6600,9927,11075"; a="12348670" X-IronPort-AV: E=Sophos;i="6.08,168,1712646000"; d="scan'208";a="12348670" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2024 12:53:52 -0700 X-CSE-ConnectionGUID: MMr9Eq2ETEidSEtteES/3Q== X-CSE-MsgGUID: 6mSVDHLuRYSdn73/LP21pQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,168,1712646000"; d="scan'208";a="31915015" Received: from black.fi.intel.com ([10.237.72.28]) by fmviesa006.fm.intel.com with ESMTP; 17 May 2024 12:53:49 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 5945253A; Fri, 17 May 2024 22:53:45 +0300 (EEST) From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> To: Mark Brown <broonie@kernel.org>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Linus Walleij <linus.walleij@linaro.org>, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Daniel Mack <daniel@zonque.org>, Haojian Zhuang <haojian.zhuang@gmail.com>, Robert Jarzmik <robert.jarzmik@free.fr> Subject: [PATCH v1 06/10] spi: pxa2xx: Remove duplicate check Date: Fri, 17 May 2024 22:47:40 +0300 Message-ID: <20240517195344.813032-7-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1336.g36b5255a03ac In-Reply-To: <20240517195344.813032-1-andriy.shevchenko@linux.intel.com> References: <20240517195344.813032-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240517_125357_489622_2BA9E869 X-CRM114-Status: UNSURE ( 9.68 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: <linux-arm-kernel.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/> List-Post: <mailto:linux-arm-kernel@lists.infradead.org> List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org> Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org |
Series |
spi: pxa2xx: Get rid of an additional layer in PCI driver
|
expand
|
diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c index 6bbeb1d09ed9..cd28b798b53b 100644 --- a/drivers/spi/spi-pxa2xx.c +++ b/drivers/spi/spi-pxa2xx.c @@ -1417,9 +1417,6 @@ static int pxa2xx_spi_probe(struct platform_device *pdev) if (!ssp) ssp = &platform_info->ssp; - if (!ssp->mmio_base) - return dev_err_probe(dev, -ENODEV, "failed to get SSP\n"); - if (platform_info->is_target) controller = devm_spi_alloc_target(dev, sizeof(*drv_data)); else
The mmio_base can't be NULL at this point. It's either checked in both pxa_ssp_probe() and pxa2xx_spi_init_ssp() or correctly provided by PCI core. Hence, remove duplicate check which is a dead code. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/spi/spi-pxa2xx.c | 3 --- 1 file changed, 3 deletions(-)