diff mbox series

[1/3] arm64: dts: imx8mm: Describe carrier board 20 MHz Xtal on i.MX8MM Menlo board

Message ID 20240521102435.10019-1-marex@denx.de (mailing list archive)
State New, archived
Headers show
Series [1/3] arm64: dts: imx8mm: Describe carrier board 20 MHz Xtal on i.MX8MM Menlo board | expand

Commit Message

Marek Vasut May 21, 2024, 10:23 a.m. UTC
The i.MX8MM Menlo carrier board uses dedicated 20 MHz Xtal to supply
clock to second SPI CAN controller on the carrier board as well as
CPLD on the same board. Fix incorrect reuse of SoM 20 MHz Xtal for
that purpose, describe the separate Xtal and use it.

Signed-off-by: Marek Vasut <marex@denx.de>
---
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: Rob Herring <robh@kernel.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: devicetree@vger.kernel.org
Cc: imx@lists.linux.dev
Cc: linux-arm-kernel@lists.infradead.org
---
 arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

Comments

Peng Fan May 21, 2024, 12:58 p.m. UTC | #1
> Subject: [PATCH 1/3] arm64: dts: imx8mm: Describe carrier board 20 MHz
> Xtal on i.MX8MM Menlo board
> 
> The i.MX8MM Menlo carrier board uses dedicated 20 MHz Xtal to supply
> clock to second SPI CAN controller on the carrier board as well as CPLD on the
> same board. Fix incorrect reuse of SoM 20 MHz Xtal for that purpose,
> describe the separate Xtal and use it.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: devicetree@vger.kernel.org
> Cc: imx@lists.linux.dev
> Cc: linux-arm-kernel@lists.infradead.org
> ---
>  arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts
> b/arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts
> index 0b123a84018b2..4c38979f7333f 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts
> @@ -14,6 +14,13 @@ / {
>  		     "toradex,verdin-imx8mm",
>  		     "fsl,imx8mm";
> 
> +	/* Carrier board Xtal for SPI CAN controller and CPLD */
> +	clk20mcb: clk-20m-cb {

Per fixed-clock.yaml, nodename should be clock-xx.

Regards,
Peng.

> +		compatible = "fixed-clock";
> +		#clock-cells = <0>;
> +		clock-frequency = <20000000>;
> +	};
> +
>  	/delete-node/ gpio-keys;
> 
>  	leds {
> @@ -60,7 +67,7 @@ &ecspi1 {
>  	/* CAN controller on the baseboard */
>  	canfd: can@0 {
>  		compatible = "microchip,mcp2518fd";
> -		clocks = <&clk_xtal20>;
> +		clocks = <&clk20mcb>;
>  		interrupt-parent = <&gpio1>;
>  		interrupts = <8 IRQ_TYPE_EDGE_FALLING>;
>  		reg = <0>;
> --
> 2.43.0
>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts b/arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts
index 0b123a84018b2..4c38979f7333f 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts
@@ -14,6 +14,13 @@  / {
 		     "toradex,verdin-imx8mm",
 		     "fsl,imx8mm";
 
+	/* Carrier board Xtal for SPI CAN controller and CPLD */
+	clk20mcb: clk-20m-cb {
+		compatible = "fixed-clock";
+		#clock-cells = <0>;
+		clock-frequency = <20000000>;
+	};
+
 	/delete-node/ gpio-keys;
 
 	leds {
@@ -60,7 +67,7 @@  &ecspi1 {
 	/* CAN controller on the baseboard */
 	canfd: can@0 {
 		compatible = "microchip,mcp2518fd";
-		clocks = <&clk_xtal20>;
+		clocks = <&clk20mcb>;
 		interrupt-parent = <&gpio1>;
 		interrupts = <8 IRQ_TYPE_EDGE_FALLING>;
 		reg = <0>;