| Message ID | 20240522-arm64-vexpress-sp804-v1-1-0344cd42eb77@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | clocksource: sp804: Make user selectable | expand |
On Wed, May 22, 2024 at 06:44:41PM +0100, Mark Brown wrote: > The sp804 is currently only user selectable if COMPILE_TEST, this was > done by commit dfc82faad725 ("clocksource/drivers/sp804: Add > COMPILE_TEST to CONFIG_ARM_TIMER_SP804") in order to avoid it being > spuriously offered on platforms that won't have the hardware since it's > generally only seen on Arm based platforms. This config is overly > restrictive, while platforms that rely on the SP804 do select it in > their Kconfig there are others such as the Arm fast models which have a > SP804 available but currently unused by Linux. Relax the dependency to > allow it to be user selectable on arm and arm64 to avoid surprises and > in case someone comes up with a use for extra timer hardware. > > Fixes: dfc82faad725 ("clocksource/drivers/sp804: Add COMPILE_TEST to CONFIG_ARM_TIMER_SP804") > Reported-by: Ross Burton <ross.burton@arm.com> Thanks for the quick fix Mark! Reviewed-by: Sudeep Holla <sudeep.holla@arm.com> -- Regards, Sudeep
diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig index 34faa0320ece..ca6045f90000 100644 --- a/drivers/clocksource/Kconfig +++ b/drivers/clocksource/Kconfig @@ -390,7 +390,8 @@ config ARM_GT_INITIAL_PRESCALER_VAL This affects CPU_FREQ max delta from the initial frequency. config ARM_TIMER_SP804 - bool "Support for Dual Timer SP804 module" if COMPILE_TEST + bool "Support for Dual Timer SP804 module" + depends on ARM || ARM64 || COMPILE_TEST depends on GENERIC_SCHED_CLOCK && HAVE_CLK select CLKSRC_MMIO select TIMER_OF if OF
The sp804 is currently only user selectable if COMPILE_TEST, this was done by commit dfc82faad725 ("clocksource/drivers/sp804: Add COMPILE_TEST to CONFIG_ARM_TIMER_SP804") in order to avoid it being spuriously offered on platforms that won't have the hardware since it's generally only seen on Arm based platforms. This config is overly restrictive, while platforms that rely on the SP804 do select it in their Kconfig there are others such as the Arm fast models which have a SP804 available but currently unused by Linux. Relax the dependency to allow it to be user selectable on arm and arm64 to avoid surprises and in case someone comes up with a use for extra timer hardware. Fixes: dfc82faad725 ("clocksource/drivers/sp804: Add COMPILE_TEST to CONFIG_ARM_TIMER_SP804") Reported-by: Ross Burton <ross.burton@arm.com> Signed-off-by: Mark Brown <broonie@kernel.org> --- drivers/clocksource/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- base-commit: a38297e3fb012ddfa7ce0321a7e5a8daeb1872b6 change-id: 20240522-arm64-vexpress-sp804-365d6938b07c Best regards,