diff mbox series

arm64: dts: ti: k3-j722s-evm: Mark eMMC as non removable

Message ID 20240522083631.1015198-1-b-kapoor@ti.com (mailing list archive)
State New, archived
Headers show
Series arm64: dts: ti: k3-j722s-evm: Mark eMMC as non removable | expand

Commit Message

Bhavya Kapoor May 22, 2024, 8:36 a.m. UTC
Mark the eMMC module on J722S as non removable since it
is always present on the evm.

Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
---
 arch/arm64/boot/dts/ti/k3-j722s-evm.dts | 1 +
 1 file changed, 1 insertion(+)

Comments

Vignesh Raghavendra May 23, 2024, 9:54 a.m. UTC | #1
On 22/05/24 14:06, Bhavya Kapoor wrote:
> Mark the eMMC module on J722S as non removable since it
> is always present on the evm.

Nit s/evm/EVM

> 
> Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
> ---

This needs a Fixes tag?

>  arch/arm64/boot/dts/ti/k3-j722s-evm.dts | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
> index bf3c246d13d1..fe810e32cb7a 100644
> --- a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
> @@ -369,6 +369,7 @@ partition@3fc0000 {
>  &sdhci0 {
>  	disable-wp;
>  	bootph-all;
> +	non-removable;
>  	ti,driver-strength-ohm = <50>;
>  	status = "okay";
>  };
Bhavya Kapoor May 24, 2024, 7:18 a.m. UTC | #2
On 23/05/24 3:24 pm, Vignesh Raghavendra wrote:
>
> On 22/05/24 14:06, Bhavya Kapoor wrote:
>> Mark the eMMC module on J722S as non removable since it
>> is always present on the evm.
> Nit s/evm/EVM
This definately demands a v2
>
>> Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
>> ---
> This needs a Fixes tag?

Hi Vignesh, we are just adding up a property so i assume we should not 
need a fixes tag.

We can take reference from how its done in this patch: 
https://patchwork.kernel.org/project/linux-samsung-soc/patch/1444927873-15140-7-git-send-email-javier@osg.samsung.com/

>
>>   arch/arm64/boot/dts/ti/k3-j722s-evm.dts | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
>> index bf3c246d13d1..fe810e32cb7a 100644
>> --- a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
>> @@ -369,6 +369,7 @@ partition@3fc0000 {
>>   &sdhci0 {
>>   	disable-wp;
>>   	bootph-all;
>> +	non-removable;
>>   	ti,driver-strength-ohm = <50>;
>>   	status = "okay";
>>   };
>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
index bf3c246d13d1..fe810e32cb7a 100644
--- a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
+++ b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
@@ -369,6 +369,7 @@  partition@3fc0000 {
 &sdhci0 {
 	disable-wp;
 	bootph-all;
+	non-removable;
 	ti,driver-strength-ohm = <50>;
 	status = "okay";
 };