From patchwork Mon May 27 14:25:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ulf Hansson X-Patchwork-Id: 13675438 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1053FC25B7D for ; Mon, 27 May 2024 14:26:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EmNoOy/3uCr1LjrsTb+3nxp064f6ro+4mUVyYtGUl20=; b=bzC/lKi/TF0R/7 jee065rSq2K3SGb9z44kUnCHJSBxN6gUd/9dDJjCwgDcIjf6Ah7TNwbmj+290ge/bBzHLrQKG7z1C 9hSIBc2hjcSs1PU4k11jTGApBjZadY+ueYg1IPK4hoSQSymdD60/RvtbkSXXcj+jkR/blft7bZug0 MaR1uVBzTlXXx1h023l1kD9+79AmMZep3TANxC/Ip6APTGYV2ymCVyZ6uT2fE2nmr+32MmEtd+Sod VHlXwALW+st7eaMMarnWJQse90rAkMc9BVNOxkUOPdjOJiWMbSN3hSfNBgEalg2BJC40jLZkNevmD PSUcQftjjqKQ1Y54IKbg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sBbJ1-0000000FMEF-2qdR; Mon, 27 May 2024 14:26:31 +0000 Received: from mail-lf1-x132.google.com ([2a00:1450:4864:20::132]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sBbIm-0000000FM44-0cKS for linux-arm-kernel@lists.infradead.org; Mon, 27 May 2024 14:26:18 +0000 Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-5295bcb9bc1so2928531e87.0 for ; Mon, 27 May 2024 07:26:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1716819974; x=1717424774; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KjTbB47lhtg0PaxHpHSV+ev3VLrPkOO85FcCwtdMOr8=; b=eq4u9sK25bTHCCgNN1d+mwNPGjDwonwy2zWQqYjloaX+Sg5vYulQnco4gGKIeoqZcX aM1jI4KyOpp1Tq7zTP0uAZF/URe300Nvki2E0T8K2neskNJbRGxY8Twl0cVPP0YTX/7s 7bYvciZaCZRl8EdLXu2lMOwAyCdR3T9pGFhodjjAncf/z6FEWUdQwDNilWHfhixQIC6m VmiwWO2bZQ4/sqcJ4UK1r16SX+R3K7lMvTKAVy55VNirGK8Gc9Clvt/X3ok0tJZax7Ro kktw4TRSaplY9GJdt1kQdPSZC9lxV6EPvquYN5SkKAcUEn+d63uidATwb64fRBemS+GW P/sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716819974; x=1717424774; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KjTbB47lhtg0PaxHpHSV+ev3VLrPkOO85FcCwtdMOr8=; b=FSWi5tL3xEuu8XarBHFEYEzD6b94eExF0p7lEv9qyVQB6yqkPkJI7N9Q6SZinBvvKo EOHfHaz43OOv3T88tsThSbCo9V+1+eeJ7kIZMnydVgopFOKWyO2Q0gMSwkREeIKeohhS rUqHiMfb03t5WcCEhl5Yjt6bXwwHzgHbiSXKSn9OSBaaqsnxKMTwHufhMOQmD4Uu+iwC g5xjSZMu0bPim463Ol5GYLw7C616sDeiVnNKz1KkMgi0ZyGiVg3tAlXeaBthHPtfAsjl sSCW03AmFeZEg99FLrAVoz/1n2eWflifqfdJbVKOfVXfgNo+ydYlAlArUd2SjRviNaMB k3PA== X-Forwarded-Encrypted: i=1; AJvYcCXIxb3O8vfri5RWnfvvQ3plrnnrd3NK8PrvDua/luk4DOS2zTe4r1MlGJSPkVcpn36Z7gegL5r9OrQrMQiUcXEUpuZO4DBE7bgqvaylXxoYPhboP8Y= X-Gm-Message-State: AOJu0YxGLxrM+WlEFX+YE33+7Tutf04fzbgpmt4OSy/Xnz5MWwCKIgKZ +1SZbv0ceqpQO9GyOcDIsovXfzRlJ4yXi1i+gUra9cw1bXOdAoFsqN/SYb8tUJ4= X-Google-Smtp-Source: AGHT+IHROwLUTMrWjmP0xh3ZK9H8kROHkOyC9/3gwwdjBZr0Ond0GgOAOqXLU1YQx0oMT2Wjx7S+wA== X-Received: by 2002:a19:5f07:0:b0:51f:3cb3:48a4 with SMTP id 2adb3069b0e04-529646e3b70mr5388521e87.1.1716819974755; Mon, 27 May 2024 07:26:14 -0700 (PDT) Received: from uffe-tuxpro14.. (h-178-174-189-39.A498.priv.bahnhof.se. [178.174.189.39]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-529711fa7f3sm562002e87.258.2024.05.27.07.26.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 May 2024 07:26:14 -0700 (PDT) From: Ulf Hansson To: "Rafael J . Wysocki" , Sudeep Holla , linux-pm@vger.kernel.org Cc: Lorenzo Pieralisi , Nikunj Kela , Prasad Sodagudi , Maulik Shah , Daniel Lezcano , Krzysztof Kozlowski , Ulf Hansson , linux-rt-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 5/7] cpuidle: psci: Drop redundant assignment of CPUIDLE_FLAG_RCU_IDLE Date: Mon, 27 May 2024 16:25:55 +0200 Message-Id: <20240527142557.321610-6-ulf.hansson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240527142557.321610-1-ulf.hansson@linaro.org> References: <20240527142557.321610-1-ulf.hansson@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240527_072616_256376_0F69BA0E X-CRM114-Status: GOOD ( 12.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org When using the hierarchical topology and PSCI OSI-mode we may end up overriding the deepest idle-state's ->enter|enter_s2idle() callbacks, but there is no point to also re-assign the CPUIDLE_FLAG_RCU_IDLE for the idle-state in question, as that has already been set when parsing the states from DT. See init_state_node(). Signed-off-by: Ulf Hansson --- Changes in v2: - None. --- drivers/cpuidle/cpuidle-psci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/cpuidle/cpuidle-psci.c b/drivers/cpuidle/cpuidle-psci.c index 782030a27703..d82a8bc1b194 100644 --- a/drivers/cpuidle/cpuidle-psci.c +++ b/drivers/cpuidle/cpuidle-psci.c @@ -234,7 +234,6 @@ static int psci_dt_cpu_init_topology(struct cpuidle_driver *drv, * of a shared state for the domain, assumes the domain states are all * deeper states. */ - drv->states[state_count - 1].flags |= CPUIDLE_FLAG_RCU_IDLE; drv->states[state_count - 1].enter = psci_enter_domain_idle_state; drv->states[state_count - 1].enter_s2idle = psci_enter_s2idle_domain_idle_state; psci_cpuidle_use_cpuhp = true;