From patchwork Tue May 28 15:14:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastien Laveze X-Patchwork-Id: 13676977 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 14BEBC25B7C for ; Tue, 28 May 2024 15:15:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=pNRKOjErM5+paOw9PJTPzmHQyKpE5SrS+zetpCXSpM8=; b=ktsGstj3V0/1nQ vOGkPBSqVVQdAIzL5IFio5m+5ZoNqRirICifXvxhUINABGR0meFLsqN//E24+WyXXqv2BS/qX2dTY Y98IYVPzERXN99otJyAo+77cbvb16O/83PyYq+Ryhk3rqJzwc56lKeG27M37h+GGKRC5yA2gZbzl0 Xg+FHeUZw7H0MaAOGhyh3IOOl3uNdRZs7hC3dTd/ySSMcPQ2ui8YiZrkM5YF4A7t/cQ3udmS7t1KX qyJJ79T55UQACXvuLPdHQuDI6rpxQ82AYAUlUj+xFt5nYqkJWDZViYsf0sbtTQE5UFyuitQsteKyV JLQYOM28doRnYppcYveQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sByXO-00000001BTV-0evN; Tue, 28 May 2024 15:14:54 +0000 Received: from smtp-42ad.mail.infomaniak.ch ([2001:1600:7:10::42ad]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sByXK-00000001BO9-3nWa for linux-arm-kernel@lists.infradead.org; Tue, 28 May 2024 15:14:53 +0000 Received: from smtp-3-0000.mail.infomaniak.ch (smtp-3-0000.mail.infomaniak.ch [10.4.36.107]) by smtp-4-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4Vpbf94QnDz7nG; Tue, 28 May 2024 17:14:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=smartandconnective.com; s=20191114; t=1716909281; bh=3bUxCMue09hBn28f4SiBpgvkHgQHBTwNx6pE/uKig6Y=; h=From:To:Cc:Subject:Date:From; b=kza+oIZPTVXxTlz1ZM527xyVxTPuxb24dIH12C62NsMEr607xEiPUZK5N/0uLvg2I aY5B53xN9B1qGCLHD06MGeXb0NirMpTrwHbuYeTp32wF4S97bEvcVYeUlN6F7Qi05A X4VdQMGMIkID7DIJjJyyaOzQBH4QaWHt+PShHhc8= Received: from unknown by smtp-3-0000.mail.infomaniak.ch (Postfix) with ESMTPA id 4Vpbf83S5Qzw36; Tue, 28 May 2024 17:14:40 +0200 (CEST) From: Sebastien Laveze To: Abel Vesa , Peng Fan , Michael Turquette , Stephen Boyd , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Oleksij Rempel , Lee Jones Cc: Sebastien Laveze , Abel Vesa , linux-clk@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] clk: imx: imx6ul: fix default parent for enet*_ref_sel Date: Tue, 28 May 2024 17:14:33 +0200 Message-Id: <20240528151434.227602-1-slaveze@smartandconnective.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Infomaniak-Routing: alpha X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240528_081451_394253_48AB3EE4 X-CRM114-Status: GOOD ( 10.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The clk_set_parent for "enet1_ref_sel" and "enet2_ref_sel" are incorrect, therefore the original requirements to have "enet_clk_ref" as output sourced by iMX ENET PLL as a default config is not met. Only "enet[1,2]_ref_125m" "enet[1,2]_ref_pad" are possible parents for "enet1_ref_sel" and "enet2_ref_sel". This was observed as a regression using a custom device tree which was expecting this default config. This can be fixed at the device tree level but having a default config matching the original behavior (before refclock mux) will avoid breaking existing configs. Fixes: 4e197ee880c2 ("clk: imx6ul: add ethernet refclock mux support") Link: https://lore.kernel.org/lkml/20230306020226.GC143566@dragon/T/ Signed-off-by: Sebastien Laveze Reviewed-by: Oleksij Rempel --- drivers/clk/imx/clk-imx6ul.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/imx/clk-imx6ul.c b/drivers/clk/imx/clk-imx6ul.c index f9394e94f69d..05c7a82b751f 100644 --- a/drivers/clk/imx/clk-imx6ul.c +++ b/drivers/clk/imx/clk-imx6ul.c @@ -542,8 +542,8 @@ static void __init imx6ul_clocks_init(struct device_node *ccm_node) clk_set_parent(hws[IMX6UL_CLK_ENFC_SEL]->clk, hws[IMX6UL_CLK_PLL2_PFD2]->clk); - clk_set_parent(hws[IMX6UL_CLK_ENET1_REF_SEL]->clk, hws[IMX6UL_CLK_ENET_REF]->clk); - clk_set_parent(hws[IMX6UL_CLK_ENET2_REF_SEL]->clk, hws[IMX6UL_CLK_ENET2_REF]->clk); + clk_set_parent(hws[IMX6UL_CLK_ENET1_REF_SEL]->clk, hws[IMX6UL_CLK_ENET1_REF_125M]->clk); + clk_set_parent(hws[IMX6UL_CLK_ENET2_REF_SEL]->clk, hws[IMX6UL_CLK_ENET2_REF_125M]->clk); imx_register_uart_clocks(); }