diff mbox series

[2/4] dt-bindings: gpio: aspeed,sgpio: Specify gpio-line-names

Message ID 20240529-dt-warnings-gpio-sgpio-interrupt-cells-v1-2-91c42976833b@codeconstruct.com.au (mailing list archive)
State New, archived
Headers show
Series dt-bindings: gpio: aspeed,sgpio: Miscellaneous cleanups | expand

Commit Message

Andrew Jeffery May 29, 2024, 5:13 a.m. UTC
Some devicetrees specify gpio-line-names in the sgpio node despite it
not being defined by the binding. It's a reasonable thing to do, so
define the property to squash warnings such as:

```
arch/arm/boot/dts/aspeed/aspeed-bmc-vegman-rx20.dtb: sgpio@1e780200: 'gpio-line-names' does not match any of the regexes: 'pinctrl-[0-9]+'
```

Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>
---
 Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Krzysztof Kozlowski May 29, 2024, 7:27 a.m. UTC | #1
On 29/05/2024 07:13, Andrew Jeffery wrote:
> Some devicetrees specify gpio-line-names in the sgpio node despite it
> not being defined by the binding. It's a reasonable thing to do, so
> define the property to squash warnings such as:
> 
> ```

No need for ```

This is just commit log. Not markdown.


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof
Andrew Jeffery May 30, 2024, 12:51 a.m. UTC | #2
On Wed, 2024-05-29 at 09:27 +0200, Krzysztof Kozlowski wrote:
> On 29/05/2024 07:13, Andrew Jeffery wrote:
> > Some devicetrees specify gpio-line-names in the sgpio node despite it
> > not being defined by the binding. It's a reasonable thing to do, so
> > define the property to squash warnings such as:
> > 
> > ```
> 
> No need for ```
> 
> This is just commit log. Not markdown.

I'm going to do a v2 anyway, so I'll drop the markup.

> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Thanks,

Andrew
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml b/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml
index 6b15a3a3fb66..fe27b5d01e80 100644
--- a/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml
+++ b/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml
@@ -33,6 +33,11 @@  properties:
 
   gpio-controller: true
 
+  # Each SGPIO is represented as a pair of input and output GPIOs
+  gpio-line-names:
+    minItems: 160
+    maxItems: 256
+
   '#gpio-cells':
     const: 2