From patchwork Thu May 30 15:10:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 13680539 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F404AC27C43 for ; Thu, 30 May 2024 15:12:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=f+U4jF7lhUVAgnKvKHFLBVy66SRXs2hbrSs0VsPIeUA=; b=arEDKMQ360s/UQ yReJqUKQYd+qY3iIC73TpcxdC2OmC+Lgsy4JZNBEtS8vqbYb01X6nTj/HhGqnpdXkN/oOQ7fKTBAc H6yGeIHsTYwuh/3L1g6WuvxX6zdSvVbdkXrQGsFtTpe4Gnv5vABeWH6qcJLN8mxLOAd5FSBjrDRWa RYU712vd1Cre4rnr3Ya4gjY5MdyG5x57uqnEHzjEqrko40PJVJ/Xu899/KsBM+NoAv1t0Kv2QUhxV 0w1/weitSefXv8OWA9dTjSGgFEkr//q3+ecIGzXzsK7xcvZzwd3eszgYdg8NcNhe3FF+YQSGCYBEn 86I0+4G1aWf/7zz46LgQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sChRp-00000007fH5-0W3S; Thu, 30 May 2024 15:12:09 +0000 Received: from mgamail.intel.com ([198.175.65.10]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sChRE-00000007enA-1yaF for linux-arm-kernel@lists.infradead.org; Thu, 30 May 2024 15:11:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1717081892; x=1748617892; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=KHmkxGTrimggz5XiV2P+I49lCexUOiH4Nb0XpNE5VMs=; b=LVAXYQo6Yjo2U4A9OnfifagR2QpOTNLidBPrkcZDKj2WpJ3jPQXCyu41 eMHAgtWCRr9LIpvIRTouhgvGLdTrMXlHD0rFRsDD9JfF7nNy6gd47l8YL +F6EM+4kiuk5AjpyW5fVMfiJRjJNBa3MZa37UR/G2qDIHtgThf9o8f7hg z81RHWprcWAELBLZOpbiLXwmWZ/tYyMykhcZNkCRtnNbM3L4G58yIIZtj 7vEPG9WNDdNANQ9CBOVjgUj6CRRJZPZ9bTklo9L1kbE9hElrIwR/16dhn xksh8yzJ5kZ9/tbHizkGGSKBTwfm0D6aMbtJO/cIC8tIgMOH+zAlwEN7l Q==; X-CSE-ConnectionGUID: jOLpiQgKRkKRM6mJ7IK2kg== X-CSE-MsgGUID: SQoIH6jySO+LOvdFbIbQxQ== X-IronPort-AV: E=McAfee;i="6600,9927,11088"; a="31067962" X-IronPort-AV: E=Sophos;i="6.08,201,1712646000"; d="scan'208";a="31067962" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 May 2024 08:11:25 -0700 X-CSE-ConnectionGUID: ZmLvxdsRRH2XteUsnIoQpw== X-CSE-MsgGUID: t+vO54S1RdSW0kg0YoLNBg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,201,1712646000"; d="scan'208";a="73329439" Received: from black.fi.intel.com ([10.237.72.28]) by orviesa001.jf.intel.com with ESMTP; 30 May 2024 08:11:24 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 68409679; Thu, 30 May 2024 18:11:19 +0300 (EEST) From: Andy Shevchenko To: Mark Brown , Andy Shevchenko , Linus Walleij , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Daniel Mack , Haojian Zhuang , Robert Jarzmik Subject: [PATCH v2 07/11] spi: pxa2xx: Remove duplicate check Date: Thu, 30 May 2024 18:10:03 +0300 Message-ID: <20240530151117.1130792-8-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1336.g36b5255a03ac In-Reply-To: <20240530151117.1130792-1-andriy.shevchenko@linux.intel.com> References: <20240530151117.1130792-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240530_081132_746493_D6D8D6B3 X-CRM114-Status: GOOD ( 10.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The mmio_base can't be NULL at this point. It's either checked in both pxa_ssp_probe() and pxa2xx_spi_init_ssp() or correctly provided by PCI core. Hence, remove duplicate check which is a dead code. Signed-off-by: Andy Shevchenko --- drivers/spi/spi-pxa2xx.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c index 30a829b74a22..9724d9455837 100644 --- a/drivers/spi/spi-pxa2xx.c +++ b/drivers/spi/spi-pxa2xx.c @@ -1441,9 +1441,6 @@ static int pxa2xx_spi_probe(struct platform_device *pdev) if (!ssp) ssp = &platform_info->ssp; - if (!ssp->mmio_base) - return dev_err_probe(dev, -ENODEV, "failed to get SSP\n"); - if (platform_info->is_target) controller = devm_spi_alloc_target(dev, sizeof(*drv_data)); else