From patchwork Fri May 31 05:57:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adrian Hunter X-Patchwork-Id: 13681152 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C18D7C25B7E for ; Fri, 31 May 2024 05:58:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cwzOXWp/hJQUnYM4GXonanaCk6SKhxe2E1/r3ssaeuE=; b=qIigAaGAmjN+hM /K7S26ebJNfsBDi9Wnliq9CMAdIu1/5Bm/G64OpmUFuBI7xAFff4Sm3N1cg77PWkGF3ZeobTcGspc FWZT9yuaT/bISSI4K5g9NsrIIKw76+lyPMeg8UBBMG7DRPDrC6bB9kk6GBk55BngRhnWo/JVkv9uq 3ocu8C6o3FnHuYnLM6ISXjfuRbcaOW9SsbabBQFXRM0/+m/jQRal0LCM2Cw37ZCuV9DMQ6V2O3CtY W7gFyLZ/8WjPQ53yhXVOo8IL+YfUosRHWGwjxRSxWVPikMjBcN3YQQQlVPbnKJVF0wsYXY+KgDXWH xhbF6n+G4XayMjy5pxSA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCvHn-00000009K5i-3InN; Fri, 31 May 2024 05:58:43 +0000 Received: from mgamail.intel.com ([192.198.163.10]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCvHU-00000009Js5-16ls for linux-arm-kernel@lists.infradead.org; Fri, 31 May 2024 05:58:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1717135104; x=1748671104; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=LmPWJzCWmr0I0R2LelK/lC4wn9pT0+3isQy4N3tK83A=; b=g4lj1bXUDBFKOY/gdn8QpJyoJ6jRvfYwz1I/k4klOcY77pep3DR8BuqT sCagF41CNaxit1/aUDBXc/YebM+oP34CaEX/Mz7Vo5y6Yv5Lr8HfTm/BZ S83PxNLbaDq4OJotQ6CbuWkyYRpstt6gSNy1msySeD7gJpGoG61M7kQaF 3uGjguzZWazghs2GEbTCQ7u0NoT1TX3xeUP0cNopGZsvKaMFZJAEfVXvU tJhkRm0GN4Za7kl6SxuOqODJhhmmxOC6i4Fvxo/wGUrPvdNxegmfqU7+o cXHeHm8wHqql08hZT1YBiFoHx+aLvVpG84KVFZOFyajZGTgJXFai614Zs A==; X-CSE-ConnectionGUID: W3ZjIzMzShm0st/i/hpxUA== X-CSE-MsgGUID: 8x5IjQQPSYWhDsn4STqOWA== X-IronPort-AV: E=McAfee;i="6600,9927,11088"; a="25068203" X-IronPort-AV: E=Sophos;i="6.08,203,1712646000"; d="scan'208";a="25068203" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 May 2024 22:58:17 -0700 X-CSE-ConnectionGUID: o3bProXRR42dZilBbtgckQ== X-CSE-MsgGUID: PMmNtjt5Q0WlXuWvW2QoQw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,203,1712646000"; d="scan'208";a="40510920" Received: from ahunter6-mobl1.ger.corp.intel.com (HELO localhost.localdomain) ([10.246.41.28]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 May 2024 22:58:13 -0700 From: Adrian Hunter To: Peter Zijlstra Cc: Ingo Molnar , Mark Rutland , Alexander Shishkin , Heiko Carstens , Thomas Richter , Hendrik Brueckner , Suzuki K Poulose , Mike Leach , James Clark , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, Yicong Yang , Jonathan Cameron , Will Deacon , Arnaldo Carvalho de Melo , Jiri Olsa , Namhyung Kim , Ian Rogers , Andi Kleen , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Subject: [PATCH V7 05/12] perf tools: Enable evsel__is_aux_event() to work for S390_CPUMSF Date: Fri, 31 May 2024 08:57:24 +0300 Message-Id: <20240531055731.12541-6-adrian.hunter@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240531055731.12541-1-adrian.hunter@intel.com> References: <20240531055731.12541-1-adrian.hunter@intel.com> MIME-Version: 1.0 Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240530_225824_584228_2AB20B25 X-CRM114-Status: GOOD ( 14.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org evsel__is_aux_event() identifies AUX area tracing selected events. S390_CPUMSF uses a raw event type (PERF_TYPE_RAW - refer s390_cpumsf_evsel_is_auxtrace()) not a PMU type value that could be checked in evsel__is_aux_event(). However it sets needs_auxtrace_mmap (refer auxtrace_record__init()), so check that first. Currently, the features that use evsel__is_aux_event() are used only by Intel PT, but that may change in the future. Signed-off-by: Adrian Hunter Acked-by: Ian Rogers Reviewed-by: Andi Kleen --- tools/perf/util/pmu.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c index 888ce9912275..6599599db2b1 100644 --- a/tools/perf/util/pmu.c +++ b/tools/perf/util/pmu.c @@ -1174,8 +1174,12 @@ void perf_pmu__warn_invalid_formats(struct perf_pmu *pmu) bool evsel__is_aux_event(const struct evsel *evsel) { - struct perf_pmu *pmu = evsel__find_pmu(evsel); + struct perf_pmu *pmu; + if (evsel->needs_auxtrace_mmap) + return true; + + pmu = evsel__find_pmu(evsel); return pmu && pmu->auxtrace; }