From patchwork Tue Jun 4 13:59:26 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Walle X-Patchwork-Id: 13685375 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D93A7C25B78 for ; Tue, 4 Jun 2024 14:00:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cVoLhyd8I/NbDtD2XnME7OSkYFntvdIVj4FUaWDwht4=; b=VkCCrlVNyA3rPD V4/AG/rkVvT0JSf0xh/fnI9ooD1h0XhxMqR+HR5ld7+woZa3NwNrTdR6MSOjJ8q6DtzpNMQpUm3Rk AqxamyEm2R72FR7qLouQ39zcFgANnfyzpD8A2+HgXNaLF6KBuuDVFXUKDHvhUtbZOh00UHDKGmnWy Y0WJYM16FvDU2hkqoJAd5ROhT/O45qDut541W+Z3EFG5SFABDWlzoxZ21e+UYmZZ/hIpgMG0+XmBe xc0f21J+eoxkY2e12p0oyZCkUEYHCEwhcnGM05AIc52ysiCnPRSPsam22v/P2gxiJU56inOSxhTEI k0sJix+mlVyEMsRVj7tg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sEUhj-00000002b00-3imx; Tue, 04 Jun 2024 13:59:59 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sEUhg-00000002ay0-41e0 for linux-arm-kernel@lists.infradead.org; Tue, 04 Jun 2024 13:59:58 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id CD20D61309; Tue, 4 Jun 2024 13:59:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A02AAC2BBFC; Tue, 4 Jun 2024 13:59:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717509595; bh=2Qw+7Rve50c6UoNrfytgIz8RzG/OQfuJ1xjLwlqspyo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WeRH4UBAp34KH9bLuOJCjmEiebZzChPZgnBRhtxkGe1K2BtDSFHntaN0fdjrck//a LQfoTbvTonNz/oyzjZErxU5vPzzzDMlBQ+7dwQYR0FDBK43OW7BjjEoq0Cs6lenjz8 zum7bSsdyk6LZQWM+oN81iUovvg4KRS3Y69Zaxouhpjh0SM9ubntBo9sqvsA3Yre7r NaPRubsW8VmWRvXv0/BIoj4LL4VAHbSYVg0ZjnrQyaaZG62UOTibh7CvySxJMMFN+m Uu/9rUUZKAbLEt2Aie9NLxmkEXUdgYn6fruLW1jhnIr0aWK0LJHyIhY5cVWiLVCajC aHHcnIbhjJ2uA== From: Michael Walle To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Li Yang Cc: Pengutronix Kernel Team , Fabio Estevam , Priit Laes , Michael Grzeschik , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Michael Walle Subject: [PATCH 02/10] ARM: dts: imx6qdl-kontron-samx6i: fix PHY reset Date: Tue, 4 Jun 2024 15:59:26 +0200 Message-Id: <20240604135934.1951189-3-mwalle@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240604135934.1951189-1-mwalle@kernel.org> References: <20240604135934.1951189-1-mwalle@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240604_065957_167634_06E1FA4C X-CRM114-Status: GOOD ( 12.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The PHY reset line is connected to both the SoC (GPIO1_25) and the CPLD. We must not use the GPIO1_25 as it will drive against the output buffer of the CPLD. Instead there is another GPIO (GPIO2_01), an input to the CPLD, which will tell the CPLD to assert the PHY reset line. Fixes: 2a51f9dae13d ("ARM: dts: imx6qdl-kontron-samx6i: Add iMX6-based Kontron SMARC-sAMX6i module") Fixes: 5694eed98cca ("ARM: dts: imx6qdl-kontron-samx6i: move phy reset into phy-node") Signed-off-by: Michael Walle --- arch/arm/boot/dts/nxp/imx/imx6qdl-kontron-samx6i.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-kontron-samx6i.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-kontron-samx6i.dtsi index d8c1dfb8c9ab..d6c049b9a9c6 100644 --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-kontron-samx6i.dtsi +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-kontron-samx6i.dtsi @@ -269,7 +269,7 @@ mdio { ethphy: ethernet-phy@1 { compatible = "ethernet-phy-ieee802.3-c22"; reg = <1>; - reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>; + reset-gpios = <&gpio2 1 GPIO_ACTIVE_LOW>; reset-assert-us = <1000>; }; }; @@ -516,7 +516,7 @@ MX6QDL_PAD_RGMII_RX_CTL__RGMII_RX_CTL 0x1b0b0 MX6QDL_PAD_ENET_MDIO__ENET_MDIO 0x1b0b0 MX6QDL_PAD_ENET_MDC__ENET_MDC 0x1b0b0 MX6QDL_PAD_ENET_REF_CLK__ENET_TX_CLK 0x1b0b0 - MX6QDL_PAD_ENET_CRS_DV__GPIO1_IO25 0x1b0b0 /* RST_GBE0_PHY# */ + MX6QDL_PAD_NANDF_D1__GPIO2_IO01 0x1b0b0 /* RST_GBE0_PHY# */ >; };