From patchwork Mon Jun 10 21:02:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 13692439 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9E235C27C55 for ; Mon, 10 Jun 2024 21:03:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=barTC5KN5RSVR1NWgcKvjkkOPME6kX/0ApVwtqURd/k=; b=oCPuibM/focIuv sAiDAELLusWufVxGvjbnMnD/JxclUd55krxlXZj1Gm+ZDA5bcNcOe4cCvxIDpn2gwdkfyYScHSr3y yW+aAUJviz97G0yPx9348FH7zt2w6pBzIq/Rq4DdpJhpxEOLYMP/DrJ8c+uiOSKdPRvOVBhCPZrGo HxfkD+63pbUidImTiefY8lkxOmpZwE1wwEpvvvg/zI8hokMAW/q3U2F7mxapaa64bzjbxOsJd5Pe6 kKA1gYq0OGO/B6X/2dz5gAIgznwvt0qzqN0NwU5KoBS5QkjpH/CRfJBsSD9GqEHsX8Clzj1vSSd2x O+qZMM7G3GmSGni/ZgGg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sGmAZ-00000006U3V-1BqS; Mon, 10 Jun 2024 21:03:11 +0000 Received: from mout.gmx.net ([212.227.15.19]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sGmAB-00000006Tm1-1orc for linux-arm-kernel@lists.infradead.org; Mon, 10 Jun 2024 21:02:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1718053362; x=1718658162; i=wahrenst@gmx.net; bh=7q8HbYwAcDjZpLq+HqBScyCmUIe2XBV25YY5hn+VnG8=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:Message-Id:In-Reply-To: References:MIME-Version:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=X5R+Vy5lapZtjRaSGR5b2g+jinJqSQPaAR1T+s6syYhWYR/+GYbeaHs8+zw1CsnW M30AH2OoRNnFwL/TO22PPB6kpSvW8X5dBpj/MrKjFAiz2cljYOJyG4rz6qCXQSTZU LgPJkgijVhr8XG6SDBk8tmvKhIBLFfkQO45kNegnCqQeB1Sz7HqgWoP9hymwEjrX3 2zyqEpKr+AKIgSG07oU1UWJw7ydU3rZwx6IrNep6gFCKnVRfdgajEJYdu97wK7Whz AnVvajWAk886+oSdSIw84pop4nC7Ms7qFaaHH8nwxoarcZc/U1Tp6vFqBK2d5cmf8 js7bWMo2qIxB3PaKdw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from stefanw-SCHENKER ([37.4.248.43]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MNbkv-1s4tNR0lVT-00QoBh; Mon, 10 Jun 2024 23:02:42 +0200 From: Stefan Wahren To: Greg Kroah-Hartman , Florian Fainelli Cc: Umang Jain , Laurent Pinchart , linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Stefan Wahren Subject: [PATCH V2 02/10] staging: vchiq_arm: Drop obsolete comment Date: Mon, 10 Jun 2024 23:02:12 +0200 Message-Id: <20240610210220.95524-3-wahrenst@gmx.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240610210220.95524-1-wahrenst@gmx.net> References: <20240610210220.95524-1-wahrenst@gmx.net> MIME-Version: 1.0 X-Provags-ID: V03:K1:UTKrEXKfXQdb+d12EIblwVKA1mOfnQqcLQ9KzwvViAZX7QkUt4j QZ1s295lswb0oTEeWnmekhwv7SpWcYEL1hnbxiIHVUx//u2XMbNpYgswx9QhXJ3hhA9herq AVkn1JXMESRu1nWQcrc9a0XYy7JjQBA2MXihP62KJE6tiDb49pEggbxe2BdpL5eNcmmFct9 3eBfqqssrBBBLF+5O21EQ== UI-OutboundReport: notjunk:1;M01:P0:uIJb8c2uGqE=;6cOpXyrOb4YDWL8nPvXqrU1RCr5 VV5ZeuUU4Dpg4IHBf0n43O9je9qERsb3abZtEFdzI2cjDsmo+YHeFCQhQkeh5lss+eZg7qrKb 0l2WkTv8t4lu0UwG4RIV5NN5ehNje5qEMIXWDJcGmaOxnOd/n7HE2GhBktp7i0qt1v9pyrkUx WzGlXu4aqZ+Hjq1c23nxWmfY5s6DmPR0f9oTN8Brx8ykUgo0J+oMy0tmgoM6+9IGtS8evWADZ NRlJ7zkhqJX0GWIXiIMJyj3ZG6DBgCwzoEuvyrLv1TqTgmWSz3hNwrqZv3YipC1PsUrWC0EdU APhJLcXsNVYMBZCgUa0OQh5BoR0zC5CP2Ahm9c9GHJmjlKLoJGZ4Uur83q0if7ii0DQB70cGD kK7qUwGHMsA9h+lSRQF/Ziw691YisbpOsfXuqwS6ZdrOIDQeOkkOG9fWL54+Sd5mvw4PTjdI8 o1RBciaSKRdag4MO/459OsQvXeg6oNdxx8LQEl3kVvR5rv6jKDhe7ycAtwJXwL6FGNMwue2yZ 1HeI9qR4N7YyD0na3GC2Y92wtQYT1s3XKRk2r5ttxvTURXluvpPrT25xmxcEskU4rNymVl9sZ /n4y58HBB3H//H93IrTKR0YqRQoB82ah49LjQLHWSMtuls4o0n5wlQ+X7EQJDzNAT8TyzTn2c UKoP1ZbLqhsx8gmPgTE5vpt1j7pvSA62x64XTWu4LKcideBFJ0J4u1pwrpTyVzXw2W+6Pq4bm ELfdtpqVpyt13+GtvsCk84nSDVyqC1VhSWUx89Fe5x93z0zTbsesjqWQJnQCbff9BvnCo3dYY XPOo+RxjYOSEmttlrYB/axCMGdDxD8Ia249ojuhZXz2Bc= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240610_140248_280129_F345ED9F X-CRM114-Status: UNSURE ( 9.55 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The BUG_ON has been replaced with WARN_ON. So we can drop the comment. Signed-off-by: Stefan Wahren Reviewed-by: Laurent Pinchart --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 1 - 1 file changed, 1 deletion(-) -- 2.34.1 diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c index f3815101e1c4..094ba1aea8f6 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c @@ -1448,7 +1448,6 @@ vchiq_release_internal(struct vchiq_state *state, struct vchiq_service *service) write_lock_bh(&arm_state->susp_res_lock); if (!arm_state->videocore_use_count || !(*entity_uc)) { - /* Don't use BUG_ON - don't allow user thread to crash kernel */ WARN_ON(!arm_state->videocore_use_count); WARN_ON(!(*entity_uc)); ret = -EINVAL;