From patchwork Mon Jun 10 21:02:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 13692440 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9A654C27C55 for ; Mon, 10 Jun 2024 21:03:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AoXon8kuDRu/ULZCo4tPCTY+HHY0kKB9XijO//2kRmI=; b=Wuf7VUPpG/CsTR NjXpQa+r9Lwklem+8Lp76uEQ+wLIM3DYmOs2NyWtOZwhQ2+2pt4Hjo9XGT35pLDHhDyKlYcqcE7ri 1S3TcTa0OT8ccC6bUIPhnShJhhmEszTB8u9Y0YYCimzNoZ3TtSatMC962ZWHDcwPnNHewk3RWkJwd No9TTJqfO/NvlHLWYTZEXQA/Rf7dKueDVfu2MlcdN+YgqNjHPfO6dsH/YDjCx6LXrhroTv/bxPqVN IaSOHOHbFph4fDoxWf9q2F80MaIoSPQHM0QSGPcbm+vFOu1TkpEf9dZyBdagkuBMmCcYGXmey+pxc q1PrVoTmxNz/DYbWQXyg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sGmAd-00000006U6p-3L8N; Mon, 10 Jun 2024 21:03:17 +0000 Received: from mout.gmx.net ([212.227.15.19]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sGmAB-00000006TmG-1oju for linux-arm-kernel@lists.infradead.org; Mon, 10 Jun 2024 21:02:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1718053362; x=1718658162; i=wahrenst@gmx.net; bh=7VFCSssTtDO9xPluI9MgXHm4u5tAO4VmwCyLKgp0fVg=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:Message-Id:In-Reply-To: References:MIME-Version:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=okinB0J6qTxtzLlAWf6hBGZg6WBLQ8V2aWnnObjLSLoSfafaI4+V7t4679rdpiSr GMrc20M028YLgQqicy4NGG3dPaU53043saTGhm31Qp8Nlkg3zhT/NkGeHboGx6CRI UBKqnDA23eUwCmiVfqOBuLEQGMjTc0YWUmElQJXeOZqyO7Ooz5gfR0XD9eaTpbfft h5UAlcWtf19O7/IG5z7LHgg1y4yD6LgbclyjNAIgzTJJoLn5B2jk78Tv8UUOH0WWb tw9r9nI1TZwUS12OlO1inN7C0mfOLQEJ+SqujSngKGuv1Kc30KzXtylfq4RzsBd2f To+Iu0TzS+ewUxRbzQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from stefanw-SCHENKER ([37.4.248.43]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MF3He-1sEYA628PQ-000a4c; Mon, 10 Jun 2024 23:02:42 +0200 From: Stefan Wahren To: Greg Kroah-Hartman , Florian Fainelli Cc: Umang Jain , Laurent Pinchart , linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Stefan Wahren Subject: [PATCH V2 03/10] staging: vchiq_core: Drop non-functional struct members Date: Mon, 10 Jun 2024 23:02:13 +0200 Message-Id: <20240610210220.95524-4-wahrenst@gmx.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240610210220.95524-1-wahrenst@gmx.net> References: <20240610210220.95524-1-wahrenst@gmx.net> MIME-Version: 1.0 X-Provags-ID: V03:K1:gw7OvOhS4diir/o5m0oPbmDYNpBA4Iajuo+XcZ6xPzqpcZ9EZT5 p6LyaqMoYHR+oY7VbxzyiXCVL861HOgHHSVqvBTwQ/MoEJZ9+PNdOypJ2UAGsRWaWTx0tRO 9yA81mhI9gMAbQAijKBvrP+/u7qzYz+WVnzcUcjxHl/9gi6pFIsBKIW78+nUDp1uixphQzB uJKV0qfeaxwb/c5imFPow== UI-OutboundReport: notjunk:1;M01:P0:Spd8uZmX7HQ=;WomSKYpAWGv1dxvXf3x7L4roMBu Z4Ynk+Eiw7Pwc5AcIMnvq2hcCdAjjs9VXrsKnxXgwZwHS8CDEOqQ5SGHvH+n0Zjy1yTUhHxmo C9JmdfrywZCpB0e0DZEv6TWMznmgK/3z2+ScWW6038euYEDDBgqCdUfO68vQ56qw42SuOD5Md oyc6sr0kvZbcWBLGXcb9JptAEQwwuW+wSf8PnP91Q61orTY5YqFZ1/WQwrqX9F2KV+8ocoPp/ ceYvGBY8xNXFUuzI3pEkIORSUYDwSHFk7TRmRZshOEFnQKbg3ZEa3g7cwNNBvlkS3kfUFNlXK F05w9bYNMhYJtekxtcnl7fLmRRephyoM7Uh1b6MrYZrBX/rgZknMl7ohkl9OeJ1EldxPEeKuR 7O5aLI/lpSDXZvfRBG6GcNymA4g9xqOGqE2Nr0G+A0Vm0kIzYupgjpBTVtB5hQl7w6sa0F8IN xp8dqzb72tc00gNqQ8yDnXHklX45wTta0GSXRXMoevGrajWLpujI/UVXVV2zE0JlxBBh1WaQI B8ia/1r2vzqa4X0BLAJgFTgO2q/Y6OhfOmMWVxpQ7MCEVzWn2Yj+QEMyJMlewWlWluif70tzM RauN9cifSRB3Tj6wqZEXM467H8efXgF0QFr350dfgkpbIZaNITaV66/hVJdRQG2tmo0dOs0sz vc/ibTVJDCLzhINN0+kD7bugQ/fm0bsDY1R7csflMHZBCUJEihA9AgOodTt/oY6iFFQfw7obF HvXikGeKsy+6sn8zMZE5vZx58aPTil7nSOF3vV6ZY7fLHGsqNtaSSj6MkbZGHT/6UzFeGnRJ4 7CUzggz98HHFlBqjVVZVzgtbI14VyVN+ElyYQ1O+DEEOg= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240610_140248_299320_2D1DB695 X-CRM114-Status: GOOD ( 10.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org There are some struct members, which don't have a real function. So it's safe to drop them. Signed-off-by: Stefan Wahren Reviewed-by: Laurent Pinchart --- .../staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 2 -- .../staging/vc04_services/interface/vchiq_arm/vchiq_core.h | 4 ---- 2 files changed, 6 deletions(-) -- 2.34.1 diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c index df3af821f218..51cfc366519b 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c @@ -2163,14 +2163,12 @@ vchiq_init_state(struct vchiq_state *state, struct vchiq_slot_zero *slot_zero, s mutex_init(&state->slot_mutex); mutex_init(&state->recycle_mutex); mutex_init(&state->sync_mutex); - mutex_init(&state->bulk_transfer_mutex); spin_lock_init(&state->msg_queue_spinlock); spin_lock_init(&state->bulk_waiter_spinlock); spin_lock_init(&state->quota_spinlock); init_completion(&state->slot_available_event); - init_completion(&state->slot_remove_event); init_completion(&state->data_quota_event); state->slot_queue_available = 0; diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h index 8af209e34fb2..be20abcfad75 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h @@ -347,8 +347,6 @@ struct vchiq_state { struct mutex sync_mutex; - struct mutex bulk_transfer_mutex; - spinlock_t msg_queue_spinlock; spinlock_t bulk_waiter_spinlock; @@ -393,8 +391,6 @@ struct vchiq_state { /* Signalled when a free slot becomes available. */ struct completion slot_available_event; - struct completion slot_remove_event; - /* Signalled when a free data slot becomes available. */ struct completion data_quota_event;