| Message ID | 20240616094030.239860-1-youwan@nfschina.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | ACPI /amba: Fix meaningless code for amba_register_dummy_clk() | expand |
diff --git a/drivers/acpi/arm64/amba.c b/drivers/acpi/arm64/amba.c index 60be8ee1dbdc..ef438417cc80 100644 --- a/drivers/acpi/arm64/amba.c +++ b/drivers/acpi/arm64/amba.c @@ -35,11 +35,7 @@ static const struct acpi_device_id amba_id_list[] = { static void amba_register_dummy_clk(void) { - static struct clk *amba_dummy_clk; - - /* If clock already registered */ - if (amba_dummy_clk) - return; + struct clk *amba_dummy_clk; amba_dummy_clk = clk_register_fixed_rate(NULL, "apb_pclk", NULL, 0, 0); clk_register_clkdev(amba_dummy_clk, "apb_pclk", NULL);
Defining `amba_dummy_clk` as static is meaningless. Theconditional check `if (amba_dummy_clk)` is intended to determine whether the clock has already been registered. However,in this function, the variable `amba_dummy_clk` will always be NULL. Signed-off-by: Youwan Wang <youwan@nfschina.com> --- drivers/acpi/arm64/amba.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)