| Message ID | 20240618003743.2975-7-semen.protsenko@linaro.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | hwrng: exynos: Add support for Exynos850 | expand |
On 18/06/2024 02:37, Sam Protsenko wrote: > Add Exynos850 compatible and its driver data. It's only possible to > access TRNG block via SMC calls in Exynos850, so specify that fact using > QUIRK_SMC in the driver data. > > Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> > --- > drivers/char/hw_random/exynos-trng.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/char/hw_random/exynos-trng.c b/drivers/char/hw_random/exynos-trng.c > index 98b7a8ebb909..3368a08df9ce 100644 > --- a/drivers/char/hw_random/exynos-trng.c > +++ b/drivers/char/hw_random/exynos-trng.c > @@ -333,6 +333,9 @@ static DEFINE_SIMPLE_DEV_PM_OPS(exynos_trng_pm_ops, exynos_trng_suspend, > static const struct of_device_id exynos_trng_dt_match[] = { > { > .compatible = "samsung,exynos5250-trng", > + }, { > + .compatible = "samsung,exynos850-trng", > + .data = (void *)QUIRK_SMC, Probably this (and in previous patch) should be called flags, not quirks. Quirks are for work-arounds. Best regards, Krzysztof
On Tue, Jun 18, 2024 at 1:39 AM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On 18/06/2024 02:37, Sam Protsenko wrote: > > Add Exynos850 compatible and its driver data. It's only possible to > > access TRNG block via SMC calls in Exynos850, so specify that fact using > > QUIRK_SMC in the driver data. > > > > Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> > > --- > > drivers/char/hw_random/exynos-trng.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/char/hw_random/exynos-trng.c b/drivers/char/hw_random/exynos-trng.c > > index 98b7a8ebb909..3368a08df9ce 100644 > > --- a/drivers/char/hw_random/exynos-trng.c > > +++ b/drivers/char/hw_random/exynos-trng.c > > @@ -333,6 +333,9 @@ static DEFINE_SIMPLE_DEV_PM_OPS(exynos_trng_pm_ops, exynos_trng_suspend, > > static const struct of_device_id exynos_trng_dt_match[] = { > > { > > .compatible = "samsung,exynos5250-trng", > > + }, { > > + .compatible = "samsung,exynos850-trng", > > + .data = (void *)QUIRK_SMC, > > Probably this (and in previous patch) should be called flags, not > quirks. Quirks are for work-arounds. > Thanks for the quick review! Will submit v2 soon with all the comments addressed. > Best regards, > Krzysztof >
diff --git a/drivers/char/hw_random/exynos-trng.c b/drivers/char/hw_random/exynos-trng.c index 98b7a8ebb909..3368a08df9ce 100644 --- a/drivers/char/hw_random/exynos-trng.c +++ b/drivers/char/hw_random/exynos-trng.c @@ -333,6 +333,9 @@ static DEFINE_SIMPLE_DEV_PM_OPS(exynos_trng_pm_ops, exynos_trng_suspend, static const struct of_device_id exynos_trng_dt_match[] = { { .compatible = "samsung,exynos5250-trng", + }, { + .compatible = "samsung,exynos850-trng", + .data = (void *)QUIRK_SMC, }, { }, };
Add Exynos850 compatible and its driver data. It's only possible to access TRNG block via SMC calls in Exynos850, so specify that fact using QUIRK_SMC in the driver data. Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> --- drivers/char/hw_random/exynos-trng.c | 3 +++ 1 file changed, 3 insertions(+)