| Message ID | 20240619-icc_bw_voting_from_ethqos-v1-1-6112948b825e@quicinc.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add interconnect support for qcom_ethqos driver. | expand |
On Wed, Jun 19, 2024 at 03:41:29PM -0700, Sagar Cheluvegowda wrote: > Add interconnect support in qcom-ethqos driver to vote for bus > bandwidth based on the current speed of the driver. > This change adds support for two different paths - one from ethernet > to DDR and the other from Apps to ethernet. What do you mean by Apps? > Vote from each interconnect client is aggregated and the on-chip > interconnect hardware is configured to the most appropriate > bandwidth profile. > > Signed-off-by: Sagar Cheluvegowda <quic_scheluve@quicinc.com> > --- > .../net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > index e254b21fdb59..682e68f37dbd 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > @@ -7,6 +7,7 @@ > #include <linux/platform_device.h> > #include <linux/phy.h> > #include <linux/phy/phy.h> > +#include <linux/interconnect.h> If you look at these includes, you should notice they are alphabetical. > +static void ethqos_set_icc_bw(struct qcom_ethqos *ethqos, unsigned int speed) > +{ > + icc_set_bw(ethqos->axi_icc_path, Mbps_to_icc(speed), Mbps_to_icc(speed)); > + icc_set_bw(ethqos->ahb_icc_path, Mbps_to_icc(speed), Mbps_to_icc(speed)); > +} > + > static void ethqos_fix_mac_speed(void *priv, unsigned int speed, unsigned int mode) > { > struct qcom_ethqos *ethqos = priv; > > ethqos->speed = speed; > ethqos_update_link_clk(ethqos, speed); > + ethqos_set_icc_bw(ethqos, speed); > ethqos_configure(ethqos); > } > > @@ -813,6 +824,14 @@ static int qcom_ethqos_probe(struct platform_device *pdev) > return dev_err_probe(dev, PTR_ERR(ethqos->link_clk), > "Failed to get link_clk\n"); > > + ethqos->axi_icc_path = devm_of_icc_get(dev, "axi_icc_path"); > + if (IS_ERR(ethqos->axi_icc_path)) > + return PTR_ERR(ethqos->axi_icc_path); > + > + ethqos->ahb_icc_path = devm_of_icc_get(dev, "ahb_icc_path"); > + if (IS_ERR(ethqos->axi_icc_path)) > + return PTR_ERR(ethqos->axi_icc_path); > + This all looks pretty generic. Any reason why this is just in the Qualcomm device, and not at a higher level so it could be used for all stmmac devices if the needed properties are found in DT? Andrew
On 20/06/2024 00:41, Sagar Cheluvegowda wrote: > > @@ -813,6 +824,14 @@ static int qcom_ethqos_probe(struct platform_device *pdev) > return dev_err_probe(dev, PTR_ERR(ethqos->link_clk), > "Failed to get link_clk\n"); > > + ethqos->axi_icc_path = devm_of_icc_get(dev, "axi_icc_path"); Order your patches correctly. Bindings always go before users. Best regards, Krzysztof
On 6/19/2024 4:13 PM, Andrew Lunn wrote: > On Wed, Jun 19, 2024 at 03:41:29PM -0700, Sagar Cheluvegowda wrote: >> Add interconnect support in qcom-ethqos driver to vote for bus >> bandwidth based on the current speed of the driver. >> This change adds support for two different paths - one from ethernet >> to DDR and the other from Apps to ethernet. > > What do you mean by Apps? > Apps means application processor. >> Vote from each interconnect client is aggregated and the on-chip >> interconnect hardware is configured to the most appropriate >> bandwidth profile. >> >> Signed-off-by: Sagar Cheluvegowda <quic_scheluve@quicinc.com> >> --- >> .../net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 19 +++++++++++++++++++ >> 1 file changed, 19 insertions(+) >> >> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c >> index e254b21fdb59..682e68f37dbd 100644 >> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c >> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c >> @@ -7,6 +7,7 @@ >> #include <linux/platform_device.h> >> #include <linux/phy.h> >> #include <linux/phy/phy.h> >> +#include <linux/interconnect.h> > > If you look at these includes, you should notice they are > alphabetical. > Agreed, let me update it in v2 of this series. >> +static void ethqos_set_icc_bw(struct qcom_ethqos *ethqos, unsigned int speed) >> +{ >> + icc_set_bw(ethqos->axi_icc_path, Mbps_to_icc(speed), Mbps_to_icc(speed)); >> + icc_set_bw(ethqos->ahb_icc_path, Mbps_to_icc(speed), Mbps_to_icc(speed)); >> +} >> + >> static void ethqos_fix_mac_speed(void *priv, unsigned int speed, unsigned int mode) >> { >> struct qcom_ethqos *ethqos = priv; >> >> ethqos->speed = speed; >> ethqos_update_link_clk(ethqos, speed); >> + ethqos_set_icc_bw(ethqos, speed); >> ethqos_configure(ethqos); >> } >> >> @@ -813,6 +824,14 @@ static int qcom_ethqos_probe(struct platform_device *pdev) >> return dev_err_probe(dev, PTR_ERR(ethqos->link_clk), >> "Failed to get link_clk\n"); >> >> + ethqos->axi_icc_path = devm_of_icc_get(dev, "axi_icc_path"); >> + if (IS_ERR(ethqos->axi_icc_path)) >> + return PTR_ERR(ethqos->axi_icc_path); >> + >> + ethqos->ahb_icc_path = devm_of_icc_get(dev, "ahb_icc_path"); >> + if (IS_ERR(ethqos->axi_icc_path)) >> + return PTR_ERR(ethqos->axi_icc_path); >> + > > This all looks pretty generic. Any reason why this is just in the > Qualcomm device, and not at a higher level so it could be used for all > stmmac devices if the needed properties are found in DT? > > Andrew ICC is a software framework to access the NOC bus topology of the system, all though "axi" and "ahb" buses seem generic but the topologies of these NOC's are specific to the vendors of synopsys chipset hence this framework might not be applicable to all the vendors of stmmac driver. Sagar
> > This all looks pretty generic. Any reason why this is just in the > > Qualcomm device, and not at a higher level so it could be used for all > > stmmac devices if the needed properties are found in DT? > > > > Andrew > ICC is a software framework to access the NOC bus topology of the > system, all though "axi" and "ahb" buses seem generic but the > topologies of these NOC's are specific to the vendors of synopsys chipset hence > this framework might not be applicable to all the vendors of stmmac driver. There are however a number of SoCs using synopsys IP. Am i right in says they could all make use of this? Do we really want them to one by one copy/paste what you have here to other vendor specific parts of stmmac? This code looks in DT. If there are no properties in DT, it does nothing. So in general it should be safe, right? Andrew
On Fri, Jun 21, 2024 at 10:01:39PM GMT, Andrew Lunn wrote: > > > This all looks pretty generic. Any reason why this is just in the > > > Qualcomm device, and not at a higher level so it could be used for all > > > stmmac devices if the needed properties are found in DT? > > > > > > Andrew > > ICC is a software framework to access the NOC bus topology of the > > system, all though "axi" and "ahb" buses seem generic but the > > topologies of these NOC's are specific to the vendors of synopsys chipset hence > > this framework might not be applicable to all the vendors of stmmac driver. > > There are however a number of SoCs using synopsys IP. Am i right in > says they could all make use of this? Do we really want them to one by > one copy/paste what you have here to other vendor specific parts of > stmmac? > > This code looks in DT. If there are no properties in DT, it does > nothing. So in general it should be safe, right? That logic makes sense to me, and thinking about it more you request a "path" between two "endpoints" in the network, and that's pretty generic. Sort of like the clocks, etc, and then let the provider figure out the gory SoC specific details. i.e., for example I see the UFS driver uses the paths "ufs-ddr" and "cpu-ufs", and thinking about it generically for this IP that's probably the same thing going on here (and lends weight to Krzysztof's request to use names similar to other interconnect users). That being said, grepping around I don't see users outside of platform driver bits (i.e. I was hoping to see drivers/pci/controller/dwc/ doing some shared usage, but that's not the case). Given what you said I'm of the opinion now this should be done in stmmac_platform.c and described for all stmmac users since it feels like a property of the IP itself similar to the clocks required, etc. The interconnect framework handles when they're not described in the dts gracefully so it shouldn't break any other SoCs that don't describe interconnects currently. Thanks, Andrew
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c index e254b21fdb59..682e68f37dbd 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c @@ -7,6 +7,7 @@ #include <linux/platform_device.h> #include <linux/phy.h> #include <linux/phy/phy.h> +#include <linux/interconnect.h> #include "stmmac.h" #include "stmmac_platform.h" @@ -113,6 +114,9 @@ struct qcom_ethqos { unsigned int num_por; bool rgmii_config_loopback_en; bool has_emac_ge_3; + + struct icc_path *axi_icc_path; + struct icc_path *ahb_icc_path; }; static int rgmii_readl(struct qcom_ethqos *ethqos, unsigned int offset) @@ -668,12 +672,19 @@ static int ethqos_configure(struct qcom_ethqos *ethqos) return ethqos->configure_func(ethqos); } +static void ethqos_set_icc_bw(struct qcom_ethqos *ethqos, unsigned int speed) +{ + icc_set_bw(ethqos->axi_icc_path, Mbps_to_icc(speed), Mbps_to_icc(speed)); + icc_set_bw(ethqos->ahb_icc_path, Mbps_to_icc(speed), Mbps_to_icc(speed)); +} + static void ethqos_fix_mac_speed(void *priv, unsigned int speed, unsigned int mode) { struct qcom_ethqos *ethqos = priv; ethqos->speed = speed; ethqos_update_link_clk(ethqos, speed); + ethqos_set_icc_bw(ethqos, speed); ethqos_configure(ethqos); } @@ -813,6 +824,14 @@ static int qcom_ethqos_probe(struct platform_device *pdev) return dev_err_probe(dev, PTR_ERR(ethqos->link_clk), "Failed to get link_clk\n"); + ethqos->axi_icc_path = devm_of_icc_get(dev, "axi_icc_path"); + if (IS_ERR(ethqos->axi_icc_path)) + return PTR_ERR(ethqos->axi_icc_path); + + ethqos->ahb_icc_path = devm_of_icc_get(dev, "ahb_icc_path"); + if (IS_ERR(ethqos->axi_icc_path)) + return PTR_ERR(ethqos->axi_icc_path); + ret = ethqos_clks_config(ethqos, true); if (ret) return ret;
Add interconnect support in qcom-ethqos driver to vote for bus bandwidth based on the current speed of the driver. This change adds support for two different paths - one from ethernet to DDR and the other from Apps to ethernet. Vote from each interconnect client is aggregated and the on-chip interconnect hardware is configured to the most appropriate bandwidth profile. Signed-off-by: Sagar Cheluvegowda <quic_scheluve@quicinc.com> --- .../net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)