diff mbox series

[2/3] ARM: dts: at91: at91-sama7g5ek: add EEPROMs

Message ID 20240619072231.6876-3-andrei.simion@microchip.com (mailing list archive)
State New
Headers show
Series Read MAC address through NVMEM for sama7g5ek | expand

Commit Message

Andrei Simion June 19, 2024, 7:22 a.m. UTC 
From: Claudiu Beznea <claudiu.beznea@microchip.com>

Add EEPROMs and nvmem-layout to describe eui48 mac address region.

Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
Co-developed-by: Andrei Simion <andrei.simion@microchip.com>
Signed-off-by: Andrei Simion <andrei.simion@microchip.com>
---
 .../arm/boot/dts/microchip/at91-sama7g5ek.dts | 44 +++++++++++++++++++
 1 file changed, 44 insertions(+)

Comments

kernel test robot June 20, 2024, 6:28 a.m. UTC | #1 
Hi Andrei,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 0c52056d9f77508cb6d4d68d3fc91c6c08ec71af]

url:    https://github.com/intel-lab-lkp/linux/commits/Andrei-Simion/eeprom-at24-avoid-adjusting-offset-for-24AA025E-48-64/20240619-153030
base:   0c52056d9f77508cb6d4d68d3fc91c6c08ec71af
patch link:    https://lore.kernel.org/r/20240619072231.6876-3-andrei.simion%40microchip.com
patch subject: [PATCH 2/3] ARM: dts: at91: at91-sama7g5ek: add EEPROMs
config: arm-randconfig-004-20240620 (https://download.01.org/0day-ci/archive/20240620/202406201413.tFxSruVt-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240620/202406201413.tFxSruVt-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202406201413.tFxSruVt-lkp@intel.com/

dtcheck warnings: (new ones prefixed by >>)
>> arch/arm/boot/dts/microchip/at91-sama7g5ek.dts:407.22-425.5: Warning (avoid_unnecessary_addr_size): /soc/flexcom@e2818000/i2c@600/eeprom@52: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
   arch/arm/boot/dts/microchip/at91-sama7g5ek.dts:427.22-445.5: Warning (avoid_unnecessary_addr_size): /soc/flexcom@e2818000/i2c@600/eeprom@53: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property

vim +407 arch/arm/boot/dts/microchip/at91-sama7g5ek.dts

   394	
   395	&flx8 {
   396		atmel,flexcom-mode = <ATMEL_FLEXCOM_MODE_TWI>;
   397		status = "okay";
   398	
   399		i2c8: i2c@600 {
   400			pinctrl-names = "default";
   401			pinctrl-0 = <&pinctrl_i2c8_default>;
   402			i2c-analog-filter;
   403			i2c-digital-filter;
   404			i2c-digital-filter-width-ns = <35>;
   405			status = "okay";
   406	
 > 407			eeprom0: eeprom@52 {
   408				compatible = "atmel,24mac02e4";
   409				reg = <0x52>;
   410				#address-cells = <1>;
   411				#size-cells = <1>;
   412				size = <256>;
   413				pagesize = <16>;
   414				vcc-supply = <&vdd_3v3>;
   415	
   416				nvmem-layout {
   417					compatible = "fixed-layout";
   418					#address-cells = <1>;
   419					#size-cells = <1>;
   420	
   421					eeprom0_eui48: eui48@fa {
   422						reg = <0xfa 0x6>;
   423					};
   424				};
   425			};
   426	
   427			eeprom1: eeprom@53 {
   428				compatible = "atmel,24mac02e4";
   429				reg = <0x53>;
   430				#address-cells = <1>;
   431				#size-cells = <1>;
   432				size = <256>;
   433				pagesize = <16>;
   434				vcc-supply = <&vdd_3v3>;
   435	
   436				nvmem-layout {
   437					compatible = "fixed-layout";
   438					#address-cells = <1>;
   439					#size-cells = <1>;
   440	
   441					eeprom1_eui48: eui48@fa {
   442						reg = <0xfa 0x6>;
   443					};
   444				};
   445			};
   446		};
   447	};
   448
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/microchip/at91-sama7g5ek.dts b/arch/arm/boot/dts/microchip/at91-sama7g5ek.dts
index 20b2497657ae..66e8c8258684 100644
--- a/arch/arm/boot/dts/microchip/at91-sama7g5ek.dts
+++ b/arch/arm/boot/dts/microchip/at91-sama7g5ek.dts
@@ -403,6 +403,46 @@  i2c8: i2c@600 {
 		i2c-digital-filter;
 		i2c-digital-filter-width-ns = <35>;
 		status = "okay";
+
+		eeprom0: eeprom@52 {
+			compatible = "atmel,24mac02e4";
+			reg = <0x52>;
+			#address-cells = <1>;
+			#size-cells = <1>;
+			size = <256>;
+			pagesize = <16>;
+			vcc-supply = <&vdd_3v3>;
+
+			nvmem-layout {
+				compatible = "fixed-layout";
+				#address-cells = <1>;
+				#size-cells = <1>;
+
+				eeprom0_eui48: eui48@fa {
+					reg = <0xfa 0x6>;
+				};
+			};
+		};
+
+		eeprom1: eeprom@53 {
+			compatible = "atmel,24mac02e4";
+			reg = <0x53>;
+			#address-cells = <1>;
+			#size-cells = <1>;
+			size = <256>;
+			pagesize = <16>;
+			vcc-supply = <&vdd_3v3>;
+
+			nvmem-layout {
+				compatible = "fixed-layout";
+				#address-cells = <1>;
+				#size-cells = <1>;
+
+				eeprom1_eui48: eui48@fa {
+					reg = <0xfa 0x6>;
+				};
+			};
+		};
 	};
 };
 
@@ -440,6 +480,8 @@  &pinctrl_gmac0_mdio_default
 		     &pinctrl_gmac0_txck_default
 		     &pinctrl_gmac0_phy_irq>;
 	phy-mode = "rgmii-id";
+	nvmem-cells = <&eeprom0_eui48>;
+	nvmem-cell-names = "mac-address";
 	status = "okay";
 
 	ethernet-phy@7 {
@@ -457,6 +499,8 @@  &gmac1 {
 		     &pinctrl_gmac1_mdio_default
 		     &pinctrl_gmac1_phy_irq>;
 	phy-mode = "rmii";
+	nvmem-cells = <&eeprom1_eui48>;
+	nvmem-cell-names = "mac-address";
 	status = "okay"; /* Conflict with pdmc0. */
 
 	ethernet-phy@0 {