From patchwork Thu Jun 20 23:13:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Protsenko X-Patchwork-Id: 13706541 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6C048C2BD09 for ; Thu, 20 Jun 2024 23:14:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Xx9yiqfqGQhoL/OQzBJX0T4MbHx9pH2R2+We+nfV8yc=; b=Gawy3YXc9ICnKsZXkzzevi5hq6 upSqFOn0nQFKgdfFqlolspXLC4hfdwz07zEb6NNJ+DSlIgpMXVW8DZRU0EGr2JHkVw8FBwZh402ER xlsQmne8S05x+61hpm9xL1a+mE/9dLp0SVrpduCG6SsdGZ8Yiisd90dT+p1lnyK8+ZPBHgx8HhUFh 6QpiVbUvJhosjbUe0X/guTpUFeQneXfnv/cqdZm1Fnj9QjLX8AVRZxCWJYqOQHoAlaYhMlBFubA2W zzMObWOTJviJgxkR9S9J0us6ozZCNLPQ96mkiMf0DLlsvEZWrsYR7GOvpHym9ncwbHhPtHShStmYq BwUzNzow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKQyX-00000007557-3eec; Thu, 20 Jun 2024 23:13:53 +0000 Received: from mail-oa1-x36.google.com ([2001:4860:4864:20::36]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKQyN-0000000750S-2WJi for linux-arm-kernel@lists.infradead.org; Thu, 20 Jun 2024 23:13:45 +0000 Received: by mail-oa1-x36.google.com with SMTP id 586e51a60fabf-25980546baeso715529fac.2 for ; Thu, 20 Jun 2024 16:13:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1718925222; x=1719530022; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Xx9yiqfqGQhoL/OQzBJX0T4MbHx9pH2R2+We+nfV8yc=; b=aDZDPAvTGbjpGyYvlVGtnf3U+nJApyw6KuXJ9WcreJMFXdbi0vYEFfKv8Pr6hnHykz IFX/DMqFjXKvHrzGlEqVzLk9qfWBRAbLSjjp36FpexKe6kKrOdTihJKafBKibiMaoHmA BGIctBKJYVTYUPEAO7IqxAZk5tXyDHZsMTs45MeKTrlVVtlwhNfhivhWmw0kNXS+ydKM 7s3R3VGvm0mOCydWqsd2+nwyy2UIo6OLxmDZLAtACe41ZvlF/6+czR3iG8PSoBc1DIDm +YdWr8uGR4irKW0M9axtqMPoMX7wazaWLTQql0K5QZg5Xjiov6ltfEFq9Gbedej7Vh+y J56w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718925222; x=1719530022; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Xx9yiqfqGQhoL/OQzBJX0T4MbHx9pH2R2+We+nfV8yc=; b=JSYTZyYNX3m1fCSKzh1zEBIuEmcxIiK3/7JDm2ijpLYNw20GRjCL+rFGQNurFNeQ7m FKmL+ZnJsxQSGdHZBO6JlkeZGuHYx692ELRa/X/fq56/GHwFIf0GVLKvqYLa3cGRK5DX myWIg+RYq5U9ay2s+oWI1+K6K7y5Kj6WqfhZHKTIHApvSGUvGhOhI1rj+CdvQy+6LsPM oYQ2ftFqGt7TWuMKR5xouuNPnTEn5qnPJFQB2iPs9hC2p/zFds2hn3pz85vLGaBk3XaX VEKkauLVN2l/TgBMmN3UMPW1c4ETo4jl1xXeeOt1hnqjhmoRFxFkp1hkRWvI0GX040Jr qWCg== X-Forwarded-Encrypted: i=1; AJvYcCVQZOUVljZ3lRbSDPfpz7CrOsmgwQO4NDaxHLj6Xc1V/CNmNiu19tgt1W/n1CWujtcy41PWCK6gCCYh2Eh2Y/xLEtynMJ9MH0tGkeM8RoGIDghx9y4= X-Gm-Message-State: AOJu0YxcLUMkJZYmUzlWPyi0hP9Vuo1eJDNjLa56S5eam+oVJvH5qXnK q4q7GqRU7WHl+Qxfi/1EjHrRFx+iFlYZ4ffj+hqTvnKSwNStvfohUuVfJGfycOU= X-Google-Smtp-Source: AGHT+IG8lAKtWiSgYIqlkSt41d/qaNiahUHwFKBCRi2rphALIUFAjgt4BUmpmumuwrlgNLH0oGwTwA== X-Received: by 2002:a05:6870:c111:b0:254:ada1:aa29 with SMTP id 586e51a60fabf-25c94a22a97mr8080798fac.27.1718925222389; Thu, 20 Jun 2024 16:13:42 -0700 (PDT) Received: from localhost ([136.62.192.75]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-25cd49d18absm131302fac.25.2024.06.20.16.13.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Jun 2024 16:13:42 -0700 (PDT) From: Sam Protsenko To: =?utf-8?q?=C5=81ukasz_Stelmach?= , Krzysztof Kozlowski , Rob Herring , Conor Dooley Cc: Anand Moon , Olivia Mackall , Herbert Xu , Alim Akhtar , linux-samsung-soc@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 3/6] hwrng: exynos: Use devm_clk_get_enabled() to get the clock Date: Thu, 20 Jun 2024 18:13:36 -0500 Message-Id: <20240620231339.1574-4-semen.protsenko@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240620231339.1574-1-semen.protsenko@linaro.org> References: <20240620231339.1574-1-semen.protsenko@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240620_161343_671815_AD07045F X-CRM114-Status: GOOD ( 13.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Use devm_clk_get_enabled() helper instead of calling devm_clk_get() and then clk_prepare_enable(). It simplifies the error handling and makes the code more compact. Also use dev_err_probe() to handle possible -EPROBE_DEFER errors if the clock is not available yet. Signed-off-by: Sam Protsenko Reviewed-by: Krzysztof Kozlowski Reviewed-by: Anand Moon --- Changes in v3: - Added missing '\n' in dev_err_probe() - Added R-b tag from Krzysztof - Added R-b tag from Anand Changes in v2: - No changes (it's a new patch added in v2) drivers/char/hw_random/exynos-trng.c | 21 ++++----------------- 1 file changed, 4 insertions(+), 17 deletions(-) diff --git a/drivers/char/hw_random/exynos-trng.c b/drivers/char/hw_random/exynos-trng.c index 266bdad84f3c..997bd22f4498 100644 --- a/drivers/char/hw_random/exynos-trng.c +++ b/drivers/char/hw_random/exynos-trng.c @@ -134,32 +134,23 @@ static int exynos_trng_probe(struct platform_device *pdev) goto err_pm_get; } - trng->clk = devm_clk_get(&pdev->dev, "secss"); + trng->clk = devm_clk_get_enabled(&pdev->dev, "secss"); if (IS_ERR(trng->clk)) { - ret = PTR_ERR(trng->clk); - dev_err(&pdev->dev, "Could not get clock.\n"); - goto err_clock; - } - - ret = clk_prepare_enable(trng->clk); - if (ret) { - dev_err(&pdev->dev, "Could not enable the clk.\n"); + ret = dev_err_probe(&pdev->dev, PTR_ERR(trng->clk), + "Could not get clock\n"); goto err_clock; } ret = devm_hwrng_register(&pdev->dev, &trng->rng); if (ret) { dev_err(&pdev->dev, "Could not register hwrng device.\n"); - goto err_register; + goto err_clock; } dev_info(&pdev->dev, "Exynos True Random Number Generator.\n"); return 0; -err_register: - clk_disable_unprepare(trng->clk); - err_clock: pm_runtime_put_noidle(&pdev->dev); @@ -171,10 +162,6 @@ static int exynos_trng_probe(struct platform_device *pdev) static void exynos_trng_remove(struct platform_device *pdev) { - struct exynos_trng_dev *trng = platform_get_drvdata(pdev); - - clk_disable_unprepare(trng->clk); - pm_runtime_put_sync(&pdev->dev); pm_runtime_disable(&pdev->dev); }