From patchwork Fri Jun 21 13:19:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 13707599 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DE50DC41513 for ; Fri, 21 Jun 2024 13:20:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uX+rS5G3W7Xd5WyDA9MnftLeq1vdmexAme+rSO6wfwE=; b=Om2ubxkCjVQ/1e8IKSfyB05uHt hVBGLi/rYDHCIK+IOyLilmU1nLTHtopwgryDxNBP1ZumAKPMufUEYcjHS8sXk8Fk1z4P8f1ubECnp kp1Nq0zhnyHqbbp+pufJYMN4LzIuZaPGF3Pqec0HM+I/My0AMthei/bjphgxw616Qngo3GoapiN1I WFTPiOyXqXmMaN2yIhrg0LDJB2jIU9L+JcJtMLjiD92ZT2LhOQNg4KN7RTVlpsgP4Ccodd/zSWiZd HbSHbLWEG7JywX3p26/5KA5ZE/beyefsK6GKLz+bl6LuRbAURiM5MPohtg+7R5imwnsPC0IAuQegP SV+5ZSEA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKeBp-00000009J7r-2qhF; Fri, 21 Jun 2024 13:20:29 +0000 Received: from mout.gmx.net ([212.227.15.19]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKeBh-00000009J1Q-1WbI for linux-arm-kernel@lists.infradead.org; Fri, 21 Jun 2024 13:20:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1718976018; x=1719580818; i=wahrenst@gmx.net; bh=uX+rS5G3W7Xd5WyDA9MnftLeq1vdmexAme+rSO6wfwE=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:Message-Id:In-Reply-To: References:MIME-Version:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=rxeUwKOZh4pzLRTZP/qZtogoYtZBSc8Qo+FlUSTh7C2wPoV09Osl/bfAWJU6S+9D DO6yEAde+mQLm8k+TRtSK750t1FSDkc+Bu2mMC+hsd/V1QAOMx176C/WUYIwlK6g/ gWstfMeOd24f05a45KIF27/Ftbbx9NLqOEaRXHCzukc88uGdMvA9BU5YDV5AvY9w3 SVVjrovHuTaRMVAYQe8MAoJZPUYL7wjHTdSarb5mrH0mCVtVj4pFp+0j+q0Lg0Nme 6VoIzdoNOm80TKPGgfM18u8x5rCVjrLwvyCrXR2SpwXxiqOmF2vyrldcWwtLRJRY3 KdzEqUraDQbEre73Sw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from stefanw-SCHENKER ([37.4.248.43]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Mlw7V-1slQIc3Aln-00jUrn; Fri, 21 Jun 2024 15:20:17 +0200 From: Stefan Wahren To: Greg Kroah-Hartman , Florian Fainelli Cc: Umang Jain , Laurent Pinchart , linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Stefan Wahren Subject: [PATCH V3 08/10] staging: vchiq_core: Add hex prefix to debugfs output Date: Fri, 21 Jun 2024 15:19:56 +0200 Message-Id: <20240621131958.98208-9-wahrenst@gmx.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240621131958.98208-1-wahrenst@gmx.net> References: <20240621131958.98208-1-wahrenst@gmx.net> MIME-Version: 1.0 X-Provags-ID: V03:K1:p0q/8XrLSg6nLiqJSnB84xq6GIQIkrtFigmv+1MD52yFxufc7QO cudgPhE3IpLZEUsk6T0dGqu6QSU99TmpgLoEkm5QhbaH8RRUrca8gh1qSCj8xM0qg6zkliW /KljRDsIgtePA4GdatY7fpVUxHU+SM6XHnzByxu+zdsX6BoGrdEU/iRkJU/9KlhJreu/OG5 e1pCmfhlzN4VVLaCqplgA== UI-OutboundReport: notjunk:1;M01:P0:bE3w4uPKbg8=;aUeH1NDefhTjPWEh+1pC/szlaI3 3CTFTX/KzHvxLxORm7tQrIvP1hE19hiNHTD3JoStQsYTXqEUJT9Mcim2eIrzg/j8I+cZqntW4 h4+l7BD5l2SxG8qPDm8TuoVu19hScResJ2ea4/AV7ZMVeBkfll+5rbXLy4hSkSwyRddPtHFtQ YRNx0TKRXdOdJzbLTF9R7lQqYxZAAFAKOpGB1/1ZrM8aVeLul2W6qZytvaKAukqrxqZ3DkGk6 lHocTwOnQrb7FKBGwC4c4mzEaJ71FcJ1Cq0V6of329OtprDDRoO9hf6VJ07/6/bH3Q1AEFWeq ccG8gbHCpwSJBnHkvxIlBR1JRFvoh+SAESPJKU470GsRueIyVqZIIUgmhd1ubNi/vBOWmC9/v CsJCHGVlvVq9/Ljc7TQLFvHKR8p02y/K9/drpW+BCD0OtLGneAuPW74E2QBVOZomI76TRmQh9 PK9m9hrcJp3xQvdiI3kTaWA+Ln4h0Ubhjke4h21mER/Se3W19koaBIc3slnI6VLa0+jUKKWZ2 JDqOEbvKCcTiUDCDsk1tqi/1x9l5oDVPgCuPabZIbZZCkhye0nfAtekjsveHoh+szq7qcECP9 aFZPCrf/PSRhsFFq6m8TwJqunsvREuhcnH15aBOvpSKbBM/2VqQMGC9noZB1QT+h/G+Nziq5k cLBRIJfBZ26g2CxuyVfsYo6eyj3dGCs24CZ4GTtRhv1lJxgKzKfbBwAAREBZ9QtFDYiZzsy5f RpDMtCn8UHc0oD2E+xaM2fhJ3qS3yDo0aQ7W/5uyouR08X6UBTsNoUNHzKnizJSXwcFnmHCH3 itBOuABdTZnYqftpwoN6549Kw6ReEOKapWZ3q8VEGzgJk= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240621_062021_786268_AE862903 X-CRM114-Status: UNSURE ( 9.48 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The number format of VCHIQ debugfs isn't always clear. So let's add a prefix for all hex values, in order to make things clear. Signed-off-by: Stefan Wahren Reviewed-by: Laurent Pinchart --- .../vc04_services/interface/vchiq_arm/vchiq_core.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) -- 2.34.1 diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c index 51cfc366519b..4f65e4021c4d 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c @@ -3370,7 +3370,7 @@ vchiq_dump_shared_state(struct seq_file *f, struct vchiq_state *state, }; int i; - seq_printf(f, " %s: slots %d-%d tx_pos=%x recycle=%x\n", + seq_printf(f, " %s: slots %d-%d tx_pos=0x%x recycle=0x%x\n", label, shared->slot_first, shared->slot_last, shared->tx_pos, shared->slot_queue_recycle); @@ -3386,7 +3386,7 @@ vchiq_dump_shared_state(struct seq_file *f, struct vchiq_state *state, } for (i = 1; i < shared->debug[DEBUG_ENTRIES]; i++) { - seq_printf(f, " DEBUG: %s = %d(%x)\n", + seq_printf(f, " DEBUG: %s = %d(0x%x)\n", debug_names[i], shared->debug[i], shared->debug[i]); } } @@ -3414,7 +3414,7 @@ vchiq_dump_service_state(struct seq_file *f, struct vchiq_service *service) if (service->public_fourcc != VCHIQ_FOURCC_INVALID) scnprintf(remoteport + len2, sizeof(remoteport) - len2, - " (client %x)", service->client_id); + " (client 0x%x)", service->client_id); } else { strscpy(remoteport, "n/a", sizeof(remoteport)); } @@ -3475,7 +3475,7 @@ void vchiq_dump_state(struct seq_file *f, struct vchiq_state *state) seq_printf(f, "State %d: %s\n", state->id, conn_state_names[state->conn_state]); - seq_printf(f, " tx_pos=%x(@%pK), rx_pos=%x(@%pK)\n", + seq_printf(f, " tx_pos=0x%x(@%pK), rx_pos=0x%x(@%pK)\n", state->local->tx_pos, state->tx_data + (state->local_tx_pos & VCHIQ_SLOT_MASK), state->rx_pos,