diff mbox series

clk: imx: composite-7ulp: Use NULL instead of 0

Message ID 20240624024351.488492-1-peng.fan@oss.nxp.com (mailing list archive)
State New
Headers show
Series clk: imx: composite-7ulp: Use NULL instead of 0 | expand

Commit Message

Peng Fan (OSS) June 24, 2024, 2:43 a.m. UTC
From: Peng Fan <peng.fan@nxp.com>

Address the sparse warnings "
sparse warnings: (new ones prefixed by >>)
>> drivers/clk/imx/clk-composite-7ulp.c:85:24: sparse: sparse:
Using plain integer as NULL pointer
"

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202406220536.JnAncjqz-lkp@intel.com/
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---

V1:
 Since the orignal patch is still in linux-next tree, so not add fixes tag

 drivers/clk/imx/clk-composite-7ulp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Abel Vesa June 24, 2024, 9:05 a.m. UTC | #1
On 24-06-24 10:43:51, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> Address the sparse warnings "
> sparse warnings: (new ones prefixed by >>)
> >> drivers/clk/imx/clk-composite-7ulp.c:85:24: sparse: sparse:
> Using plain integer as NULL pointer
> "
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202406220536.JnAncjqz-lkp@intel.com/
> Signed-off-by: Peng Fan <peng.fan@nxp.com>

Reviewed-by: Abel Vesa <abel.vesa@linaro.org>

> ---
> 
> V1:
>  Since the orignal patch is still in linux-next tree, so not add fixes tag
> 
>  drivers/clk/imx/clk-composite-7ulp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/imx/clk-composite-7ulp.c b/drivers/clk/imx/clk-composite-7ulp.c
> index db7f40b07d1a..8ed2e0ad2769 100644
> --- a/drivers/clk/imx/clk-composite-7ulp.c
> +++ b/drivers/clk/imx/clk-composite-7ulp.c
> @@ -82,7 +82,7 @@ static struct clk_hw *imx_ulp_clk_hw_composite(const char *name,
>  	val = readl(reg);
>  	if (!(val & PCG_PR_MASK)) {
>  		pr_info("PCC PR is 0 for clk:%s, bypass\n", name);
> -		return 0;
> +		return NULL;
>  	}
>  
>  	if (mux_present) {
> -- 
> 2.37.1
>
Abel Vesa June 24, 2024, 1:05 p.m. UTC | #2
On Mon, 24 Jun 2024 10:43:51 +0800, Peng Fan (OSS) wrote:
> Address the sparse warnings "
> sparse warnings: (new ones prefixed by >>)
> >> drivers/clk/imx/clk-composite-7ulp.c:85:24: sparse: sparse:
> Using plain integer as NULL pointer
> "
> 
> 
> [...]

Applied, thanks!

[1/1] clk: imx: composite-7ulp: Use NULL instead of 0
      commit: 466da3d2d967ee87d82060df2bc9c6ad4fc4af49

Best regards,
diff mbox series

Patch

diff --git a/drivers/clk/imx/clk-composite-7ulp.c b/drivers/clk/imx/clk-composite-7ulp.c
index db7f40b07d1a..8ed2e0ad2769 100644
--- a/drivers/clk/imx/clk-composite-7ulp.c
+++ b/drivers/clk/imx/clk-composite-7ulp.c
@@ -82,7 +82,7 @@  static struct clk_hw *imx_ulp_clk_hw_composite(const char *name,
 	val = readl(reg);
 	if (!(val & PCG_PR_MASK)) {
 		pr_info("PCC PR is 0 for clk:%s, bypass\n", name);
-		return 0;
+		return NULL;
 	}
 
 	if (mux_present) {