From patchwork Wed Jun 26 20:36:26 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Rogers X-Patchwork-Id: 13713419 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E125CC27C4F for ; Wed, 26 Jun 2024 20:42:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:To:From:Subject :References:Mime-Version:Message-Id:In-Reply-To:Date:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TFHYu3Nth2gR5eivBBGcLrTyqj+GOTAKJL2cvnIsazU=; b=fEtrvCbXU2FS3LWpqxn0X8EG0X 6JSkdALU1tjG31a7+iiFu0G241JSNSaXy7tyjUMVBtyknEhwemFa7EjnNi4cAhav8BydkiaaoFyLQ oU7/gAGacV1hsWOJzD3WDbEM8ObrcTvDOrt2BDIdFkcYq2W3nH8hjj+BydhEFwtwlMKjVZSj9UYfV hwzkGllugqc+vNYwsz+sdhdz6c95g8Fn1TqM4Xv1IyxzR49CN19FBPhis+niYTqVYDL9MDBkBEKOc ihLvmI9wKHv/Sod7IGYMd+qqL/0aGwAwe3FrbP3mHoOrwVGmP/l/syDo8IPcJjOjviVfcN4LfO0zy bEECvzqQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMZTP-00000008HsZ-3kYM; Wed, 26 Jun 2024 20:42:35 +0000 Received: from mail-yb1-xb49.google.com ([2607:f8b0:4864:20::b49]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMZOZ-00000008Fam-37SH for linux-arm-kernel@lists.infradead.org; Wed, 26 Jun 2024 20:37:37 +0000 Received: by mail-yb1-xb49.google.com with SMTP id 3f1490d57ef6-e02fff66a83so8551383276.0 for ; Wed, 26 Jun 2024 13:37:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1719434254; x=1720039054; darn=lists.infradead.org; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=TFHYu3Nth2gR5eivBBGcLrTyqj+GOTAKJL2cvnIsazU=; b=NSKSWnwAmioATWjgVGZF6QKqsFbujCUGANxTNSaUYxfImbIcilvBwWL6XEW/stBqZ0 4RmphaC5fZA6pOjMgY8q9oXiOFyUZD6y7tid64/tTTB0pdwf2Ym0mO3462hh0FBYgdV0 /xakD67I4KVXJKoLhU/62069QDAW1iZn0g9nUwnrT0UjBOCEPENKqR4T9B/KamZSZg37 27z7KaCTBKZ61x7KG56S22pkgKOdg96C9vT2pNLoWrRMnY+kUhrNhzEjzaRaFPL40UUR 4BKRdodt4xc/hwAu04nQRR54ETazUw6oE2qzMF6Tdc9dK1SkSEenOjufK7ZYNK/PvJLi 9g1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719434254; x=1720039054; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TFHYu3Nth2gR5eivBBGcLrTyqj+GOTAKJL2cvnIsazU=; b=mrc8Go8r38eWXbzo5Lh8Pkc2BoYf0G7rzYS99GZYsH+/V+KjcLyKv3qDTzXfUvCHvO GBS10YrMkC1vUCYDyH4meTnf8hG8uyBI4nY8ZA2w4SkUnSwRZinN/ZeCIg6fblw7AN8A cC8cRhduHLfOyjC7fG/FKcgHQXiz+mOlNn4rRun0CN2sNDOfnpOKC5wu+q/XRNMX0TQH QeBHKV9E1xDL0SEgKBfeBGrfQ3oMiF3RMgYvdQSeC5cAjaGhnp7e8Hw8ZWVtVOh5NfQY +7qpKyEaxc8usCCscrrnom15hoHaOxVrr5pRF6t65q4RyNhXBW1v5jgeldeBIi/44xOv TDzw== X-Forwarded-Encrypted: i=1; AJvYcCWSj3QxSYt1RZgLr7PaiS82sRtJUrXy/tq+cUhjDnMMVhawhzaeGE+gvXUCQeNmi8D5lleDrjmRUhpG0BZ4dtZaUdu6vnbXSS4D7NlftCbFzjigtBM= X-Gm-Message-State: AOJu0Ywlqj9n6X98VQI9jApe1N6I3Gb91/AY4cDrgG+HLsojEXwLt1DU Sr7G3LGMipxaGe2Yq+YG0LyoaiGiSj2dvnnt0u0jYNbBcm9pLHGmSMlsLIO/LOHPlCUGIAn+54w CX8OY5Q== X-Google-Smtp-Source: AGHT+IH9TuYO+WiPmgRtSFFWHjHBH655rX65a4zVzk7gaz2aQTP23YgHXVJikjgfAs5bm2nu+W28AwUbyUSL X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:23a1:25b9:2412:56de]) (user=irogers job=sendgmr) by 2002:a05:6902:1081:b0:dff:3096:85e1 with SMTP id 3f1490d57ef6-e030104fe43mr68452276.10.1719434254286; Wed, 26 Jun 2024 13:37:34 -0700 (PDT) Date: Wed, 26 Jun 2024 13:36:26 -0700 In-Reply-To: <20240626203630.1194748-1-irogers@google.com> Message-Id: <20240626203630.1194748-25-irogers@google.com> Mime-Version: 1.0 References: <20240626203630.1194748-1-irogers@google.com> X-Mailer: git-send-email 2.45.2.741.gdbec12cfda-goog Subject: [PATCH v2 24/27] perf test event_update: Ensure tools is initialized From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Suzuki K Poulose , Yicong Yang , Jonathan Cameron , Nick Terrell , Nick Desaulniers , Oliver Upton , Anshuman Khandual , Song Liu , Ilkka Koskinen , Huacai Chen , Yanteng Si , Sun Haiyong , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240626_133735_865554_1DB1BE91 X-CRM114-Status: GOOD ( 10.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Ensure tool is initialized to avoid lazy initialization pattern so that more uses of struct perf_tool can be made const. Signed-off-by: Ian Rogers --- tools/perf/tests/event_update.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/perf/tests/event_update.c b/tools/perf/tests/event_update.c index fdecad920f59..d6b4ce3ef4ee 100644 --- a/tools/perf/tests/event_update.c +++ b/tools/perf/tests/event_update.c @@ -103,6 +103,7 @@ static int test__event_update(struct test_suite *test __maybe_unused, int subtes TEST_ASSERT_VAL("failed to synthesize attr update scale", !perf_event__synthesize_event_update_scale(NULL, evsel, process_event_scale)); + perf_tool__init(&tmp.tool, /*ordered_events=*/false); tmp.name = evsel__name(evsel); TEST_ASSERT_VAL("failed to synthesize attr update name",