From patchwork Thu Jun 27 17:32:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Serge Semin X-Patchwork-Id: 13714943 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EAFCBC2BD09 for ; Thu, 27 Jun 2024 17:34:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ISugwrJpK+qCNO3mL2KSTDUU9IbUyyHgug7HQ4HSe5U=; b=2EhZABsnmtYIW5ePiR49o6sp0H KhmXPEo4/CpE379vSaN/V8fK4+Lnn6Ym68S8+gihyadkOkHrvpMbbWvXWX+XOdG6EQdi4U6W9nA7y 3PnoGucPSf1B/md0A3+UIXTROp18L198yV0YZ/HypEf9MeEf2S69crdS4r75YsrCrZPt2ZI8S6e/9 jE4PDuz22P+T/zWLPcWaHHtcIzRbAbTu3zKHtLEJbhlb7GAaiRQ5y0LirNjq2gxZL4K+cSG5yxxA6 lcIpczJwWn86A0vP4pIykGVwRP9Bd05dF7VL9Ot6ldIFeNHrdhjvABZllz9IVCLOC7WORaj9hNxZj ofrNkYSw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMt13-0000000BEJB-0FjX; Thu, 27 Jun 2024 17:34:37 +0000 Received: from mail-lj1-x22b.google.com ([2a00:1450:4864:20::22b]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMszp-0000000BDWg-0Moe for linux-arm-kernel@lists.infradead.org; Thu, 27 Jun 2024 17:33:23 +0000 Received: by mail-lj1-x22b.google.com with SMTP id 38308e7fff4ca-2ec4eefbaf1so75832571fa.1 for ; Thu, 27 Jun 2024 10:33:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719509599; x=1720114399; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ISugwrJpK+qCNO3mL2KSTDUU9IbUyyHgug7HQ4HSe5U=; b=GpY/sUMz3vWFLoVlsogqn5NsmPw78VbUVGomfcT1XBakBkS8D0an4hEx9F4QJtx0C9 TJNjoSp2xtsTqLilav9LQWIOAbgojZz9bJr2TeneQi13Hp50dc8QPVA2zG9oFKtWJKoM Xoeb7bhIjmQ3afblg+N/B575Cw49VsgakzjUQaNNInqDrAXkQn9WE708DZpeYleHroi4 8yeR57raVY2uJmaPIHwcbHoxdyn1Km3G67YJnKpxHeflLpvaSBS/8tENtqAaXqK6+PxU MvxrG6ej63FA6RtxXrmvd/AvyZHBC6URkn09kyCdembAzCi3CopsdIL6eGldxgrPpWTG sTKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719509599; x=1720114399; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ISugwrJpK+qCNO3mL2KSTDUU9IbUyyHgug7HQ4HSe5U=; b=nPSIhSoQf7fanFUjpMbF4KEpPKU4ItMDtheKuRNIuFYc8114MkFPTW+vsE0Zq1Pd51 FkWuwC/G7aLoS0/ORdXKnH/kzEwIg3V6VU4VKcu3yS1U43z5UuUxxcR0nyN9eBD6hXX4 tFn96no0mZPbubajJMrXw5eZRHsghKY0Y4QQBXoLQjguOvOoVt55xPKGo60rE3iY0nS/ LUtv5e1W1uN8jivlmXjxqkzpmRSCBJIDj1Hj27fIrM+bmygjDDDDEOgQc7B1jvNAQHaq ady20D7U/cMxR0gl0lmVZrxov6kExRQ0wgYugZkl+RgB9Ns2LwkeVWW5YeLXS70V5mOd +rcQ== X-Forwarded-Encrypted: i=1; AJvYcCVm+8DjTlkmIee2lGhQ6JJ1PdalraNp2WMGjp9SYhAL5lZr6cV8tESlMXcqUdpRU4G3tt919XyumS0NZ3vt2DdDrEJapGs/ENmMW/IYg6mlkCyWzLk= X-Gm-Message-State: AOJu0YzHjaDo2ZOwA2r7LyGLdxyGuGnzvlIRKmGszUGaei6R6pFm/x/z ex8WQXlu+dWiMqlj5Dn2kO9no/EYetTNZ35YYreOFrVJmkIcW7Y7 X-Google-Smtp-Source: AGHT+IFJKI9Xx+K5dwhq/UHl+CAPUoBjUFBUnEIN5qh4rNroF9Q1yIhmdU4HDUxxv9PnwR5qtx/vKw== X-Received: by 2002:a2e:7a0a:0:b0:2ec:543e:909e with SMTP id 38308e7fff4ca-2ec5b378497mr88498941fa.15.1719509599129; Thu, 27 Jun 2024 10:33:19 -0700 (PDT) Received: from localhost ([213.79.110.82]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-2ee4a4cf7a3sm3203691fa.135.2024.06.27.10.33.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jun 2024 10:33:18 -0700 (PDT) From: Serge Semin To: Michal Simek , Alexander Stein , Borislav Petkov , Tony Luck , James Morse , Mauro Carvalho Chehab , Robert Richter Cc: Serge Semin , Punnaiah Choudary Kalluri , Dinh Nguyen , Shubhrajyoti Datta , Arnd Bergmann , Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH RESEND v6 10/18] EDAC/synopsys: Drop redundant info from the error messages Date: Thu, 27 Jun 2024 20:32:17 +0300 Message-ID: <20240627173251.25718-11-fancer.lancer@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240627173251.25718-1-fancer.lancer@gmail.com> References: <20240627173251.25718-1-fancer.lancer@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240627_103321_227671_82E81D27 X-CRM114-Status: GOOD ( 12.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Currently the custom error messages are needlessly long so the logged text gets to be printed in several lines in console. There is some duplicated/redundant information which can be freely removed from it: drop the message prefix "DDR ECC error type:%s" since the resultant text printed to the log by the edac_mc_printk() method will contain the error type and the memory controller id referring to the device detected the error anyway; with no harm to readability shorten out the phrase "Bit Position" to being just "Bit". Signed-off-by: Serge Semin --- drivers/edac/synopsys_edac.c | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/edac/synopsys_edac.c b/drivers/edac/synopsys_edac.c index 8b7069bca600..23a2f56fcb74 100644 --- a/drivers/edac/synopsys_edac.c +++ b/drivers/edac/synopsys_edac.c @@ -478,13 +478,13 @@ static void handle_error(struct mem_ctl_info *mci, struct synps_ecc_status *p) pinf = &p->ceinfo; if (priv->p_data->quirks & DDR_ECC_INTR_SUPPORT) { snprintf(priv->message, SYNPS_EDAC_MSG_SIZE, - "DDR ECC error type:%s Row %d Col %d Bank %d Bank Group %d Bit Position: %d Data: 0x%08x", - "CE", pinf->row, pinf->col, pinf->bank, - pinf->bankgrp, pinf->bitpos, pinf->data); + "Row %d Col %d Bank %d Bank Group %d Bit %d Data 0x%08x", + pinf->row, pinf->col, pinf->bank, pinf->bankgrp, + pinf->bitpos, pinf->data); } else { snprintf(priv->message, SYNPS_EDAC_MSG_SIZE, - "DDR ECC error type:%s Row %d Bank %d Col %d Bit Position: %d Data: 0x%08x", - "CE", pinf->row, pinf->bank, pinf->col, + "Row %d Bank %d Col %d Bit: %d Data: 0x%08x", + pinf->row, pinf->bank, pinf->col, pinf->bitpos, pinf->data); } @@ -497,13 +497,12 @@ static void handle_error(struct mem_ctl_info *mci, struct synps_ecc_status *p) pinf = &p->ueinfo; if (priv->p_data->quirks & DDR_ECC_INTR_SUPPORT) { snprintf(priv->message, SYNPS_EDAC_MSG_SIZE, - "DDR ECC error type :%s Row %d Col %d Bank %d Bank Group %d", - "UE", pinf->row, pinf->col, pinf->bank, - pinf->bankgrp); + "Row %d Col %d Bank %d Bank Group %d", + pinf->row, pinf->col, pinf->bank, pinf->bankgrp); } else { snprintf(priv->message, SYNPS_EDAC_MSG_SIZE, - "DDR ECC error type :%s Row %d Bank %d Col %d ", - "UE", pinf->row, pinf->bank, pinf->col); + "Row %d Bank %d Col %d", + pinf->row, pinf->bank, pinf->col); } edac_mc_handle_error(HW_EVENT_ERR_UNCORRECTED, mci,