From patchwork Thu Jun 27 17:32:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Serge Semin X-Patchwork-Id: 13714935 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F7DFC2BD09 for ; Thu, 27 Jun 2024 17:33:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xg/mOI5PvLezOW9iPAK+BlDobOkASDmuuCygc0x83oc=; b=2x7Y0mGBs7BK9EmBXKoubEtU6b bO8bhdGU19TyY2TCX9SlZgr3aaoVlIanhHiBHEQl+6uGxMGD5PzRIlj6YDtC3uhSZ91wXJQtywvkc xOOuuVNOkdFx5WWikGITsV+b97PTJ9v8cYSjIvXUZ9xxt7pUAJ3/u+2nSQMCPPBAGPHW36fBy21Nq 5RZFri+ZOoDQ3e+t5iL95H0yF+t10as4h2Sb/3enKnzTXkTZeNpgy6kdRf1C5u46d2TJtiyDlvlPg rygk06LVvESjQUX4SQSgqYBI5+DhGMVLoJm/wqtDhxwPQiORhJYxmgwyFO/BUDm+w0x6SOIQ1UQa+ 9FC79qUQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMt02-0000000BDfs-1R3k; Thu, 27 Jun 2024 17:33:34 +0000 Received: from mail-lf1-x136.google.com ([2a00:1450:4864:20::136]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMszY-0000000BDNn-3zvf for linux-arm-kernel@lists.infradead.org; Thu, 27 Jun 2024 17:33:06 +0000 Received: by mail-lf1-x136.google.com with SMTP id 2adb3069b0e04-52ce01403f6so5617748e87.0 for ; Thu, 27 Jun 2024 10:33:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719509583; x=1720114383; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xg/mOI5PvLezOW9iPAK+BlDobOkASDmuuCygc0x83oc=; b=V+JXPbOixzxPPs+MRfD6rqK1LhJFNVmKHBdYavhhNYHSV3QwN6qWQCs571DTk3qasa 1+jDkAmUAM2IC+V3+XY5v8KQqUvzfr+mqVccLaFm3+RdfY5wvDsmQjaB9kcmqtLOv9PM cHkC1jmBauZW6RxzJtlvsN3CYlbxM9I2n93pnE290NMDCeDh+FskbZ3/Zgwt95t6YhwP bINa9wTAtdGRWvwlgazI1JKFf5E5zRFJQ9brA229Ujj1K0zYD9z+h3hpGqU4hT0/Rrb6 x2SfSzToSeypeAS9xUaMH0owno3JMr0IwbHC3noHu/JBaJSfERLJ5koz9rganxON+0l/ WvRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719509583; x=1720114383; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xg/mOI5PvLezOW9iPAK+BlDobOkASDmuuCygc0x83oc=; b=kKHQUas4tVyIvcecibHl5M4SBsIix9KmIFBZCIDxY03gsgTY9E6wzYAg0djWVAAwBi ra3TUAb3jmqIBj+z0ysIU5jgIs9qnbyqgiArzp23RuQvPjp6DD+kQHB8GtxkSNg5807n 88JYjIZJVuM9enf2arziBCr2segha83ErjZQm9WMjcecnn24Hv7BdtitKZG0Qe/pYad6 3Zt94ltVxEQejgXe79gUhD7/egh4g4Y4StkB1okOv/63wSuhOuZ0M1YOVa2kbcglXQg9 SbJyhmDtuPdqVXcGuEqaUUEJGoBsP0pjqAXIAoOEbrExeY0PwEPtlzEtzzvU0r2wNTcj Fjsw== X-Forwarded-Encrypted: i=1; AJvYcCXwPZKPxYmgFgzekOX0NH1F/seVdkX+i1Fa2Wd6VuNNlCCwVIWWEbfkL58fRRWaYNH8uP5FoWZPXQJX8VjrptUihUGOmxRd1NwEmbgt2SdYyuGuWec= X-Gm-Message-State: AOJu0YzVrbtgRzeYJ/dLIVQEZhzT0IYxcHKK3BbkjeBP1v/260UHLsj3 2tqDnZnA3rONpdfKQ2C/njRDrDFGFUe8PuRQUnWdGxpIpj+WXDXd X-Google-Smtp-Source: AGHT+IE34gX8JBOwnPguUm1i2MnbYns7iVf2oandtz2j/c+iSAlyGV2aNnU07ODLD48qTYE7Q+xPmA== X-Received: by 2002:a05:6512:108a:b0:52c:e1cd:39be with SMTP id 2adb3069b0e04-52ce1cd3a9cmr11118640e87.8.1719509582697; Thu, 27 Jun 2024 10:33:02 -0700 (PDT) Received: from localhost ([213.79.110.82]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-52e71329b95sm268354e87.296.2024.06.27.10.33.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jun 2024 10:33:02 -0700 (PDT) From: Serge Semin To: Michal Simek , Alexander Stein , Borislav Petkov , Tony Luck , James Morse , Mauro Carvalho Chehab , Robert Richter , Punnaiah Choudary Kalluri Cc: Serge Semin , Dinh Nguyen , Shubhrajyoti Datta , Arnd Bergmann , Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Borislav Petkov Subject: [PATCH RESEND v6 02/18] EDAC/synopsys: Fix mci->scrub_cap field setting Date: Thu, 27 Jun 2024 20:32:09 +0300 Message-ID: <20240627173251.25718-3-fancer.lancer@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240627173251.25718-1-fancer.lancer@gmail.com> References: <20240627173251.25718-1-fancer.lancer@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240627_103305_020412_2D8308AB X-CRM114-Status: GOOD ( 15.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The mem_ctl_info.scrub_cap field is supposed to be set with the ECC scrub-related flags. Instead the driver erroneously initializes it with the SCRUB_HW_SRC flag ID. It's definitely wrong, but it hasn't caused any problem so far since the structure field isn't used by the EDAC core. Fix it anyway by using the SCRUB_FLAG_HW_SRC macro to initialize the field. Fixes: ae9b56e3996d ("EDAC, synps: Add EDAC support for zynq ddr ecc controller") Signed-off-by: Serge Semin --- drivers/edac/synopsys_edac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/edac/synopsys_edac.c b/drivers/edac/synopsys_edac.c index b6bdbc1289f3..2b23d5ef9cff 100644 --- a/drivers/edac/synopsys_edac.c +++ b/drivers/edac/synopsys_edac.c @@ -855,7 +855,7 @@ static void mc_init(struct mem_ctl_info *mci, struct platform_device *pdev) /* Initialize controller capabilities and configuration */ mci->mtype_cap = MEM_FLAG_DDR3 | MEM_FLAG_DDR2; mci->edac_ctl_cap = EDAC_FLAG_NONE | EDAC_FLAG_SECDED; - mci->scrub_cap = SCRUB_HW_SRC; + mci->scrub_cap = SCRUB_FLAG_HW_SRC; mci->scrub_mode = SCRUB_NONE; mci->edac_cap = EDAC_FLAG_SECDED;