From patchwork Thu Jun 27 17:32:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Serge Semin X-Patchwork-Id: 13714936 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22BFFC2BD09 for ; Thu, 27 Jun 2024 17:33:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CpnyU51TlcwZB1aJFqoq6elUk1Qbwu0yTXRZ2IUO/Ns=; b=pokdyx8eRj/05A3wF+BiAsb9mx tqqvN77AVnUuQmMVcWhW///ujJNa33bQZKyyt2EEZD/qGSD1F4wBLDMrTvCkbQNZ85Ii7iuk55cGP Oa8Ac36fZuBCbN8/AzmJlHg0pUD5335aldiCZUKMdHjYZLI0uwsSor7R5AhRZo29Zr8WnA5cYm+WX dZVE08W/16COeN2KdBR60UY8OUrZudF746sgz30NEspPRqN5VgonxobztpDQqk4HhJDzf6Mo0qytK 0BIVSVbtRdVeZ9kTgpM5xjudQknc0u7MUmU1Y84819RxUVO2uHiZZ3Hmoz87o3w3foQuU8LCaogYj GSNVJHyA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMt0A-0000000BDkS-1Qpt; Thu, 27 Jun 2024 17:33:42 +0000 Received: from mail-lf1-x12a.google.com ([2a00:1450:4864:20::12a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMsza-0000000BDOI-2Zop for linux-arm-kernel@lists.infradead.org; Thu, 27 Jun 2024 17:33:08 +0000 Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-52ce9ba0cedso6563454e87.2 for ; Thu, 27 Jun 2024 10:33:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719509585; x=1720114385; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CpnyU51TlcwZB1aJFqoq6elUk1Qbwu0yTXRZ2IUO/Ns=; b=PUOEtGrR9frW9Ej2aqL0PgE0gSGraktDbNhuNyrJVTdiScbGKmAg3BdqWtY/xKnL5c npV9FWCVBOJ2wrwhVblblJYaH5GgRqTaIt0JCgl8b6OyJh+Y01ORK6NGe4QteUhpbU00 lfioHCIFPBqysIX5SRsj+HrLvnuHuiLM7x7kitpCoIGOqJpedSRg5Mx03YEtd6ZCajZ9 att1K9lUk8KWQPaffoGM7YefRUy3XRw16qpyFHQc9AF9P5+vob9/+f0R5upOMhhQHlTl gaO8fTRMYlGpzhv59+3zyCLVtdhxb+J0qrqZV7orIpdiw/R3KK5B/J+1qYAnDgKr3LVD JCmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719509585; x=1720114385; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CpnyU51TlcwZB1aJFqoq6elUk1Qbwu0yTXRZ2IUO/Ns=; b=ZMfeVwg1vlkoOTuC7WjgOewy9139Y3Adv06iC5zP9dpMxroXiBsf3aMLgNW3DiBqDK QcZ76iGkmsPrm/nnJhvCDVdYz3zujncdF1Jec3GR552kmE+icISWsSCZY4alg1E3PwFM 9/xT9as9zMHzJpBdl2j3q+AU3CJIPEgH+J2aImpt09bY224YmCH8KYf/P45XnvTzbvv+ 0TkY6qlAmaf99USPxFRwI8JYw1X5U6N7QwpBmha7JgnQ16CxiFCN9B3iabctiJuZQNJd MZxh/SG8fKQr8nRv8FT5GzysLq5K9FLEu4orDNuJRe8F/hQLCl5loqxmwClzCitIVi84 TLcA== X-Forwarded-Encrypted: i=1; AJvYcCUieIgXV02LMPH+I9j5+6V/VR9VkQPCcqHomHj5Zyu3FOrBYabwAEx4iDGXMOZn5RDsZzkPWaKpqDWLaK/lV/YdE6mLXEAbaTklKX6O8uNhYXsixM0= X-Gm-Message-State: AOJu0YxO6xG9X4kIkm65GDDPVES8Y04opfnyDhcd6xHkH5rWy6tUdabn 9Hp+LwYa7WYJzv3NsswhIHzP/7SDulEUhlRs+GK3D1ZDP0ZLXBJY X-Google-Smtp-Source: AGHT+IFEHhkB8yhij4kAlXfST4kw9Upo+PorcNLsuxqy3u4kWTIlMv/7PlPLfMHQtZbGuH+dFaHhtw== X-Received: by 2002:a05:6512:138e:b0:52c:d76f:4604 with SMTP id 2adb3069b0e04-52ce1852745mr14344092e87.46.1719509584452; Thu, 27 Jun 2024 10:33:04 -0700 (PDT) Received: from localhost ([213.79.110.82]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-52e75434ef9sm137397e87.236.2024.06.27.10.33.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jun 2024 10:33:04 -0700 (PDT) From: Serge Semin To: Michal Simek , Alexander Stein , Borislav Petkov , Tony Luck , James Morse , Mauro Carvalho Chehab , Robert Richter , Manish Narani Cc: Serge Semin , Punnaiah Choudary Kalluri , Dinh Nguyen , Shubhrajyoti Datta , Arnd Bergmann , Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Shubhrajyoti Datta , Borislav Petkov Subject: [PATCH RESEND v6 03/18] EDAC/synopsys: Drop erroneous ADDRMAP4.addrmap_col_b10 parse Date: Thu, 27 Jun 2024 20:32:10 +0300 Message-ID: <20240627173251.25718-4-fancer.lancer@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240627173251.25718-1-fancer.lancer@gmail.com> References: <20240627173251.25718-1-fancer.lancer@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240627_103306_687124_AC20FFB3 X-CRM114-Status: GOOD ( 12.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Currently the ADDRMAP4.addrmap_col_b10 field gets to be parsed in case of the LPDDR3 memory and Quarter DQ bus width mode. It's wrong since that field is marked as unused for that mode in all the available DW uMCTL2 DDRC releases (up to IP-core v3.91a). Most likely the field parsing was added by mistake as a result of the copy-paste from the Half DQ bus width mode part of the same function. Even though the field is supposed to be always set to the UNUSED value (0x1F) drop parsing it anyway so to simplify the setup_column_address_map() method a tiny bit. Fixes: 1a81361f75d8 ("EDAC, synopsys: Add Error Injection support for ZynqMP DDR controller") Signed-off-by: Serge Semin Reviewed-by: Shubhrajyoti Datta --- drivers/edac/synopsys_edac.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/edac/synopsys_edac.c b/drivers/edac/synopsys_edac.c index 2b23d5ef9cff..88db777f3d90 100644 --- a/drivers/edac/synopsys_edac.c +++ b/drivers/edac/synopsys_edac.c @@ -1236,10 +1236,6 @@ static void setup_column_address_map(struct synps_edac_priv *priv, u32 *addrmap) COL_MAX_VAL_MASK) == COL_MAX_VAL_MASK) ? 0 : (((addrmap[3] >> 24) & COL_MAX_VAL_MASK) + COL_B9_BASE); - priv->col_shift[13] = ((addrmap[4] & - COL_MAX_VAL_MASK) == COL_MAX_VAL_MASK) ? 0 : - ((addrmap[4] & COL_MAX_VAL_MASK) + - COL_B10_BASE); } else { priv->col_shift[11] = (((addrmap[3] >> 16) & COL_MAX_VAL_MASK) == COL_MAX_VAL_MASK) ? 0 :