From patchwork Thu Jun 27 17:32:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Serge Semin X-Patchwork-Id: 13714939 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3E57DC30653 for ; Thu, 27 Jun 2024 17:34:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mdV0Lvy+a5+SJqvS1WBCJ7JSWbjxGckHrHXUW7MVCSc=; b=N4b0kh78ZnvhrTmeLC0GRTk2Uq aTMWUm1i69I8mm20kJdJeT39y0gYc3At2M2UAGuC48QwIED9L9X0Trc1XN9aveyNVzZthYIkSvsZa fcOjEH0IJaeCU8NGQh8VgTJHI0rTh97OvksdYjGeb4BnIOWY1wtrESDft5fATDMkkEyknx6lQBIGT 9RtrbFnlaJ+oB00plkPDub+EjQbKUg0R6kDtrWT3UK1IWGLg0rx4nLmqcgnXKs4SD9nfuyHC8EErC PdZO0QP7xcZ+j4IZOUKEhn+siNPkfftx/iZC/n0bVCRF3i5goY0bEW6Yz9TwKi/acPqb6uCgpILxJ FbShdYFw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMt0Z-0000000BE0c-21R9; Thu, 27 Jun 2024 17:34:07 +0000 Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMszh-0000000BDRe-29Hx for linux-arm-kernel@lists.infradead.org; Thu, 27 Jun 2024 17:33:14 +0000 Received: by mail-lf1-x12e.google.com with SMTP id 2adb3069b0e04-52cecba8d11so4058487e87.1 for ; Thu, 27 Jun 2024 10:33:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719509591; x=1720114391; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mdV0Lvy+a5+SJqvS1WBCJ7JSWbjxGckHrHXUW7MVCSc=; b=YOHmh0tkSTKHXTGpWNlFQQMRtsde4H8dBiU+9B7bSs6mZP6DXLgNGN9gZF1NEAU0Ee FeTYciI/OZASoZh0LfVicdI2rXumId9Q4+Gog1PT2UyjeAcJWN89A4NXPc3rNpqH2Zov ifmZz8SGVWbUOtNEBB/mek5BUGKIsTQDKYrHiiD+7OrlpiLI03DryfrvjdEGnimlRwBd CMcAVpvuAChmjlssA/UG7x1yB8/g5nJY08Ayg3R1MtNUtz1QW61EhS3AyJotGcGdOoCp 3Xgq6toNIEubaSwSnD0omxi3tD0SwVl3RC6BDn4+AM/gTHeMMg+Tn7Kk+bt2XZfH4yqH pJnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719509591; x=1720114391; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mdV0Lvy+a5+SJqvS1WBCJ7JSWbjxGckHrHXUW7MVCSc=; b=sarrbDfmioYwjCF7rop0PRbyj5ZS1NP/XmCMrWlsSwcutRDPqIKHQbb4NNN6w40BjF jf7lAJW84P+Tyu+KRLm4YyfrCsEi3yazhUlYux1y8pZl9Z6wqkClZG3/BV3r/FYRHm23 IS5WJ0nRh4mEt/X62ViqN+Fx2EgBXYFa3Kk7HChlLICJe38/9u3IDvzJh8kO1wA0Vid1 3JGyhGVQRs33tb133BVvwiHQPucgQTVdA0czqt2aDDLRayeJVGhgl7dgR1Vd/iPCFeYG pAdx68AFb093j/LOYFW1+uvxjkmzj1M+u+DNGDPscqocfYfdmmCCfb/t/V57zNoZfSA0 Z2Vw== X-Forwarded-Encrypted: i=1; AJvYcCX87X8NQ2aFy0AThND91+iCOWq9XRzizNaNAPkzmG6CvsUMTdgedPbwPGtQ2lpZWDEe01hGl5DCj3M8F1SI5d4A99JGHU6nzFVtD/ZSQOT7zwVM/w8= X-Gm-Message-State: AOJu0YzUH1GakSGU/g/52a5GE2QmcGSJ1WoxlfaWFtOquGH4TCoywrC8 ttvPznLzzsyvslKAgu25o3QNUOOmGOfb2ZciT/pgSWIVsqo7/M/z X-Google-Smtp-Source: AGHT+IFCW/oubEhvjv3B0kTePpucrzDUADEFWBF5xh655sCuWndfx77nKhIg84IyaO3jxlPiEXlPZQ== X-Received: by 2002:ac2:5490:0:b0:52c:dcea:86e2 with SMTP id 2adb3069b0e04-52ce183259fmr8591235e87.1.1719509591505; Thu, 27 Jun 2024 10:33:11 -0700 (PDT) Received: from localhost ([213.79.110.82]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-52e71329ea0sm266215e87.303.2024.06.27.10.33.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jun 2024 10:33:11 -0700 (PDT) From: Serge Semin To: Michal Simek , Alexander Stein , Borislav Petkov , Tony Luck , James Morse , Mauro Carvalho Chehab , Robert Richter Cc: Serge Semin , Punnaiah Choudary Kalluri , Dinh Nguyen , Shubhrajyoti Datta , Arnd Bergmann , Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH RESEND v6 06/18] EDAC/synopsys: Drop internal CE and UE counters Date: Thu, 27 Jun 2024 20:32:13 +0300 Message-ID: <20240627173251.25718-7-fancer.lancer@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240627173251.25718-1-fancer.lancer@gmail.com> References: <20240627173251.25718-1-fancer.lancer@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240627_103313_571968_9597292C X-CRM114-Status: GOOD ( 12.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org First of all these counters aren't exposed anyhow from the driver. Secondly the EDAC core already tracks the total amount of the correctable and uncorrectable errors (see mem_ctl_info.{ce_mc,ue_mc} fields usage). Drop the useless internal counters then for good. Signed-off-by: Serge Semin --- Changelog v4: - Drop redundant empty line. - Drop private counters access from the check_errors() method too. --- drivers/edac/synopsys_edac.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/drivers/edac/synopsys_edac.c b/drivers/edac/synopsys_edac.c index 3e98e907e2b9..07aaf4562847 100644 --- a/drivers/edac/synopsys_edac.c +++ b/drivers/edac/synopsys_edac.c @@ -304,8 +304,6 @@ struct synps_ecc_status { * @message: Buffer for framing the event specific info. * @stat: ECC status information. * @p_data: Platform data. - * @ce_cnt: Correctable Error count. - * @ue_cnt: Uncorrectable Error count. * @poison_addr: Data poison address. * @row_shift: Bit shifts for row bit. * @col_shift: Bit shifts for column bit. @@ -319,8 +317,6 @@ struct synps_edac_priv { char message[SYNPS_EDAC_MSG_SIZE]; struct synps_ecc_status stat; const struct synps_platform_data *p_data; - u32 ce_cnt; - u32 ue_cnt; #ifdef CONFIG_EDAC_DEBUG ulong poison_addr; u32 row_shift[18]; @@ -592,13 +588,8 @@ static irqreturn_t intr_handler(int irq, void *dev_id) if (status) return IRQ_NONE; - priv->ce_cnt += priv->stat.ce_cnt; - priv->ue_cnt += priv->stat.ue_cnt; handle_error(mci, &priv->stat); - edac_dbg(3, "Total error count CE %d UE %d\n", - priv->ce_cnt, priv->ue_cnt); - if (priv->p_data->quirks & SYNPS_ZYNQMP_IRQ_REGS) writel(regval, priv->baseaddr + DDR_QOS_IRQ_STAT_OFST); @@ -624,12 +615,7 @@ static void check_errors(struct mem_ctl_info *mci) if (status) return; - priv->ce_cnt += priv->stat.ce_cnt; - priv->ue_cnt += priv->stat.ue_cnt; handle_error(mci, &priv->stat); - - edac_dbg(3, "Total error count CE %d UE %d\n", - priv->ce_cnt, priv->ue_cnt); } /**