diff mbox series

iommu: Remove iommu_sva_unbind_gpasid

Message ID 20240628113011.3535-1-mark-pk.tsai@mediatek.com (mailing list archive)
State New, archived
Headers show
Series iommu: Remove iommu_sva_unbind_gpasid | expand

Commit Message

Mark-PK Tsai (蔡沛剛) June 28, 2024, 11:30 a.m. UTC
This is a left over of commit 0c9f17877891
("iommu: Remove guest pasid related interfaces and definitions")

Signed-off-by: Mark-PK Tsai <mark-pk.tsai@mediatek.com>
---
 include/linux/iommu.h | 2 --
 1 file changed, 2 deletions(-)

Comments

Baolu Lu June 28, 2024, 12:33 p.m. UTC | #1
On 2024/6/28 19:30, Mark-PK Tsai wrote:
> This is a left over of commit 0c9f17877891
> ("iommu: Remove guest pasid related interfaces and definitions")
> 
> Signed-off-by: Mark-PK Tsai <mark-pk.tsai@mediatek.com>
> ---
>   include/linux/iommu.h | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/include/linux/iommu.h b/include/linux/iommu.h
> index 17b3f36ad843..225403cfe614 100644
> --- a/include/linux/iommu.h
> +++ b/include/linux/iommu.h
> @@ -785,8 +785,6 @@ extern int iommu_attach_device(struct iommu_domain *domain,
>   			       struct device *dev);
>   extern void iommu_detach_device(struct iommu_domain *domain,
>   				struct device *dev);
> -extern int iommu_sva_unbind_gpasid(struct iommu_domain *domain,
> -				   struct device *dev, ioasid_t pasid);

Not sure why this still remains there. But it seems not alone.

$ git grep iommu_sva_unbind_gpasid
Documentation/userspace-api/iommu.rst:  int 
iommu_sva_unbind_gpasid(struct iommu_domain *domain,
include/linux/iommu.h:extern int iommu_sva_unbind_gpasid(struct 
iommu_domain *domain,

I believe the document should also be removed.

>   extern struct iommu_domain *iommu_get_domain_for_dev(struct device *dev);
>   extern struct iommu_domain *iommu_get_dma_domain(struct device *dev);
>   extern int iommu_map(struct iommu_domain *domain, unsigned long iova,

Best regards,
baolu
AngeloGioacchino Del Regno July 2, 2024, 5:42 a.m. UTC | #2
Il 28/06/24 13:30, Mark-PK Tsai ha scritto:
> This is a left over of commit 0c9f17877891
> ("iommu: Remove guest pasid related interfaces and definitions")
> 
> Signed-off-by: Mark-PK Tsai <mark-pk.tsai@mediatek.com>

Please also fix the documentation, after which:

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

> ---
>   include/linux/iommu.h | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/include/linux/iommu.h b/include/linux/iommu.h
> index 17b3f36ad843..225403cfe614 100644
> --- a/include/linux/iommu.h
> +++ b/include/linux/iommu.h
> @@ -785,8 +785,6 @@ extern int iommu_attach_device(struct iommu_domain *domain,
>   			       struct device *dev);
>   extern void iommu_detach_device(struct iommu_domain *domain,
>   				struct device *dev);
> -extern int iommu_sva_unbind_gpasid(struct iommu_domain *domain,
> -				   struct device *dev, ioasid_t pasid);
>   extern struct iommu_domain *iommu_get_domain_for_dev(struct device *dev);
>   extern struct iommu_domain *iommu_get_dma_domain(struct device *dev);
>   extern int iommu_map(struct iommu_domain *domain, unsigned long iova,
diff mbox series

Patch

diff --git a/include/linux/iommu.h b/include/linux/iommu.h
index 17b3f36ad843..225403cfe614 100644
--- a/include/linux/iommu.h
+++ b/include/linux/iommu.h
@@ -785,8 +785,6 @@  extern int iommu_attach_device(struct iommu_domain *domain,
 			       struct device *dev);
 extern void iommu_detach_device(struct iommu_domain *domain,
 				struct device *dev);
-extern int iommu_sva_unbind_gpasid(struct iommu_domain *domain,
-				   struct device *dev, ioasid_t pasid);
 extern struct iommu_domain *iommu_get_domain_for_dev(struct device *dev);
 extern struct iommu_domain *iommu_get_dma_domain(struct device *dev);
 extern int iommu_map(struct iommu_domain *domain, unsigned long iova,