From patchwork Sat Jun 29 04:53:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Rogers X-Patchwork-Id: 13716810 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 00C3DC27C4F for ; Sat, 29 Jun 2024 04:59:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:To:From:Subject :References:Mime-Version:Message-Id:In-Reply-To:Date:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tXeNLLIjOusU04UE8Hy39/PSXCvPCHHaHA66oarVl78=; b=MCbGEQvS2/7oQTE0iGKFfoA5mK 4LJWKFPLRSHHW4Om09YBDROsGRvjQMX3ikZNob04k47xRcR4FNF+UNmxQqaWRDccqUaeahS9JheRd F0m8JHivzBHr3q+6FILhbPwbYT6AnqetZXHz/AXGItFJvGtCqNoxRjtzi36nPyK88dyPxJtcsSznw TLGAekwN/GVxXLA+Wzya2eIJNTI06UGAakCwAeTepYMaW/qY91h2Arvo1hVEnL7cVXq11K0gWW4su yDHt33xgoUEOmNpEYE0KbuCo2xfWJBPTQLGGtkfEzS6Y3CxJWNJccnbslH5+kouj12v07wmSm0x3m ice6X9Xw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sNQAl-0000000FtSD-2L2k; Sat, 29 Jun 2024 04:58:51 +0000 Received: from mail-yw1-x114a.google.com ([2607:f8b0:4864:20::114a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sNQ79-0000000FrZD-1cGg for linux-arm-kernel@lists.infradead.org; Sat, 29 Jun 2024 04:55:08 +0000 Received: by mail-yw1-x114a.google.com with SMTP id 00721157ae682-62fb4a1f7bfso23209227b3.3 for ; Fri, 28 Jun 2024 21:55:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1719636906; x=1720241706; darn=lists.infradead.org; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=tXeNLLIjOusU04UE8Hy39/PSXCvPCHHaHA66oarVl78=; b=O082QPpNXt8TkQds/6bJx78PPfssliJ4nBPJqyFQNkNH3Oee2XSx6cqfCO9HP0rl8d 6hDNb2oJkmrE1t2B9/J24t9nm45PxzZ2oloVgm6c4nEGoyOHxM5MUqQOTpSvIexqFJli IRYUseL2Tx3HqmMrWWblRMi5GJ+AYXIo5B3J5AKR/BKA8JTisp2z0R+oPIiW/feBwnI0 sH1LIrR5N0qOlmjudWJDymd6q8Oi/7g4dI2qomIDAKpBQl+1eXEh3AX0qUSQGv0FmlQ4 QPRMjs0MnkFxQZO2A/G96DxfvyY59v/beu7OPFaoMDSBCbG4hmICZuyFpDXfzNavSXwe N3lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719636906; x=1720241706; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tXeNLLIjOusU04UE8Hy39/PSXCvPCHHaHA66oarVl78=; b=G/W8JDWJIx0cgTM2mb6gPXiBAXBxF08UqYM82kuyQhcH5mzovsZkvDgJDZfX+xeofy zLGxV5oBY29adPgSKqrwwYC1ZIcqKJska8Dn3JnwzsZsAkybQgidOQTxySaLJOMKynPk 3k3c8OZ4nHm6gHWj0GhZTmre9+VyTjVYUZ1Wz9mPdCWEJSZzxCq28A7mYONixvBCtpQ+ jnvvGD+myPArA+CmJixzC1y3rDtp20NTet8OigBEht+MfpETHAEtWBoXzhzqrdDxQY87 xv6ayYNm/kJo/jdgyRKdPwPbP6MPSZ4ZICvkppUa85HBJJfz2TbTVREuGeG7mh2mR2vK pIjg== X-Forwarded-Encrypted: i=1; AJvYcCXVSLDZIkf/Z0bGO7DKgrS4+DLsoNsRz4bicofTYyKLTQRL1tceTuB7POgVSkkF15YqNK3puuU9HLZvFT6wx1vllbiYyMf4TifUAnFRipVJ9ZefLpM= X-Gm-Message-State: AOJu0YxFayHEpShu0M4cwaWQpvR2nm3N/gOdlRbsFypq1Oq0dnlusYD3 M9H3b9AVsBW8wRiPc1mppd9YrrEY52kOD8NGMTy/8yU2jpw339EXNZAwRe1JAFFGsjQmt2gUXSF b2uQs6A== X-Google-Smtp-Source: AGHT+IElgs2HpFD5MWivgPA3hytPYyiaidrhsD3Cfduya8NVonmx78LKxebOFss3pklN6AQYkFlKfBM0tJNk X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:f9fe:7acd:496e:4edb]) (user=irogers job=sendgmr) by 2002:a25:4a41:0:b0:e03:5050:acc5 with SMTP id 3f1490d57ef6-e036eb5cfc0mr1539276.7.1719636906221; Fri, 28 Jun 2024 21:55:06 -0700 (PDT) Date: Fri, 28 Jun 2024 21:53:48 -0700 In-Reply-To: <20240629045350.285243-1-irogers@google.com> Message-Id: <20240629045350.285243-27-irogers@google.com> Mime-Version: 1.0 References: <20240629045350.285243-1-irogers@google.com> X-Mailer: git-send-email 2.45.2.803.g4e1b14247a-goog Subject: [PATCH v3 26/28] perf kwork: Use perf_tool__init From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Suzuki K Poulose , Yicong Yang , Jonathan Cameron , Nick Terrell , Nick Desaulniers , Oliver Upton , Anshuman Khandual , Song Liu , Ilkka Koskinen , Athira Rajeev , Huacai Chen , Yanteng Si , Sun Haiyong , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240628_215507_556704_E7701E51 X-CRM114-Status: GOOD ( 12.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Use perf_tool__init so that more uses of struct perf_tool can be const and not relying on perf_tool__fill_defaults. Signed-off-by: Ian Rogers --- tools/perf/builtin-kwork.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/tools/perf/builtin-kwork.c b/tools/perf/builtin-kwork.c index 8ffaa80a2d1d..6a4281b8fd10 100644 --- a/tools/perf/builtin-kwork.c +++ b/tools/perf/builtin-kwork.c @@ -2322,12 +2322,6 @@ int cmd_kwork(int argc, const char **argv) { static struct perf_kwork kwork = { .class_list = LIST_HEAD_INIT(kwork.class_list), - .tool = { - .mmap = perf_event__process_mmap, - .mmap2 = perf_event__process_mmap2, - .sample = perf_kwork__process_tracepoint_sample, - .ordered_events = true, - }, .atom_page_list = LIST_HEAD_INIT(kwork.atom_page_list), .sort_list = LIST_HEAD_INIT(kwork.sort_list), .cmp_id = LIST_HEAD_INIT(kwork.cmp_id), @@ -2462,6 +2456,11 @@ int cmd_kwork(int argc, const char **argv) "record", "report", "latency", "timehist", "top", NULL }; + perf_tool__init(&kwork.tool, /*ordered_events=*/true); + kwork.tool.mmap = perf_event__process_mmap; + kwork.tool.mmap2 = perf_event__process_mmap2; + kwork.tool.sample = perf_kwork__process_tracepoint_sample; + argc = parse_options_subcommand(argc, argv, kwork_options, kwork_subcommands, kwork_usage, PARSE_OPT_STOP_AT_NON_OPTION);